From: Boris Pismenny <borisp@mellanox.com>
To: Aditya Pakki <pakki001@umn.edu>
Cc: "kjlu@umn.edu" <kjlu@umn.edu>,
Saeed Mahameed <saeedm@mellanox.com>,
Leon Romanovsky <leon@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
Ilya Lesokhin <ilyal@mellanox.com>,
Wei Yongjun <weiyongjun1@huawei.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: mlx5: Add a missing check on idr_find
Date: Tue, 19 Mar 2019 13:41:49 +0000 [thread overview]
Message-ID: <e48d6cc9-9bb2-47fc-ec04-eceecbe6d91e@mellanox.com> (raw)
In-Reply-To: <20190318221924.7034-1-pakki001@umn.edu>
On 3/19/2019 12:18 AM, Aditya Pakki wrote:
> idr_find() can return a NULL value to 'flow' which is used without a check.
> The patch adds a check to avoid potential NULL pointer dereference.
Did you encounter this in practice?
This flow you are suggesting shouldn't be possible, because the handle
is always there until the socket is destroyed in sk_destruct.
But, I wouldn't mind some defensive coding here.
Maybe also a WARN_ONCE :)
Could you also release buf in case of an error returned from
mlx5_fpga_sbu_conn_sendmsg below?
Otherwise, I could submit a patch for this.
next prev parent reply other threads:[~2019-03-19 13:41 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-18 22:18 [PATCH] net: mlx5: Add a missing check on idr_find Aditya Pakki
2019-03-19 6:14 ` Leon Romanovsky
2019-03-19 13:41 ` Boris Pismenny [this message]
2019-03-19 14:35 ` Leon Romanovsky
2019-03-19 15:00 ` Boris Pismenny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e48d6cc9-9bb2-47fc-ec04-eceecbe6d91e@mellanox.com \
--to=borisp@mellanox.com \
--cc=davem@davemloft.net \
--cc=ilyal@mellanox.com \
--cc=kjlu@umn.edu \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pakki001@umn.edu \
--cc=saeedm@mellanox.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox