From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [PATCH] rdma-core: define link speed and link width enums Date: Mon, 8 May 2017 10:05:35 -0400 Message-ID: References: <1494251057-1060-1-git-send-email-devesh.sharma@broadcom.com> <20170508135404.GD10073@mtr-leonro.local> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170508135404.GD10073-U/DQcQFIOTAAJjI8aNfphQ@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , Devesh Sharma Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: linux-rdma@vger.kernel.org On 05/08/2017 09:54 AM, Leon Romanovsky wrote: > On Mon, May 08, 2017 at 09:44:17AM -0400, Devesh Sharma wrote: >> Currently application either need to define its own enum >> values for link-speed and link-width or use hard coded >> values. This patch inharits the enums from kernel space >> ib_verbs.h and puts into verbs.h for ease of programming. >> >> Signed-off-by: Devesh Sharma >> --- >> libibverbs/examples/devinfo.c | 22 ++++++++++++---------- >> libibverbs/verbs.h | 18 ++++++++++++++++++ >> 2 files changed, 30 insertions(+), 10 deletions(-) > > I think the better approach will be move these defines from > include/rdma/ib_verbs.h to include/uapi/rdma/ib_user_verbs.h > and reuse ib_user_verbs.h file directly in libibverbs. I agree on this. Please put this stuff in the uapi header file and include that in user space. -Denny -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html