From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D54947A5F for ; Thu, 25 Jan 2024 12:30:27 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706185828; cv=none; b=M/91rnQ8HADuTh5f8ShmxDVoijW/0RCX2cFNFBeJcitKYn6/vwKUaFWCe6y2sUcdOyXcqNJ/Wc56JnuUx6KmGLR+b+q5jfRMg/W2AEMG+6Kba9nGV3jVQAe8cQq7BCaC73JFmeqte37h9xn3/eaDyn2wNCo6jyuv+AIWl4iWxfE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706185828; c=relaxed/simple; bh=bTHbnS9yo4CvNNusnF2P+/dKr8Iic7vbsx9Lh/ALNHU=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=rx0uNaNuRwrULWetlV3xGCRUBq3ibxg0e/QdNaNSLklORClwtBNw9Zs0axf8TrNZoNkWFE0JuDBQEy2NuDJ+zEwZP7HHpezYNZP5jJhFrVo+l2q/MrpteITgIHqn2cs/wOkB7Qqsim1kOgg7uNiiAJS6LdCysuTfz2zhu3uak4o= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Au3ZoXmQ; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Au3ZoXmQ" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 01A6BC43390; Thu, 25 Jan 2024 12:30:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1706185827; bh=bTHbnS9yo4CvNNusnF2P+/dKr8Iic7vbsx9Lh/ALNHU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Au3ZoXmQwPQCJLiNfozZubpGoe0GcxhhBDPCRsZ58yrthpMHwwjkZ2JrR+P8/aehT nOtI5UW47kjP1NsSHyuKpZrknCBeDrzgzAulm/D/TThGh18efXXWU/jPpqXPNQMUPy GD0f7VsNNYN3KROKujNfIUi3068b/ITCw581gu+eZl8koavg9gYvEvvn2uo4SziDPg SKSL4ah+65bQoNT/c7GjV2liFSaJq7H5yKRxqae5UBUdNbxPinOlHUQW6ECl2pgd1D gelnmInN2EMa8Uex+LyiYTjZjGMvdHAU2hLNjJQD6jPuqsI76gZed9eGkE2FvUD7/Y mRchdtrfJRpeg== From: Leon Romanovsky To: Jason Gunthorpe Cc: Mark Zhang , Edward Srouji , linux-rdma@vger.kernel.org, Maor Gottlieb , Michael Guralnik Subject: [PATCH rdma-next 2/6] IB/mlx5: Don't expose debugfs entries for RRoCE general parameters if not supported Date: Thu, 25 Jan 2024 14:30:08 +0200 Message-ID: X-Mailer: git-send-email 2.43.0 In-Reply-To: References: Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Mark Zhang debugfs entries for RRoCE general CC parameters must be exposed only when they are supported, otherwise when accessing them there may be a syndrome error in kernel log, for example: $ cat /sys/kernel/debug/mlx5/0000:08:00.1/cc_params/rtt_resp_dscp cat: '/sys/kernel/debug/mlx5/0000:08:00.1/cc_params/rtt_resp_dscp': Invalid argument $ dmesg mlx5_core 0000:08:00.1: mlx5_cmd_out_err:805:(pid 1253): QUERY_CONG_PARAMS(0x824) op_mod(0x0) failed, status bad parameter(0x3), syndrome (0x325a82), err(-22) Fixes: 66fb1d5df6ac ("IB/mlx5: Extend debug control for CC parameters") Reviewed-by: Edward Srouji Signed-off-by: Mark Zhang Signed-off-by: Leon Romanovsky --- drivers/infiniband/hw/mlx5/cong.c | 6 ++++++ include/linux/mlx5/mlx5_ifc.h | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/infiniband/hw/mlx5/cong.c b/drivers/infiniband/hw/mlx5/cong.c index f87531318feb..a78a067e3ce7 100644 --- a/drivers/infiniband/hw/mlx5/cong.c +++ b/drivers/infiniband/hw/mlx5/cong.c @@ -458,6 +458,12 @@ void mlx5_ib_init_cong_debugfs(struct mlx5_ib_dev *dev, u32 port_num) dbg_cc_params->root = debugfs_create_dir("cc_params", mlx5_debugfs_get_dev_root(mdev)); for (i = 0; i < MLX5_IB_DBG_CC_MAX; i++) { + if ((i == MLX5_IB_DBG_CC_GENERAL_RTT_RESP_DSCP_VALID || + i == MLX5_IB_DBG_CC_GENERAL_RTT_RESP_DSCP)) + if (!MLX5_CAP_GEN(mdev, roce) || + !MLX5_CAP_ROCE(mdev, roce_cc_general)) + continue; + dbg_cc_params->params[i].offset = i; dbg_cc_params->params[i].dev = dev; dbg_cc_params->params[i].port_num = port_num; diff --git a/include/linux/mlx5/mlx5_ifc.h b/include/linux/mlx5/mlx5_ifc.h index bf5320b28b8b..2c10350bd422 100644 --- a/include/linux/mlx5/mlx5_ifc.h +++ b/include/linux/mlx5/mlx5_ifc.h @@ -1103,7 +1103,7 @@ struct mlx5_ifc_roce_cap_bits { u8 sw_r_roce_src_udp_port[0x1]; u8 fl_rc_qp_when_roce_disabled[0x1]; u8 fl_rc_qp_when_roce_enabled[0x1]; - u8 reserved_at_7[0x1]; + u8 roce_cc_general[0x1]; u8 qp_ooo_transmit_default[0x1]; u8 reserved_at_9[0x15]; u8 qp_ts_format[0x2]; -- 2.43.0