Re: [PATCH for-next] RDMA/efa: Reset device on probe failure

[Gal Pressman <gal.pressman@linux.dev>]

On 30/12/2024 8:46, Gal Pressman wrote:
> On 25/12/2024 15:15, Michael Margolin wrote:
>> Make sure the device is being reset on driver exit whatever the reason
>> is, to keep the device aligned and allow it to close shared resources
>> (e.g. admin queue).
>>
>> Reviewed-by: Firas Jahjah <firasj@amazon.com>
>> Reviewed-by: Yonatan Nachum <ynachum@amazon.com>
>> Signed-off-by: Michael Margolin <mrgolin@amazon.com>
>> ---
>> @@ -685,7 +685,7 @@ static void efa_remove(struct pci_dev *pdev)
>>  	struct efa_dev *dev = pci_get_drvdata(pdev);
>>  
>>  	efa_ib_device_remove(dev);
> 
> This already calls efa_com_dev_reset(), you now perform double reset in
> the normal remove flow.

Sorry, I obviously missed the part that removed it from
efa_ib_device_remove().

Reviewed-by: Gal Pressman <gal.pressman@linux.dev>

> 
>> -	efa_remove_device(pdev);
>> +	efa_remove_device(pdev, false);
>>  }