From: Sagi Grimberg <sagi@grimberg.me>
To: Max Gurtovoy <mgurtovoy@nvidia.com>,
linux-rdma@vger.kernel.org, dledford@redhat.com, jgg@nvidia.com,
leonro@nvidia.com
Cc: oren@nvidia.com, Israel Rukshin <israelr@nvidia.com>
Subject: Re: [PATCH 3/3] IB/isert: simplify signature cap check
Date: Wed, 13 Jan 2021 16:08:29 -0800 [thread overview]
Message-ID: <ea24823d-c1e9-d40f-866b-6671a13c08ad@grimberg.me> (raw)
In-Reply-To: <20210110111903.486681-3-mgurtovoy@nvidia.com>
> Use if/else clause instead of "condition ? val1 : val2" to make the code
> cleaner and simpler.
Not sure what is cleaner and simpler for a simple condition, but I don't
mind either way...
Acked-by: Sagi Grimberg <sagi@grimberg.me>
next prev parent reply other threads:[~2021-01-14 1:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-10 11:19 [PATCH 1/3] IB/isert: remove unneeded new lines Max Gurtovoy
2021-01-10 11:19 ` [PATCH 2/3] IB/isert: remove unneeded semicolon Max Gurtovoy
2021-01-10 11:36 ` Leon Romanovsky
2021-01-10 12:07 ` Max Gurtovoy
2021-01-14 0:07 ` Sagi Grimberg
2021-01-10 11:19 ` [PATCH 3/3] IB/isert: simplify signature cap check Max Gurtovoy
2021-01-14 0:08 ` Sagi Grimberg [this message]
2021-01-14 7:29 ` Leon Romanovsky
2021-01-14 12:49 ` Jason Gunthorpe
2021-01-14 12:54 ` Max Gurtovoy
2021-01-14 13:00 ` Leon Romanovsky
2021-01-14 12:59 ` Leon Romanovsky
2021-01-14 0:06 ` [PATCH 1/3] IB/isert: remove unneeded new lines Sagi Grimberg
2021-01-18 21:02 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ea24823d-c1e9-d40f-866b-6671a13c08ad@grimberg.me \
--to=sagi@grimberg.me \
--cc=dledford@redhat.com \
--cc=israelr@nvidia.com \
--cc=jgg@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=mgurtovoy@nvidia.com \
--cc=oren@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox