From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out30-98.freemail.mail.aliyun.com (out30-98.freemail.mail.aliyun.com [115.124.30.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 090E020B205; Thu, 6 Mar 2025 12:12:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.124.30.98 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741263130; cv=none; b=H7i2T6fhF0RGggAY4U1ov2/NEpk+H8vhRev//a/vU5ZtnK8YCi/xrUhxKBg61XqS/CEITARQpLuIKoY2BoNSJrAw8n/GQGYgPkvgA18skXZNbqu/l3x9vROi8Kos78+s9kHawt1KlkbEbPtE0wujUTSJH/ra+WUSjR/hCVwsCCc= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1741263130; c=relaxed/simple; bh=hasl9comeLm9EzxCXmoZgYUYl8ez8CcNANE4//+OiVM=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=giGnOj12QBwNjqLVMmDQw2awW5AEOW2aLxpyh/Zw6wWfIZUUDOYvtLJmxEkRszJ2foiWhL/kJ2V2JTCxWbiCH/bPsny9RUDwLCWDpMx9UXJcxjD8hz1LlaxK+n6JJrtTQdF1skq+3uqk5zeHbJqgvP2079xzx6+ET1/dOEEuf8M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com; spf=pass smtp.mailfrom=linux.alibaba.com; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b=wc1iVtD1; arc=none smtp.client-ip=115.124.30.98 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.alibaba.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.alibaba.com header.i=@linux.alibaba.com header.b="wc1iVtD1" DKIM-Signature:v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.alibaba.com; s=default; t=1741263122; h=Message-ID:Date:MIME-Version:Subject:To:From:Content-Type; bh=Da5GvoMYHK+n2EpSfkWr3DP2DBfqQWCYmifpDQl2QNg=; b=wc1iVtD1Qo3ILIuytPcEdjn5eROLIApU5KkCSaqmAl6RWUEKqGb7hOczAM1uLM5+LTkiniU2drGLIAI1tAjxLSQSyqd8lnuHF8XvYis3oVfAvT4ABU3GN2STDoSI0M534aROmdYf9kaEsOT0e+9k4sNgKo3j/4xm52Om1IO6cRE= Received: from 30.221.97.194(mailfrom:chengyou@linux.alibaba.com fp:SMTPD_---0WQomNor_1741262800 cluster:ay36) by smtp.aliyun-inc.com; Thu, 06 Mar 2025 20:06:40 +0800 Message-ID: Date: Thu, 6 Mar 2025 20:06:40 +0800 Precedence: bulk X-Mailing-List: linux-rdma@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.15.1 Subject: Re: [PATCH] RDMA/erdma: Prevent use-after-free in erdma_accept_newconn() Content-Language: en-US To: Leon Romanovsky , Markus Elfring Cc: kernel-janitors@vger.kernel.org, linux-rdma@vger.kernel.org, Jason Gunthorpe , Kai Shen , Yang Li , cocci@inria.fr, LKML , Christophe Leroy References: <167179d0-e1ea-39a8-4143-949ad57294c2@linux.alibaba.com> <20a1a47c-8906-44e8-92e6-9b3e698b1491@web.de> <20250306084754.GR1955273@unreal> From: Cheng Xu In-Reply-To: <20250306084754.GR1955273@unreal> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit On 3/6/25 4:47 PM, Leon Romanovsky wrote: > On Wed, Mar 05, 2025 at 03:20:41PM +0100, Markus Elfring wrote: >> From: Markus Elfring >> Date: Wed, 5 Mar 2025 15:07:51 +0100 >> >> The implementation of the function “erdma_accept_newconn” contained >> still the statement “new_cep->sock = NULL” after >> the function call “erdma_cep_put(new_cep)”. >> Thus delete an inappropriate reset action. >> >> Reported-by: Cheng Xu > > Cheng, please resubmit this patch, I'm experiencing the same issues as > Christophe has here https://lore.kernel.org/all/20a1a47c-8906-44e8-92e6-9b3e698b1491@web.de > and it looks like Markus continues do not listen to the feedback. > Hi Leon, Sure, I just resubmitted the patch, please review and apply. Thanks, Cheng Xu > Thanks