From: Guoqing Jiang <guoqing.jiang@linux.dev>
To: Bernard Metzler <bmt@zurich.ibm.com>, linux-rdma@vger.kernel.org
Cc: jgg@ziepe.ca, leon@kernel.org
Subject: Re: [PATCH] RDMA/siw: Fix tx thread initialization.
Date: Fri, 28 Jul 2023 19:57:36 +0800 [thread overview]
Message-ID: <eded8d1e-3df1-7bb4-8788-ac0e5155c9a3@linux.dev> (raw)
In-Reply-To: <20230728114418.124328-1-bmt@zurich.ibm.com>
On 7/28/23 19:44, Bernard Metzler wrote:
> Immediately removing the siw module after insertion may
> crash in siw_stop_tx_thread(), if the according thread did
> not yet had a chance to initialize its wait queue and
> siw_stop_tx_thread() tries to wakeup that thread. Initializing
> the threads state before spwaning it fixes it.
>
> Reported-by: Guoqing Jiang <guoqing.jiang@linux.dev>
> Signed-off-by: Bernard Metzler <bmt@zurich.ibm.com>
> ---
> drivers/infiniband/sw/siw/siw.h | 3 +-
> drivers/infiniband/sw/siw/siw_main.c | 40 ++----------------------
> drivers/infiniband/sw/siw/siw_qp_tx.c | 44 +++++++++++++++++++++++----
> 3 files changed, 43 insertions(+), 44 deletions(-)
It works for me.
Tested-by: Guoqing Jiang <guoqing.jiang@linux.dev>
Thanks,
Guoqing
next prev parent reply other threads:[~2023-07-28 11:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-07-28 11:44 [PATCH] RDMA/siw: Fix tx thread initialization Bernard Metzler
2023-07-28 11:57 ` Guoqing Jiang [this message]
2023-07-30 13:18 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eded8d1e-3df1-7bb4-8788-ac0e5155c9a3@linux.dev \
--to=guoqing.jiang@linux.dev \
--cc=bmt@zurich.ibm.com \
--cc=jgg@ziepe.ca \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox