Re: qedr memory leak report

Leon Romanovsky
2019-08-31T15:20:02Z

On Sat, Aug 31, 2019 at 10:33:13AM -0400, Doug Ledford wrote:
> On Sat, 2019-08-31 at 10:30 +0300, Leon Romanovsky wrote:
> > Doug,
> >
> > I think that it can be counted as good example why allowing memory
> > leaks
> > in drivers (HNS) is not so great idea.
>
> Crashing the machine is worse.

The problem with it that you are "punishing" whole subsystem
because of some piece of crap which anyway users can't buy.
If HNS wants to have memory leaks, they need to do it outside
of upstream kernel.

In general, if users buy shitty hardware, they need to be ready
to have kernel panics too. It works with faulty DRAM where kernel
doesn't hide such failures, so don't see any rationale to invent
something special for ib_device.

Thanks