Linux RDMA and InfiniBand development
 help / color / mirror / Atom feed
From: Casey Schaufler <casey@schaufler-ca.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>, netdev@vger.kernel.org
Cc: horms@kernel.org, kuba@kernel.org, pabeni@redhat.com,
	edumazet@google.com, davem@davemloft.net,
	"Jason Gunthorpe" <jgg@ziepe.ca>,
	"Leon Romanovsky" <leon@kernel.org>,
	"Andrew Lunn" <andrew+netdev@lunn.ch>,
	"Tony Nguyen" <anthony.l.nguyen@intel.com>,
	"Przemek Kitszel" <przemyslaw.kitszel@intel.com>,
	"Elad Nachman" <enachman@marvell.com>,
	"Saeed Mahameed" <saeedm@nvidia.com>,
	"Tariq Toukan" <tariqt@nvidia.com>,
	"Mark Bloch" <mbloch@nvidia.com>,
	"Ido Schimmel" <idosch@nvidia.com>,
	"Petr Machata" <petrm@nvidia.com>,
	"Edward Cree" <ecree.xilinx@gmail.com>,
	"Maxime Chevallier" <maxime.chevallier@bootlin.com>,
	"Maxime Coquelin" <mcoquelin.stm32@gmail.com>,
	"Alexandre Torgue" <alexandre.torgue@foss.st.com>,
	"Arend van Spriel" <arend.vanspriel@broadcom.com>,
	"Miri Korenblit" <miriam.rachel.korenblit@intel.com>,
	"Keith Busch" <kbusch@kernel.org>, "Jens Axboe" <axboe@kernel.dk>,
	"Christoph Hellwig" <hch@lst.de>,
	"Sagi Grimberg" <sagi@grimberg.me>,
	"Chaitanya Kulkarni" <kch@nvidia.com>,
	"Saurav Kashyap" <skashyap@marvell.com>,
	"Javed Hasan" <jhasan@marvell.com>,
	GR-QLogic-Storage-Upstream@marvell.com,
	"James E.J. Bottomley" <James.Bottomley@HansenPartnership.com>,
	"Martin K. Petersen" <mkp@kernel.org>,
	"Nilesh Javali" <njavali@marvell.com>,
	"Manish Rangankar" <mrangankar@marvell.com>,
	"Varun Prakash" <varun@chelsio.com>,
	"Alexander Viro" <viro@zeniv.linux.org.uk>,
	"Christian Brauner" <brauner@kernel.org>,
	"Jan Kara" <jack@suse.cz>, "David Howells" <dhowells@redhat.com>,
	"Marc Dionne" <marc.dionne@auristor.com>,
	"Trond Myklebust" <trondmy@kernel.org>,
	"Anna Schumaker" <anna@kernel.org>,
	"Chuck Lever" <cel@kernel.org>,
	"Jeff Layton" <jlayton@kernel.org>, NeilBrown <neil@brown.name>,
	"Olga Kornievskaia" <okorniev@redhat.com>,
	"Dai Ngo" <Dai.Ngo@oracle.com>, "Tom Talpey" <tom@talpey.com>,
	"Marek Lindner" <marek.lindner@mailbox.org>,
	"Simon Wunderlich" <sw@simonwunderlich.de>,
	"Antonio Quartulli" <antonio@mandelbit.com>,
	"Sven Eckelmann" <sven@narfation.org>,
	"Nikolay Aleksandrov" <razor@blackwall.org>,
	"Pablo Neira Ayuso" <pablo@netfilter.org>,
	"Florian Westphal" <fw@strlen.de>, "Phil Sutter" <phil@nwl.cc>,
	"Johannes Berg" <johannes@sipsolutions.net>,
	"Matthieu Baerts" <matttbe@kernel.org>,
	"Mat Martineau" <martineau@kernel.org>,
	"Geliang Tang" <geliang@kernel.org>,
	"Julian Anastasov" <ja@ssi.bg>,
	"Aaron Conole" <aconole@redhat.com>,
	"Eelco Chaudron" <echaudro@redhat.com>,
	"Ilya Maximets" <i.maximets@ovn.org>,
	"Allison Henderson" <achender@kernel.org>,
	"Jamal Hadi Salim" <jhs@mojatatu.com>,
	"Jiri Pirko" <jiri@resnulli.us>,
	"Marcelo Ricardo Leitner" <marcelo.leitner@gmail.com>,
	"Xin Long" <lucien.xin@gmail.com>,
	"D. Wythe" <alibuda@linux.alibaba.com>,
	"Dust Li" <dust.li@linux.alibaba.com>,
	"Sidraya Jayagond" <sidraya@linux.ibm.com>,
	"Mahanta Jambigi" <mjambigi@linux.ibm.com>,
	"Tony Lu" <tonylu@linux.alibaba.com>,
	"Wen Gu" <guwen@linux.alibaba.com>,
	"Jon Maloy" <jmaloy@redhat.com>,
	"Tung Quang Nguyen" <tung.quang.nguyen@est.tech>,
	"Steffen Klassert" <steffen.klassert@secunet.com>,
	"Herbert Xu" <herbert@gondor.apana.org.au>,
	"Paul Moore" <paul@paul-moore.com>,
	"James Morris" <jmorris@namei.org>,
	"Serge E. Hallyn" <serge@hallyn.com>,
	"Vikas Gupta" <vikas.gupta@broadcom.com>,
	"Bhargava Marreddy" <bhargava.marreddy@broadcom.com>,
	"Rajashekar Hudumula" <rajashekar.hudumula@broadcom.com>,
	"Nicolai Buchwitz" <nb@tipi-net.de>,
	"Markus Blöchl" <markus@blochl.de>,
	"Arnd Bergmann" <arnd@arndb.de>,
	"Heiner Kallweit" <hkallweit1@gmail.com>,
	"Florian Fainelli" <florian.fainelli@broadcom.com>,
	"Krzysztof Kozlowski" <krzk@kernel.org>,
	"Qingfang Deng" <qingfang.deng@linux.dev>,
	"Julian Braha" <julianbraha@gmail.com>,
	"Ethan Nelson-Moore" <enelsonmoore@gmail.com>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Eric Biggers" <ebiggers@kernel.org>,
	"Ard Biesheuvel" <ardb@kernel.org>,
	"Neal Cardwell" <ncardwell@google.com>,
	"Kuniyuki Iwashima" <kuniyu@google.com>,
	"Willem de Bruijn" <willemb@google.com>,
	"Alyssa Ross" <hi@alyssa.is>,
	"Joel Granados" <joel.granados@kernel.org>,
	"Oleg Nesterov" <oleg@redhat.com>,
	linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org,
	intel-wired-lan@lists.osuosl.org, oss-drivers@corigine.com,
	linux-net-drivers@amd.com,
	linux-stm32@st-md-mailman.stormreply.com,
	linux-arm-kernel@lists.infradead.org,
	linux-wireless@vger.kernel.org, brcm80211@lists.linux.dev,
	brcm80211-dev-list.pdl@broadcom.com,
	linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org,
	target-devel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	linux-afs@lists.infradead.org, linux-nfs@vger.kernel.org,
	b.a.t.m.a.n@lists.open-mesh.org, bridge@lists.linux.dev,
	netfilter-devel@vger.kernel.org, coreteam@netfilter.org,
	mptcp@lists.linux.dev, lvs-devel@vger.kernel.org,
	dev@openvswitch.org, rds-devel@oss.oracle.com,
	linux-sctp@vger.kernel.org, linux-s390@vger.kernel.org,
	tipc-discussion@lists.sourceforge.net,
	linux-security-module@vger.kernel.org,
	"Casey Schaufler" <casey@schaufler-ca.com>
Subject: Re: [PATCH 01/13 net-next] net: ipv4: introduce CONFIG_IPV4 to decouple the IPv4 stack
Date: Fri, 11 Sep 2026 10:46:00 -0700	[thread overview]
Message-ID: <ee89e26c-3dad-450b-8861-badf19afa141@schaufler-ca.com> (raw)
In-Reply-To: <20260910144914.8025-2-fmancera@suse.de>

On 9/10/2026 7:48 AM, Fernando Fernandez Mancera wrote:
> Historically, the IPv4 protocol has been linked to the core INET
> subsystem. Because shared infrastructure like the TCP/UDP engine,
> routing or INET hashtables live inside net/ipv4/, it has been impossible
> to compile a kernel with only IPv6 support.
>
> This patch introduces the CONFIG_IPV4 Kconfig symbol, which is set to
> 'def_bool y' for now. This does not allow to completely disable the
> IPv4 stack yet but it lays the necessary build-system work for that
> goal.
>
> In addition, multiple subsystems Kconfig symbols across networking
> features like tunnels, drivers and filesystems have been adjusted to
> depend on IPv4. Keep on mind that follow-up work is required to convert
> the Kconfig symbol to bool and remove the dependency on IPv4 where it
> makes sense.
>
> Signed-off-by: Fernando Fernandez Mancera <fmancera@suse.de>
> ---
>  

...


>  security/smack/Kconfig                        |  1 +
>  54 files changed, 126 insertions(+), 66 deletions(-)
>
...

> diff --git a/security/smack/Kconfig b/security/smack/Kconfig
> index 5a8dfad469c3..b4e6d0168bd1 100644
> --- a/security/smack/Kconfig
> +++ b/security/smack/Kconfig
> @@ -3,6 +3,7 @@ config SECURITY_SMACK
>  	bool "Simplified Mandatory Access Control Kernel Support"
>  	depends on NET
>  	depends on INET
> +	depends on IPV4
>  	depends on SECURITY
>  	select NETLABEL
>  	select SECURITY_NETWORK

Why would this make sense? You're introducing the capability to use
IP6 by itself, which is admirable, but you're disallowing that configuration
with the Smack LSM. It appears that you've done a mechanical lookup in the
Kconfig files and applied the minimal change to make the kernel compile,
which probably works for most cases. It does not work for Smack. Unless
there's a strong argument that Smack with IPv6 and without IPv4 is and always
will be a pointless configuration you have my NAK.


  parent reply	other threads:[~2026-09-11 18:17 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20260910144914.8025-1-fmancera@suse.de>
2026-09-10 14:48 ` [PATCH 01/13 net-next] net: ipv4: introduce CONFIG_IPV4 to decouple the IPv4 stack Fernando Fernandez Mancera
2026-09-10 15:11   ` Nicolai Buchwitz
2026-09-10 15:32     ` Fernando Fernandez Mancera
2026-09-10 15:36     ` Arnd Bergmann
2026-09-10 16:22   ` Fernando Fernandez Mancera
2026-09-10 16:30     ` Fernando Fernandez Mancera
2026-09-10 16:56   ` Sven Eckelmann
2026-09-11 18:39     ` Fernando Fernandez Mancera
2026-09-10 18:55   ` Chuck Lever
2026-09-11 15:15   ` sashiko-bot
2026-09-11 17:46   ` Casey Schaufler [this message]
2026-09-11 18:31     ` Fernando Fernandez Mancera
2026-09-11 18:59       ` Casey Schaufler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ee89e26c-3dad-450b-8861-badf19afa141@schaufler-ca.com \
    --to=casey@schaufler-ca.com \
    --cc=Dai.Ngo@oracle.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=James.Bottomley@HansenPartnership.com \
    --cc=achender@kernel.org \
    --cc=aconole@redhat.com \
    --cc=alexandre.torgue@foss.st.com \
    --cc=alibuda@linux.alibaba.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=anna@kernel.org \
    --cc=anthony.l.nguyen@intel.com \
    --cc=antonio@mandelbit.com \
    --cc=ardb@kernel.org \
    --cc=arend.vanspriel@broadcom.com \
    --cc=arnd@arndb.de \
    --cc=axboe@kernel.dk \
    --cc=b.a.t.m.a.n@lists.open-mesh.org \
    --cc=bhargava.marreddy@broadcom.com \
    --cc=brauner@kernel.org \
    --cc=brcm80211-dev-list.pdl@broadcom.com \
    --cc=brcm80211@lists.linux.dev \
    --cc=bridge@lists.linux.dev \
    --cc=cel@kernel.org \
    --cc=coreteam@netfilter.org \
    --cc=davem@davemloft.net \
    --cc=dev@openvswitch.org \
    --cc=dhowells@redhat.com \
    --cc=dust.li@linux.alibaba.com \
    --cc=ebiggers@kernel.org \
    --cc=echaudro@redhat.com \
    --cc=ecree.xilinx@gmail.com \
    --cc=edumazet@google.com \
    --cc=enachman@marvell.com \
    --cc=enelsonmoore@gmail.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=fmancera@suse.de \
    --cc=fw@strlen.de \
    --cc=geliang@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=guwen@linux.alibaba.com \
    --cc=hch@lst.de \
    --cc=herbert@gondor.apana.org.au \
    --cc=hi@alyssa.is \
    --cc=hkallweit1@gmail.com \
    --cc=horms@kernel.org \
    --cc=i.maximets@ovn.org \
    --cc=idosch@nvidia.com \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=ja@ssi.bg \
    --cc=jack@suse.cz \
    --cc=jgg@ziepe.ca \
    --cc=jhasan@marvell.com \
    --cc=jhs@mojatatu.com \
    --cc=jiri@resnulli.us \
    --cc=jlayton@kernel.org \
    --cc=jmaloy@redhat.com \
    --cc=jmorris@namei.org \
    --cc=joel.granados@kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=julianbraha@gmail.com \
    --cc=kbusch@kernel.org \
    --cc=kch@nvidia.com \
    --cc=krzk@kernel.org \
    --cc=kuba@kernel.org \
    --cc=kuniyu@google.com \
    --cc=leon@kernel.org \
    --cc=linux-afs@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-net-drivers@amd.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=linux-nvme@lists.infradead.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linux-s390@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=linux-sctp@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=linux-stm32@st-md-mailman.stormreply.com \
    --cc=linux-wireless@vger.kernel.org \
    --cc=lucien.xin@gmail.com \
    --cc=lvs-devel@vger.kernel.org \
    --cc=marc.dionne@auristor.com \
    --cc=marcelo.leitner@gmail.com \
    --cc=marek.lindner@mailbox.org \
    --cc=markus@blochl.de \
    --cc=martineau@kernel.org \
    --cc=matttbe@kernel.org \
    --cc=maxime.chevallier@bootlin.com \
    --cc=mbloch@nvidia.com \
    --cc=mcoquelin.stm32@gmail.com \
    --cc=miriam.rachel.korenblit@intel.com \
    --cc=mjambigi@linux.ibm.com \
    --cc=mkp@kernel.org \
    --cc=mptcp@lists.linux.dev \
    --cc=mrangankar@marvell.com \
    --cc=nb@tipi-net.de \
    --cc=ncardwell@google.com \
    --cc=neil@brown.name \
    --cc=netdev@vger.kernel.org \
    --cc=netfilter-devel@vger.kernel.org \
    --cc=njavali@marvell.com \
    --cc=okorniev@redhat.com \
    --cc=oleg@redhat.com \
    --cc=oss-drivers@corigine.com \
    --cc=pabeni@redhat.com \
    --cc=pablo@netfilter.org \
    --cc=paul@paul-moore.com \
    --cc=petrm@nvidia.com \
    --cc=phil@nwl.cc \
    --cc=przemyslaw.kitszel@intel.com \
    --cc=qingfang.deng@linux.dev \
    --cc=rajashekar.hudumula@broadcom.com \
    --cc=razor@blackwall.org \
    --cc=rds-devel@oss.oracle.com \
    --cc=saeedm@nvidia.com \
    --cc=sagi@grimberg.me \
    --cc=serge@hallyn.com \
    --cc=sidraya@linux.ibm.com \
    --cc=skashyap@marvell.com \
    --cc=steffen.klassert@secunet.com \
    --cc=sven@narfation.org \
    --cc=sw@simonwunderlich.de \
    --cc=target-devel@vger.kernel.org \
    --cc=tariqt@nvidia.com \
    --cc=tipc-discussion@lists.sourceforge.net \
    --cc=tom@talpey.com \
    --cc=tonylu@linux.alibaba.com \
    --cc=trondmy@kernel.org \
    --cc=tung.quang.nguyen@est.tech \
    --cc=varun@chelsio.com \
    --cc=vikas.gupta@broadcom.com \
    --cc=viro@zeniv.linux.org.uk \
    --cc=willemb@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox