From: "santosh.shilimkar@oracle.com" <santosh.shilimkar@oracle.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Avinash Repaka <avinash.repaka@oracle.com>,
linux-rdma@vger.kernel.org, rds-devel@oss.oracle.com,
kernel-janitors@vger.kernel.org,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc_frmr()
Date: Wed, 14 Jun 2017 10:18:25 -0700 [thread overview]
Message-ID: <eecbb80f-9df3-e717-7af2-4407a3a40d3c@oracle.com> (raw)
In-Reply-To: <20170614103924.GK29394@elgon.mountain>
On 6/14/17 3:39 AM, Dan Carpenter wrote:
> We accidentally return ERR_PTR(0) if ib_alloc_mr() fails. The caller
> is expecting error pointers so it results in a NULL dereference.
>
> Fixes: 1659185fb4d0 ("RDS: IB: Support Fastreg MR (FRMR) memory registration mode")
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
>
Thanks Dan for fix.
Acked-by: Santosh Shilimkar <santosh.shilimkar@oracle.com>
You haven't copied netdev. Can you please resend the patch
with my ack on netdev so that Dave can pick it up.
next prev parent reply other threads:[~2017-06-14 17:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-14 10:39 [PATCH] RDS: IB: NULL dereference on error in rds_ib_alloc_frmr() Dan Carpenter
[not found] ` <20170614103924.GK29394-mgFCXtclrQlZLf2FXnZxJA@public.gmane.org>
2017-06-14 12:54 ` Yuval Shaia
2017-06-14 13:03 ` Dan Carpenter
2017-06-14 13:05 ` Yuval Shaia
2017-06-14 13:05 ` Julia Lawall
2017-06-14 17:18 ` santosh.shilimkar [this message]
2017-06-14 20:59 ` Avinash Repaka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=eecbb80f-9df3-e717-7af2-4407a3a40d3c@oracle.com \
--to=santosh.shilimkar@oracle.com \
--cc=avinash.repaka@oracle.com \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=rds-devel@oss.oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox