public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
To: Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org>
Cc: "Eli Dorfman (Voltaire)"
	<dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	OFED mailing list
	<linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: Default force_link_speed value in opensm configuration
Date: Tue, 13 Oct 2009 15:53:22 -0400	[thread overview]
Message-ID: <f0e08f230910131253o7c667932xacf24a17cb9e0fd8@mail.gmail.com> (raw)
In-Reply-To: <20091013124448.208cf778.weiny2-i2BcT+NCU+M@public.gmane.org>

On Tue, Oct 13, 2009 at 3:44 PM, Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org> wrote:
> On Tue, 13 Oct 2009 09:39:08 -0400
> Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>
>> On Mon, Oct 12, 2009 at 5:35 PM, Ira Weiny <weiny2-i2BcT+NCU+M@public.gmane.org> wrote:
>> > On Mon, 12 Oct 2009 11:47:37 +0200
>> > "Eli Dorfman (Voltaire)" <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >
>> >> Ira Weiny wrote:
>> >> > On Tue, 06 Oct 2009 17:56:01 +0200
>> >> > "Eli Dorfman (Voltaire)" <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> >> >
>> >> >> Hi,
>> >> >>
>> >> >> Is there a reason for setting default force_link_speed to 15 (set enabled as supported)
>> >> >> and not to 0 (don't modify PortInfo:LinkSpeedEnabled )?
>>
>> This is going back some 2 years to 7/15/07 commit ID
>> c7cbf11992b111d2b9c7347e398e67f2b5806edb
>>
>> commit c7cbf11992b111d2b9c7347e398e67f2b5806edb
>> Author: Hal Rosenstock <halr-smomgflXvOZWk0Htik3J/w@public.gmane.org>
>> Date:   Sun Jul 15 06:43:20 2007 -0400
>>
>>     OpenSM: Change force_link_speed to allow for local policy and more flexibili
>>
>>     OpenSM: Change force_link_speed to allow for local policy and more
>>     flexibility
>>
>>     Extend (and change) the use of force_link_speed as follows:
>>     0 - no change
>>     1 - set to SDR
>>     15 - set as supported (default)
>>     (Non zero values are used to set LinkSpeedEnabled component in PortInfo)
>>
>>     Note that force_link_speed 0 which used to force SDR is now
>>     force_link_speed 1
>>
>>     "Ideally", there were be a per port configuration of this.
>
> BTW I have a patch which allows a user to except some nodes from this
> restriction.  I don't know that anyone but us is using this "feature" so I did
> not submit the patch.  If someone else would like some finer granularity I can
> clean up the patch and make it available.

There are others. This would be a worthwhile improvement IMO.

-- Hal

>
>>
>>     [Note this is largely untested.]
>
> BTW, now, this is highly tested, to force SDR, on some of our clusters!
> Thanks!
>
>>
>>     Signed-off-by: Hal Rosenstock <hal.rosenstock-Re5JQEeQqe8@public.gmane.orgm>
>>
>> I think that the default was chosen based on IBA 1.2.1 vol 2 p. 108 stating:
>> "The default value following power on shall be set to LinkSpeedSupported."
>> which should not be an issue with compliant hardware.
>>
>
> [snip]
>
>> >
>> > However, I would like to know if anyone else knows of hardware which needs it
>> > set to "15".  If so, this is going to be an interesting problem...  ;-)
>>
>> I'm not sure about need but I think there is a tradeoff here in
>> changing this. The pro is it will work with non compliant hardware.
>> The con is that it may result in less than the max LSS being used in
>> some scenarios.
>>
>> Should the default be changed for non compliant hardware or should
>> this need to be configured in subnets including such hardware as it
>> has since this was introduced ?
>>
>
> I think that is a good way of thinking about things.
>
> Ira
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

      parent reply	other threads:[~2009-10-13 19:53 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-06 15:56 Default force_link_speed value in opensm configuration Eli Dorfman (Voltaire)
     [not found] ` <4ACB6891.7010202-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-06 21:27   ` Ira Weiny
     [not found]     ` <20091006142728.3d1e5bcc.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-12  9:47       ` Eli Dorfman (Voltaire)
     [not found]         ` <4AD2FB39.6040602-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2009-10-12 21:35           ` Ira Weiny
     [not found]             ` <20091012143553.04554689.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-13 13:39               ` Hal Rosenstock
     [not found]                 ` <f0e08f230910130639v7f2da43bt630b7f42eb0da795-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2009-10-13 19:44                   ` Ira Weiny
     [not found]                     ` <20091013124448.208cf778.weiny2-i2BcT+NCU+M@public.gmane.org>
2009-10-13 19:53                       ` Hal Rosenstock [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f0e08f230910131253o7c667932xacf24a17cb9e0fd8@mail.gmail.com \
    --to=hal.rosenstock-re5jqeeqqe8avxtiumwx3w@public.gmane.org \
    --cc=dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=weiny2-i2BcT+NCU+M@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox