* [PATCH] opensm: bug in trap report for MC create(66) and delete(67) traps
@ 2010-02-02 14:13 Eli Dorfman (Voltaire)
[not found] ` <4B6832F8.9090200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Eli Dorfman (Voltaire) @ 2010-02-02 14:13 UTC (permalink / raw)
To: Sasha Khapyorsky; +Cc: linux-rdma, Vladimir Koushnir
In this case the GID in the data details is the MGID and
not the source gid. So the SM gid should be taken as the source gid.
There was also an error in comparing the subnet prefix and guid due to
host/network order mismatch.
Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
opensm/opensm/osm_inform.c | 19 +++++++++----------
1 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
index 8108213..5f48376 100644
--- a/opensm/opensm/osm_inform.c
+++ b/opensm/opensm/osm_inform.c
@@ -460,18 +460,16 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
}
}
- /* Check if there is a pkey match. o13-17.1.1 */
- /* Check if the issuer of the trap is the SM. If it is, then the gid
+ /* In case of GID IN(64) or GID OUT(65) traps the source gid
comparison should be done on the trap source (saved as the gid in the
data details field).
- If the issuer gid is not the SM - then it is the guid of the trap
- source */
- if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
- p_subn->opt.subnet_prefix)
- && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
- p_subn->sm_port_guid))
- /* The issuer is the SM then this is trap 64-67 - compare the gid
- with the gid saved on the data details */
+ In all other cases the issuer gis is the trap source.
+ This is also the case for MC CREATE(66) and MC DELETE(67) where the
+ data details gid is MGID */
+ if (p_ntc->g_or_v.generic.trap_num == 64 ||
+ p_ntc->g_or_v.generic.trap_num == 65 )
+ /* The issuer of these traps is the SM so source_gid
+ is the gid saved on the data details */
source_gid = p_ntc->data_details.ntc_64_67.gid;
else
source_gid = p_ntc->issuer_gid;
@@ -495,6 +493,7 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
goto Exit;
}
+ /* Check if there is a pkey match. o13-17.1.1 */
if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
/* According to o13-17.1.2 - If this informInfo does not have
--
1.5.5
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <4B6832F8.9090200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2010-02-03 9:49 ` Sasha Khapyorsky
2010-02-04 17:43 ` [PATCH v2] " Eli Dorfman (Voltaire)
0 siblings, 1 reply; 11+ messages in thread
From: Sasha Khapyorsky @ 2010-02-03 9:49 UTC (permalink / raw)
To: Eli Dorfman (Voltaire); +Cc: linux-rdma, Vladimir Koushnir
Hi Eli,
On 16:13 Tue 02 Feb , Eli Dorfman (Voltaire) wrote:
>
> In this case the GID in the data details is the MGID and
> not the source gid. So the SM gid should be taken as the source gid.
There the source port is detected in order P_Key matching check between
source and trap destination port.
So in case of 66,67 trap you will just check P_Key match between trap
destination port and SM port, which is likely useless due to fact of
already working SA communication between both.
What should be really checked in this case is a good question. At least
I cannot find some explicit explanations in the spec.
I would guess that the needed check is that trap destination port has MC
group's P_Key (as present in MCMember Record) value.
Thoughts?
> There was also an error in comparing the subnet prefix and guid due to
> host/network order mismatch.
Agree about this.
>
> Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
> ---
> opensm/opensm/osm_inform.c | 19 +++++++++----------
> 1 files changed, 9 insertions(+), 10 deletions(-)
>
> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
> index 8108213..5f48376 100644
> --- a/opensm/opensm/osm_inform.c
> +++ b/opensm/opensm/osm_inform.c
> @@ -460,18 +460,16 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
> }
> }
>
> - /* Check if there is a pkey match. o13-17.1.1 */
> - /* Check if the issuer of the trap is the SM. If it is, then the gid
> + /* In case of GID IN(64) or GID OUT(65) traps the source gid
> comparison should be done on the trap source (saved as the gid in the
> data details field).
> - If the issuer gid is not the SM - then it is the guid of the trap
> - source */
> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
> - p_subn->opt.subnet_prefix)
> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
> - p_subn->sm_port_guid))
> - /* The issuer is the SM then this is trap 64-67 - compare the gid
> - with the gid saved on the data details */
> + In all other cases the issuer gis is the trap source.
> + This is also the case for MC CREATE(66) and MC DELETE(67) where the
> + data details gid is MGID */
> + if (p_ntc->g_or_v.generic.trap_num == 64 ||
> + p_ntc->g_or_v.generic.trap_num == 65 )
ib_mad_notice_attr_t.g_or_v.generic.trap_num is encoded in network byte
order.
Sasha
> + /* The issuer of these traps is the SM so source_gid
> + is the gid saved on the data details */
> source_gid = p_ntc->data_details.ntc_64_67.gid;
> else
> source_gid = p_ntc->issuer_gid;
> @@ -495,6 +493,7 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
> goto Exit;
> }
>
> + /* Check if there is a pkey match. o13-17.1.1 */
> if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
> OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
> /* According to o13-17.1.2 - If this informInfo does not have
> --
> 1.5.5
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
2010-02-03 9:49 ` Sasha Khapyorsky
@ 2010-02-04 17:43 ` Eli Dorfman (Voltaire)
[not found] ` <4B6B0736.9010001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Eli Dorfman (Voltaire) @ 2010-02-04 17:43 UTC (permalink / raw)
To: Sasha Khapyorsky; +Cc: linux-rdma, Vladimir Koushnir
Subject: [PATCH] Wrong handling of MC create and delete traps
For these traps the GID in the data details is the MGID and
not the source port gid.
So the SM should check that subscriber port has the pkey of the MC group.
There was also an error in comparing the subnet prefix and guid due to
host/network order mismatch.
Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
---
opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
1 files changed, 98 insertions(+), 53 deletions(-)
diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
index 8108213..ae4fe71 100644
--- a/opensm/opensm/osm_inform.c
+++ b/opensm/opensm/osm_inform.c
@@ -341,6 +341,103 @@ Exit:
return status;
}
+static int is_access_permitted( osm_infr_t *p_infr_rec,
+ osm_infr_match_ctxt_t *p_infr_match )
+{
+ cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
+ ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
+ ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
+ uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
+ osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
+ osm_log_t *p_log = p_infr_rec->sa->p_log;
+ char gid_str[INET6_ADDRSTRLEN];
+ osm_mgrp_t *p_mgrp;
+ ib_gid_t source_gid;
+ osm_port_t *p_src_port;
+ osm_port_t *p_dest_port;
+
+ /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
+ comparison should be done on the trap source (saved as the gid in the
+ data details field).
+ For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
+ the MGID. We need to check whether subscriber has the pky of
+ the MC group.
+ In all other cases the issuer gis is the trap source.
+ */
+ if (trap_num >= 64 && trap_num <= 67 )
+ /* The issuer of these traps is the SM so source_gid
+ is the gid saved on the data details */
+ source_gid = p_ntc->data_details.ntc_64_67.gid;
+ else
+ source_gid = p_ntc->issuer_gid;
+
+ p_dest_port =
+ cl_ptr_vector_get(&p_subn->port_lid_tbl,
+ cl_ntoh16(p_infr_rec->report_addr.dest_lid));
+ if (!p_dest_port) {
+ OSM_LOG(p_log, OSM_LOG_INFO,
+ "Cannot find destination port with LID:%u\n",
+ cl_ntoh16(p_infr_rec->report_addr.dest_lid));
+ goto Exit;
+ }
+
+ switch (trap_num) {
+ case 66:
+ case 67:
+ p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
+ if (!p_mgrp) {
+ OSM_LOG(p_log, OSM_LOG_INFO,
+ "Cannot find MGID %s\n",
+ inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
+ goto Exit;
+ }
+
+ if (!osm_physp_has_pkey(p_log,
+ p_mgrp->mcmember_rec.pkey,
+ p_dest_port->p_physp)) {
+ OSM_LOG(p_log, OSM_LOG_INFO,
+ "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
+ inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
+ cl_ntoh64(p_dest_port->guid));
+ goto Exit;
+ }
+ break;
+
+ default:
+ p_src_port =
+ osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
+ if (!p_src_port) {
+ OSM_LOG(p_log, OSM_LOG_INFO,
+ "Cannot find source port with GUID:0x%016" PRIx64 "\n",
+ cl_ntoh64(source_gid.unicast.interface_id));
+ goto Exit;
+ }
+
+
+ /* Check if there is a pkey match. o13-17.1.1 */
+ if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
+ OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
+ /* According to o13-17.1.2 - If this informInfo does not have
+ lid_range_begin of 0xFFFF, then this informInfo request
+ should be removed from database */
+ if (p_ii->lid_range_begin != 0xFFFF) {
+ OSM_LOG(p_log, OSM_LOG_VERBOSE,
+ "Pkey mismatch on lid_range_begin != 0xFFFF. "
+ "Need to remove this informInfo from db\n");
+ /* add the informInfo record to the remove_infr list */
+ cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
+ }
+ goto Exit;
+ }
+ break;
+ }
+
+ return 1;
+Exit:
+ return 0;
+}
+
+
/**********************************************************************
* This routine compares a given Notice and a ListItem of InformInfo type.
* PREREQUISITE:
@@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
{
osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
- cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
cl_status_t status = CL_NOT_FOUND;
osm_log_t *p_log = p_infr_rec->sa->p_log;
- osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
- ib_gid_t source_gid;
- osm_port_t *p_src_port;
- osm_port_t *p_dest_port;
OSM_LOG_ENTER(p_log);
@@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
}
}
- /* Check if there is a pkey match. o13-17.1.1 */
- /* Check if the issuer of the trap is the SM. If it is, then the gid
- comparison should be done on the trap source (saved as the gid in the
- data details field).
- If the issuer gid is not the SM - then it is the guid of the trap
- source */
- if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
- p_subn->opt.subnet_prefix)
- && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
- p_subn->sm_port_guid))
- /* The issuer is the SM then this is trap 64-67 - compare the gid
- with the gid saved on the data details */
- source_gid = p_ntc->data_details.ntc_64_67.gid;
- else
- source_gid = p_ntc->issuer_gid;
-
- p_src_port =
- osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
- if (!p_src_port) {
- OSM_LOG(p_log, OSM_LOG_INFO,
- "Cannot find source port with GUID:0x%016" PRIx64 "\n",
- cl_ntoh64(source_gid.unicast.interface_id));
+ if (!is_access_permitted(p_infr_rec, p_infr_match))
goto Exit;
- }
-
- p_dest_port =
- cl_ptr_vector_get(&p_subn->port_lid_tbl,
- cl_ntoh16(p_infr_rec->report_addr.dest_lid));
- if (!p_dest_port) {
- OSM_LOG(p_log, OSM_LOG_INFO,
- "Cannot find destination port with LID:%u\n",
- cl_ntoh16(p_infr_rec->report_addr.dest_lid));
- goto Exit;
- }
-
- if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
- OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
- /* According to o13-17.1.2 - If this informInfo does not have
- lid_range_begin of 0xFFFF, then this informInfo request
- should be removed from database */
- if (p_ii->lid_range_begin != 0xFFFF) {
- OSM_LOG(p_log, OSM_LOG_VERBOSE,
- "Pkey mismatch on lid_range_begin != 0xFFFF. "
- "Need to remove this informInfo from db\n");
- /* add the informInfo record to the remove_infr list */
- cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
- }
- goto Exit;
- }
/* send the report to the address provided in the inform record */
OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
--
1.5.5
There is still a problem with GID OUT trap that is not sent since source port
was already removed.
Patch will follow.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <4B6B0736.9010001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2010-02-04 20:52 ` Hal Rosenstock
[not found] ` <f0e08f231002041252s4c2f9c66jaa43d25bb3c75cbc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-11-09 19:35 ` Sasha Khapyorsky
1 sibling, 1 reply; 11+ messages in thread
From: Hal Rosenstock @ 2010-02-04 20:52 UTC (permalink / raw)
To: Eli Dorfman (Voltaire); +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
<dorfman.eli@gmail.com> wrote:
>
> Subject: [PATCH] Wrong handling of MC create and delete traps
>
> For these traps the GID in the data details is the MGID and
> not the source port gid.
> So the SM should check that subscriber port has the pkey of the MC group.
> There was also an error in comparing the subnet prefix and guid due to
> host/network order mismatch.
>
> Signed-off-by: Eli Dorfman <elid@voltaire.com>
> ---
> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
> 1 files changed, 98 insertions(+), 53 deletions(-)
>
> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
> index 8108213..ae4fe71 100644
> --- a/opensm/opensm/osm_inform.c
> +++ b/opensm/opensm/osm_inform.c
> @@ -341,6 +341,103 @@ Exit:
> return status;
> }
>
> +static int is_access_permitted( osm_infr_t *p_infr_rec,
> + osm_infr_match_ctxt_t *p_infr_match )
> +{
> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
> + osm_log_t *p_log = p_infr_rec->sa->p_log;
> + char gid_str[INET6_ADDRSTRLEN];
> + osm_mgrp_t *p_mgrp;
> + ib_gid_t source_gid;
> + osm_port_t *p_src_port;
> + osm_port_t *p_dest_port;
> +
> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
> + comparison should be done on the trap source (saved as the gid in the
> + data details field).
> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
> + the MGID. We need to check whether subscriber has the pky of
typo ^^^^
pkey
> + the MC group.
Shouldn't this be the subscriber has a compatible pkey with MC group ?
The MC group has a full member PKey and the members can be full or
limited.
> + In all other cases the issuer gis is the trap source.
typo ^^^
gid
-- Hal
> + */
> + if (trap_num >= 64 && trap_num <= 67 )
> + /* The issuer of these traps is the SM so source_gid
> + is the gid saved on the data details */
> + source_gid = p_ntc->data_details.ntc_64_67.gid;
> + else
> + source_gid = p_ntc->issuer_gid;
> +
> + p_dest_port =
> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
> + if (!p_dest_port) {
> + OSM_LOG(p_log, OSM_LOG_INFO,
> + "Cannot find destination port with LID:%u\n",
> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
> + goto Exit;
> + }
> +
> + switch (trap_num) {
> + case 66:
> + case 67:
> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
> + if (!p_mgrp) {
> + OSM_LOG(p_log, OSM_LOG_INFO,
> + "Cannot find MGID %s\n",
> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
> + goto Exit;
> + }
> +
> + if (!osm_physp_has_pkey(p_log,
> + p_mgrp->mcmember_rec.pkey,
> + p_dest_port->p_physp)) {
> + OSM_LOG(p_log, OSM_LOG_INFO,
> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
> + cl_ntoh64(p_dest_port->guid));
> + goto Exit;
> + }
> + break;
> +
> + default:
> + p_src_port =
> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
> + if (!p_src_port) {
> + OSM_LOG(p_log, OSM_LOG_INFO,
> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
> + cl_ntoh64(source_gid.unicast.interface_id));
> + goto Exit;
> + }
> +
> +
> + /* Check if there is a pkey match. o13-17.1.1 */
> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
> + /* According to o13-17.1.2 - If this informInfo does not have
> + lid_range_begin of 0xFFFF, then this informInfo request
> + should be removed from database */
> + if (p_ii->lid_range_begin != 0xFFFF) {
> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
> + "Need to remove this informInfo from db\n");
> + /* add the informInfo record to the remove_infr list */
> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
> + }
> + goto Exit;
> + }
> + break;
> + }
> +
> + return 1;
> +Exit:
> + return 0;
> +}
> +
> +
> /**********************************************************************
> * This routine compares a given Notice and a ListItem of InformInfo type.
> * PREREQUISITE:
> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
> {
> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
> cl_status_t status = CL_NOT_FOUND;
> osm_log_t *p_log = p_infr_rec->sa->p_log;
> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
> - ib_gid_t source_gid;
> - osm_port_t *p_src_port;
> - osm_port_t *p_dest_port;
>
> OSM_LOG_ENTER(p_log);
>
> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
> }
> }
>
> - /* Check if there is a pkey match. o13-17.1.1 */
> - /* Check if the issuer of the trap is the SM. If it is, then the gid
> - comparison should be done on the trap source (saved as the gid in the
> - data details field).
> - If the issuer gid is not the SM - then it is the guid of the trap
> - source */
> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
> - p_subn->opt.subnet_prefix)
> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
> - p_subn->sm_port_guid))
> - /* The issuer is the SM then this is trap 64-67 - compare the gid
> - with the gid saved on the data details */
> - source_gid = p_ntc->data_details.ntc_64_67.gid;
> - else
> - source_gid = p_ntc->issuer_gid;
> -
> - p_src_port =
> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
> - if (!p_src_port) {
> - OSM_LOG(p_log, OSM_LOG_INFO,
> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
> - cl_ntoh64(source_gid.unicast.interface_id));
> + if (!is_access_permitted(p_infr_rec, p_infr_match))
> goto Exit;
> - }
> -
> - p_dest_port =
> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
> - if (!p_dest_port) {
> - OSM_LOG(p_log, OSM_LOG_INFO,
> - "Cannot find destination port with LID:%u\n",
> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
> - goto Exit;
> - }
> -
> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
> - /* According to o13-17.1.2 - If this informInfo does not have
> - lid_range_begin of 0xFFFF, then this informInfo request
> - should be removed from database */
> - if (p_ii->lid_range_begin != 0xFFFF) {
> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
> - "Need to remove this informInfo from db\n");
> - /* add the informInfo record to the remove_infr list */
> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
> - }
> - goto Exit;
> - }
>
> /* send the report to the address provided in the inform record */
> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
> --
> 1.5.5
>
> There is still a problem with GID OUT trap that is not sent since source port
> was already removed.
> Patch will follow.
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <f0e08f231002041252s4c2f9c66jaa43d25bb3c75cbc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-02-05 14:18 ` Eli Dorfman
[not found] ` <694d48601002050618s2af59695xa36522c04027d8af-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Eli Dorfman @ 2010-02-05 14:18 UTC (permalink / raw)
To: Hal Rosenstock; +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
<hal.rosenstock@gmail.com> wrote:
> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
> <dorfman.eli@gmail.com> wrote:
>>
>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>
>> For these traps the GID in the data details is the MGID and
>> not the source port gid.
>> So the SM should check that subscriber port has the pkey of the MC group.
>> There was also an error in comparing the subnet prefix and guid due to
>> host/network order mismatch.
>>
>> Signed-off-by: Eli Dorfman <elid@voltaire.com>
>> ---
>> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
>> 1 files changed, 98 insertions(+), 53 deletions(-)
>>
>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>> index 8108213..ae4fe71 100644
>> --- a/opensm/opensm/osm_inform.c
>> +++ b/opensm/opensm/osm_inform.c
>> @@ -341,6 +341,103 @@ Exit:
>> return status;
>> }
>>
>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>> + osm_infr_match_ctxt_t *p_infr_match )
>> +{
>> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>> + osm_log_t *p_log = p_infr_rec->sa->p_log;
>> + char gid_str[INET6_ADDRSTRLEN];
>> + osm_mgrp_t *p_mgrp;
>> + ib_gid_t source_gid;
>> + osm_port_t *p_src_port;
>> + osm_port_t *p_dest_port;
>> +
>> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>> + comparison should be done on the trap source (saved as the gid in the
>> + data details field).
>> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>> + the MGID. We need to check whether subscriber has the pky of
>
>
> typo ^^^^
>
> pkey
>
>
>> + the MC group.
>
> Shouldn't this be the subscriber has a compatible pkey with MC group ?
> The MC group has a full member PKey and the members can be full or
> limited.
I accept the correction.
Sasha, can you please change this in the commit (only if there are not
other remarks).
BTW, there is no explicit reference in the IB spec for MC group
create/delete trap (at least I didn't find it).
>
>> + In all other cases the issuer gis is the trap source.
>
> typo ^^^
> gid
>
and this typo of course.
Thanks,
Eli
> -- Hal
>
>> + */
>> + if (trap_num >= 64 && trap_num <= 67 )
>> + /* The issuer of these traps is the SM so source_gid
>> + is the gid saved on the data details */
>> + source_gid = p_ntc->data_details.ntc_64_67.gid;
>> + else
>> + source_gid = p_ntc->issuer_gid;
>> +
>> + p_dest_port =
>> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>> + if (!p_dest_port) {
>> + OSM_LOG(p_log, OSM_LOG_INFO,
>> + "Cannot find destination port with LID:%u\n",
>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>> + goto Exit;
>> + }
>> +
>> + switch (trap_num) {
>> + case 66:
>> + case 67:
>> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>> + if (!p_mgrp) {
>> + OSM_LOG(p_log, OSM_LOG_INFO,
>> + "Cannot find MGID %s\n",
>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>> + goto Exit;
>> + }
>> +
>> + if (!osm_physp_has_pkey(p_log,
>> + p_mgrp->mcmember_rec.pkey,
>> + p_dest_port->p_physp)) {
>> + OSM_LOG(p_log, OSM_LOG_INFO,
>> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>> + cl_ntoh64(p_dest_port->guid));
>> + goto Exit;
>> + }
>> + break;
>> +
>> + default:
>> + p_src_port =
>> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>> + if (!p_src_port) {
>> + OSM_LOG(p_log, OSM_LOG_INFO,
>> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>> + cl_ntoh64(source_gid.unicast.interface_id));
>> + goto Exit;
>> + }
>> +
>> +
>> + /* Check if there is a pkey match. o13-17.1.1 */
>> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>> + /* According to o13-17.1.2 - If this informInfo does not have
>> + lid_range_begin of 0xFFFF, then this informInfo request
>> + should be removed from database */
>> + if (p_ii->lid_range_begin != 0xFFFF) {
>> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
>> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
>> + "Need to remove this informInfo from db\n");
>> + /* add the informInfo record to the remove_infr list */
>> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>> + }
>> + goto Exit;
>> + }
>> + break;
>> + }
>> +
>> + return 1;
>> +Exit:
>> + return 0;
>> +}
>> +
>> +
>> /**********************************************************************
>> * This routine compares a given Notice and a ListItem of InformInfo type.
>> * PREREQUISITE:
>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>> {
>> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>> cl_status_t status = CL_NOT_FOUND;
>> osm_log_t *p_log = p_infr_rec->sa->p_log;
>> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>> - ib_gid_t source_gid;
>> - osm_port_t *p_src_port;
>> - osm_port_t *p_dest_port;
>>
>> OSM_LOG_ENTER(p_log);
>>
>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>> }
>> }
>>
>> - /* Check if there is a pkey match. o13-17.1.1 */
>> - /* Check if the issuer of the trap is the SM. If it is, then the gid
>> - comparison should be done on the trap source (saved as the gid in the
>> - data details field).
>> - If the issuer gid is not the SM - then it is the guid of the trap
>> - source */
>> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>> - p_subn->opt.subnet_prefix)
>> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>> - p_subn->sm_port_guid))
>> - /* The issuer is the SM then this is trap 64-67 - compare the gid
>> - with the gid saved on the data details */
>> - source_gid = p_ntc->data_details.ntc_64_67.gid;
>> - else
>> - source_gid = p_ntc->issuer_gid;
>> -
>> - p_src_port =
>> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>> - if (!p_src_port) {
>> - OSM_LOG(p_log, OSM_LOG_INFO,
>> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>> - cl_ntoh64(source_gid.unicast.interface_id));
>> + if (!is_access_permitted(p_infr_rec, p_infr_match))
>> goto Exit;
>> - }
>> -
>> - p_dest_port =
>> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>> - if (!p_dest_port) {
>> - OSM_LOG(p_log, OSM_LOG_INFO,
>> - "Cannot find destination port with LID:%u\n",
>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>> - goto Exit;
>> - }
>> -
>> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>> - /* According to o13-17.1.2 - If this informInfo does not have
>> - lid_range_begin of 0xFFFF, then this informInfo request
>> - should be removed from database */
>> - if (p_ii->lid_range_begin != 0xFFFF) {
>> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
>> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
>> - "Need to remove this informInfo from db\n");
>> - /* add the informInfo record to the remove_infr list */
>> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>> - }
>> - goto Exit;
>> - }
>>
>> /* send the report to the address provided in the inform record */
>> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>> --
>> 1.5.5
>>
>> There is still a problem with GID OUT trap that is not sent since source port
>> was already removed.
>> Patch will follow.
>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <694d48601002050618s2af59695xa36522c04027d8af-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-02-05 16:20 ` Hal Rosenstock
[not found] ` <f0e08f231002050820j1df2b425ia44203957257a6fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Hal Rosenstock @ 2010-02-05 16:20 UTC (permalink / raw)
To: Eli Dorfman; +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
On Fri, Feb 5, 2010 at 9:18 AM, Eli Dorfman <dorfman.eli@gmail.com> wrote:
> On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
> <hal.rosenstock@gmail.com> wrote:
>> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
>> <dorfman.eli@gmail.com> wrote:
>>>
>>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>>
>>> For these traps the GID in the data details is the MGID and
>>> not the source port gid.
>>> So the SM should check that subscriber port has the pkey of the MC group.
>>> There was also an error in comparing the subnet prefix and guid due to
>>> host/network order mismatch.
>>>
>>> Signed-off-by: Eli Dorfman <elid@voltaire.com>
>>> ---
>>> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
>>> 1 files changed, 98 insertions(+), 53 deletions(-)
>>>
>>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>>> index 8108213..ae4fe71 100644
>>> --- a/opensm/opensm/osm_inform.c
>>> +++ b/opensm/opensm/osm_inform.c
>>> @@ -341,6 +341,103 @@ Exit:
>>> return status;
>>> }
>>>
>>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>>> + osm_infr_match_ctxt_t *p_infr_match )
>>> +{
>>> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>>> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>> + osm_log_t *p_log = p_infr_rec->sa->p_log;
>>> + char gid_str[INET6_ADDRSTRLEN];
>>> + osm_mgrp_t *p_mgrp;
>>> + ib_gid_t source_gid;
>>> + osm_port_t *p_src_port;
>>> + osm_port_t *p_dest_port;
>>> +
>>> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>>> + comparison should be done on the trap source (saved as the gid in the
>>> + data details field).
>>> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>>> + the MGID. We need to check whether subscriber has the pky of
>>
>>
>> typo ^^^^
>>
>> pkey
>>
>>
>>> + the MC group.
>>
>> Shouldn't this be the subscriber has a compatible pkey with MC group ?
>> The MC group has a full member PKey and the members can be full or
>> limited.
>
> I accept the correction.
Doesn't this require a code change for handling trap cases 66-67 ?
> Sasha, can you please change this in the commit (only if there are not
> other remarks).
Is that what you are asking Sasha to do (beyond the typos) ?
>
> BTW, there is no explicit reference in the IB spec for MC group
> create/delete trap (at least I didn't find it).
Not sure what you mean by this. What didn't you find ?
-- Hal
>
>>
>>> + In all other cases the issuer gis is the trap source.
>>
>> typo ^^^
>> gid
>>
>
> and this typo of course.
>
> Thanks,
> Eli
>> -- Hal
>>
>>> + */
>>> + if (trap_num >= 64 && trap_num <= 67 )
>>> + /* The issuer of these traps is the SM so source_gid
>>> + is the gid saved on the data details */
>>> + source_gid = p_ntc->data_details.ntc_64_67.gid;
>>> + else
>>> + source_gid = p_ntc->issuer_gid;
>>> +
>>> + p_dest_port =
>>> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>> + if (!p_dest_port) {
>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>> + "Cannot find destination port with LID:%u\n",
>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>> + goto Exit;
>>> + }
>>> +
>>> + switch (trap_num) {
>>> + case 66:
>>> + case 67:
>>> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>>> + if (!p_mgrp) {
>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>> + "Cannot find MGID %s\n",
>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>>> + goto Exit;
>>> + }
>>> +
>>> + if (!osm_physp_has_pkey(p_log,
>>> + p_mgrp->mcmember_rec.pkey,
>>> + p_dest_port->p_physp)) {
>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>>> + cl_ntoh64(p_dest_port->guid));
>>> + goto Exit;
>>> + }
>>> + break;
>>> +
>>> + default:
>>> + p_src_port =
>>> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>> + if (!p_src_port) {
>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>> + cl_ntoh64(source_gid.unicast.interface_id));
>>> + goto Exit;
>>> + }
>>> +
>>> +
>>> + /* Check if there is a pkey match. o13-17.1.1 */
>>> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>> + /* According to o13-17.1.2 - If this informInfo does not have
>>> + lid_range_begin of 0xFFFF, then this informInfo request
>>> + should be removed from database */
>>> + if (p_ii->lid_range_begin != 0xFFFF) {
>>> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>> + "Need to remove this informInfo from db\n");
>>> + /* add the informInfo record to the remove_infr list */
>>> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>> + }
>>> + goto Exit;
>>> + }
>>> + break;
>>> + }
>>> +
>>> + return 1;
>>> +Exit:
>>> + return 0;
>>> +}
>>> +
>>> +
>>> /**********************************************************************
>>> * This routine compares a given Notice and a ListItem of InformInfo type.
>>> * PREREQUISITE:
>>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>> {
>>> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>>> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>>> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>> cl_status_t status = CL_NOT_FOUND;
>>> osm_log_t *p_log = p_infr_rec->sa->p_log;
>>> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>> - ib_gid_t source_gid;
>>> - osm_port_t *p_src_port;
>>> - osm_port_t *p_dest_port;
>>>
>>> OSM_LOG_ENTER(p_log);
>>>
>>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>> }
>>> }
>>>
>>> - /* Check if there is a pkey match. o13-17.1.1 */
>>> - /* Check if the issuer of the trap is the SM. If it is, then the gid
>>> - comparison should be done on the trap source (saved as the gid in the
>>> - data details field).
>>> - If the issuer gid is not the SM - then it is the guid of the trap
>>> - source */
>>> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>>> - p_subn->opt.subnet_prefix)
>>> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>>> - p_subn->sm_port_guid))
>>> - /* The issuer is the SM then this is trap 64-67 - compare the gid
>>> - with the gid saved on the data details */
>>> - source_gid = p_ntc->data_details.ntc_64_67.gid;
>>> - else
>>> - source_gid = p_ntc->issuer_gid;
>>> -
>>> - p_src_port =
>>> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>> - if (!p_src_port) {
>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>> - cl_ntoh64(source_gid.unicast.interface_id));
>>> + if (!is_access_permitted(p_infr_rec, p_infr_match))
>>> goto Exit;
>>> - }
>>> -
>>> - p_dest_port =
>>> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>> - if (!p_dest_port) {
>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>> - "Cannot find destination port with LID:%u\n",
>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>> - goto Exit;
>>> - }
>>> -
>>> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>> - /* According to o13-17.1.2 - If this informInfo does not have
>>> - lid_range_begin of 0xFFFF, then this informInfo request
>>> - should be removed from database */
>>> - if (p_ii->lid_range_begin != 0xFFFF) {
>>> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>> - "Need to remove this informInfo from db\n");
>>> - /* add the informInfo record to the remove_infr list */
>>> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>> - }
>>> - goto Exit;
>>> - }
>>>
>>> /* send the report to the address provided in the inform record */
>>> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>>> --
>>> 1.5.5
>>>
>>> There is still a problem with GID OUT trap that is not sent since source port
>>> was already removed.
>>> Patch will follow.
>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>
>>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <f0e08f231002050820j1df2b425ia44203957257a6fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-02-07 9:47 ` Eli Dorfman (Voltaire)
[not found] ` <4B6E8C46.5020807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Eli Dorfman (Voltaire) @ 2010-02-07 9:47 UTC (permalink / raw)
To: Hal Rosenstock; +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
Hal Rosenstock wrote:
> On Fri, Feb 5, 2010 at 9:18 AM, Eli Dorfman <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
>> <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
>>> <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>>>
>>>> For these traps the GID in the data details is the MGID and
>>>> not the source port gid.
>>>> So the SM should check that subscriber port has the pkey of the MC group.
>>>> There was also an error in comparing the subnet prefix and guid due to
>>>> host/network order mismatch.
>>>>
>>>> Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
>>>> ---
>>>> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
>>>> 1 files changed, 98 insertions(+), 53 deletions(-)
>>>>
>>>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>>>> index 8108213..ae4fe71 100644
>>>> --- a/opensm/opensm/osm_inform.c
>>>> +++ b/opensm/opensm/osm_inform.c
>>>> @@ -341,6 +341,103 @@ Exit:
>>>> return status;
>>>> }
>>>>
>>>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>>>> + osm_infr_match_ctxt_t *p_infr_match )
>>>> +{
>>>> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>>>> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>> + osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>> + char gid_str[INET6_ADDRSTRLEN];
>>>> + osm_mgrp_t *p_mgrp;
>>>> + ib_gid_t source_gid;
>>>> + osm_port_t *p_src_port;
>>>> + osm_port_t *p_dest_port;
>>>> +
>>>> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>>>> + comparison should be done on the trap source (saved as the gid in the
>>>> + data details field).
>>>> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>>>> + the MGID. We need to check whether subscriber has the pky of
>>>
>>> typo ^^^^
>>>
>>> pkey
>>>
>>>
>>>> + the MC group.
>>> Shouldn't this be the subscriber has a compatible pkey with MC group ?
>>> The MC group has a full member PKey and the members can be full or
>>> limited.
>> I accept the correction.
>
> Doesn't this require a code change for handling trap cases 66-67 ?
I think that you referred to the comment since the code is handling this properly (in my opinion).
>
>> Sasha, can you please change this in the commit (only if there are not
>> other remarks).
>
> Is that what you are asking Sasha to do (beyond the typos) ?
I asked Sasha to fix only the typo in commit.
>
>> BTW, there is no explicit reference in the IB spec for MC group
>> create/delete trap (at least I didn't find it).
>
> Not sure what you mean by this. What didn't you find ?
in the spec see o13-17.1.2
Thanks,
Eli
>
> -- Hal
>
>>>> + In all other cases the issuer gis is the trap source.
>>> typo ^^^
>>> gid
>>>
>> and this typo of course.
>>
>> Thanks,
>> Eli
>>> -- Hal
>>>
>>>> + */
>>>> + if (trap_num >= 64 && trap_num <= 67 )
>>>> + /* The issuer of these traps is the SM so source_gid
>>>> + is the gid saved on the data details */
>>>> + source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>> + else
>>>> + source_gid = p_ntc->issuer_gid;
>>>> +
>>>> + p_dest_port =
>>>> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>> + if (!p_dest_port) {
>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>> + "Cannot find destination port with LID:%u\n",
>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>> + goto Exit;
>>>> + }
>>>> +
>>>> + switch (trap_num) {
>>>> + case 66:
>>>> + case 67:
>>>> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>>>> + if (!p_mgrp) {
>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>> + "Cannot find MGID %s\n",
>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>>>> + goto Exit;
>>>> + }
>>>> +
>>>> + if (!osm_physp_has_pkey(p_log,
>>>> + p_mgrp->mcmember_rec.pkey,
>>>> + p_dest_port->p_physp)) {
>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>>>> + cl_ntoh64(p_dest_port->guid));
>>>> + goto Exit;
>>>> + }
>>>> + break;
>>>> +
>>>> + default:
>>>> + p_src_port =
>>>> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>> + if (!p_src_port) {
>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>> + cl_ntoh64(source_gid.unicast.interface_id));
>>>> + goto Exit;
>>>> + }
>>>> +
>>>> +
>>>> + /* Check if there is a pkey match. o13-17.1.1 */
>>>> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>> + /* According to o13-17.1.2 - If this informInfo does not have
>>>> + lid_range_begin of 0xFFFF, then this informInfo request
>>>> + should be removed from database */
>>>> + if (p_ii->lid_range_begin != 0xFFFF) {
>>>> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>> + "Need to remove this informInfo from db\n");
>>>> + /* add the informInfo record to the remove_infr list */
>>>> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>> + }
>>>> + goto Exit;
>>>> + }
>>>> + break;
>>>> + }
>>>> +
>>>> + return 1;
>>>> +Exit:
>>>> + return 0;
>>>> +}
>>>> +
>>>> +
>>>> /**********************************************************************
>>>> * This routine compares a given Notice and a ListItem of InformInfo type.
>>>> * PREREQUISITE:
>>>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>> {
>>>> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>>>> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>>>> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>> cl_status_t status = CL_NOT_FOUND;
>>>> osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>> - ib_gid_t source_gid;
>>>> - osm_port_t *p_src_port;
>>>> - osm_port_t *p_dest_port;
>>>>
>>>> OSM_LOG_ENTER(p_log);
>>>>
>>>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>> }
>>>> }
>>>>
>>>> - /* Check if there is a pkey match. o13-17.1.1 */
>>>> - /* Check if the issuer of the trap is the SM. If it is, then the gid
>>>> - comparison should be done on the trap source (saved as the gid in the
>>>> - data details field).
>>>> - If the issuer gid is not the SM - then it is the guid of the trap
>>>> - source */
>>>> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>>>> - p_subn->opt.subnet_prefix)
>>>> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>>>> - p_subn->sm_port_guid))
>>>> - /* The issuer is the SM then this is trap 64-67 - compare the gid
>>>> - with the gid saved on the data details */
>>>> - source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>> - else
>>>> - source_gid = p_ntc->issuer_gid;
>>>> -
>>>> - p_src_port =
>>>> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>> - if (!p_src_port) {
>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>> - cl_ntoh64(source_gid.unicast.interface_id));
>>>> + if (!is_access_permitted(p_infr_rec, p_infr_match))
>>>> goto Exit;
>>>> - }
>>>> -
>>>> - p_dest_port =
>>>> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>> - if (!p_dest_port) {
>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>> - "Cannot find destination port with LID:%u\n",
>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>> - goto Exit;
>>>> - }
>>>> -
>>>> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>> - /* According to o13-17.1.2 - If this informInfo does not have
>>>> - lid_range_begin of 0xFFFF, then this informInfo request
>>>> - should be removed from database */
>>>> - if (p_ii->lid_range_begin != 0xFFFF) {
>>>> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>> - "Need to remove this informInfo from db\n");
>>>> - /* add the informInfo record to the remove_infr list */
>>>> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>> - }
>>>> - goto Exit;
>>>> - }
>>>>
>>>> /* send the report to the address provided in the inform record */
>>>> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>>>> --
>>>> 1.5.5
>>>>
>>>> There is still a problem with GID OUT trap that is not sent since source port
>>>> was already removed.
>>>> Patch will follow.
>>>>
>>>> --
>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <4B6E8C46.5020807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2010-02-08 13:26 ` Hal Rosenstock
[not found] ` <f0e08f231002080526k562b2082oa7376c50794c6f75-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Hal Rosenstock @ 2010-02-08 13:26 UTC (permalink / raw)
To: Eli Dorfman (Voltaire); +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
On Sun, Feb 7, 2010 at 4:47 AM, Eli Dorfman (Voltaire)
<dorfman.eli@gmail.com> wrote:
> Hal Rosenstock wrote:
>> On Fri, Feb 5, 2010 at 9:18 AM, Eli Dorfman <dorfman.eli@gmail.com> wrote:
>>> On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
>>> <hal.rosenstock@gmail.com> wrote:
>>>> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
>>>> <dorfman.eli@gmail.com> wrote:
>>>>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>>>>
>>>>> For these traps the GID in the data details is the MGID and
>>>>> not the source port gid.
>>>>> So the SM should check that subscriber port has the pkey of the MC group.
>>>>> There was also an error in comparing the subnet prefix and guid due to
>>>>> host/network order mismatch.
>>>>>
>>>>> Signed-off-by: Eli Dorfman <elid@voltaire.com>
>>>>> ---
>>>>> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
>>>>> 1 files changed, 98 insertions(+), 53 deletions(-)
>>>>>
>>>>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>>>>> index 8108213..ae4fe71 100644
>>>>> --- a/opensm/opensm/osm_inform.c
>>>>> +++ b/opensm/opensm/osm_inform.c
>>>>> @@ -341,6 +341,103 @@ Exit:
>>>>> return status;
>>>>> }
>>>>>
>>>>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>>>>> + osm_infr_match_ctxt_t *p_infr_match )
>>>>> +{
>>>>> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>>>>> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>> + osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>> + char gid_str[INET6_ADDRSTRLEN];
>>>>> + osm_mgrp_t *p_mgrp;
>>>>> + ib_gid_t source_gid;
>>>>> + osm_port_t *p_src_port;
>>>>> + osm_port_t *p_dest_port;
>>>>> +
>>>>> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>>>>> + comparison should be done on the trap source (saved as the gid in the
>>>>> + data details field).
>>>>> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>>>>> + the MGID. We need to check whether subscriber has the pky of
>>>>
>>>> typo ^^^^
>>>>
>>>> pkey
>>>>
>>>>
>>>>> + the MC group.
>>>> Shouldn't this be the subscriber has a compatible pkey with MC group ?
>>>> The MC group has a full member PKey and the members can be full or
>>>> limited.
>>> I accept the correction.
>>
>> Doesn't this require a code change for handling trap cases 66-67 ?
>
> I think that you referred to the comment since the code is handling this properly (in my opinion).
I was referring to both the comment and the code since a port with a
compatible limited pkey should be able to receive the reports for MC
groups.
>
>>
>>> Sasha, can you please change this in the commit (only if there are not
>>> other remarks).
>>
>> Is that what you are asking Sasha to do (beyond the typos) ?
>
> I asked Sasha to fix only the typo in commit.
>
>>
>>> BTW, there is no explicit reference in the IB spec for MC group
>>> create/delete trap (at least I didn't find it).
>>
>> Not sure what you mean by this. What didn't you find ?
>
> in the spec see o13-17.1.2
Yes, there appear to be some holes in the spec in terms of this and
maybe more in this area (event forwarding) but the intent seems clear.
-- Hal
> Thanks,
> Eli
>>
>> -- Hal
>>
>>>>> + In all other cases the issuer gis is the trap source.
>>>> typo ^^^
>>>> gid
>>>>
>>> and this typo of course.
>>>
>>> Thanks,
>>> Eli
>>>> -- Hal
>>>>
>>>>> + */
>>>>> + if (trap_num >= 64 && trap_num <= 67 )
>>>>> + /* The issuer of these traps is the SM so source_gid
>>>>> + is the gid saved on the data details */
>>>>> + source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>> + else
>>>>> + source_gid = p_ntc->issuer_gid;
>>>>> +
>>>>> + p_dest_port =
>>>>> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>> + if (!p_dest_port) {
>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> + "Cannot find destination port with LID:%u\n",
>>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>> + goto Exit;
>>>>> + }
>>>>> +
>>>>> + switch (trap_num) {
>>>>> + case 66:
>>>>> + case 67:
>>>>> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>>>>> + if (!p_mgrp) {
>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> + "Cannot find MGID %s\n",
>>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>>>>> + goto Exit;
>>>>> + }
>>>>> +
>>>>> + if (!osm_physp_has_pkey(p_log,
>>>>> + p_mgrp->mcmember_rec.pkey,
>>>>> + p_dest_port->p_physp)) {
>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>>>>> + cl_ntoh64(p_dest_port->guid));
>>>>> + goto Exit;
>>>>> + }
>>>>> + break;
>>>>> +
>>>>> + default:
>>>>> + p_src_port =
>>>>> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>> + if (!p_src_port) {
>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>> + cl_ntoh64(source_gid.unicast.interface_id));
>>>>> + goto Exit;
>>>>> + }
>>>>> +
>>>>> +
>>>>> + /* Check if there is a pkey match. o13-17.1.1 */
>>>>> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>> + /* According to o13-17.1.2 - If this informInfo does not have
>>>>> + lid_range_begin of 0xFFFF, then this informInfo request
>>>>> + should be removed from database */
>>>>> + if (p_ii->lid_range_begin != 0xFFFF) {
>>>>> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>> + "Need to remove this informInfo from db\n");
>>>>> + /* add the informInfo record to the remove_infr list */
>>>>> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>> + }
>>>>> + goto Exit;
>>>>> + }
>>>>> + break;
>>>>> + }
>>>>> +
>>>>> + return 1;
>>>>> +Exit:
>>>>> + return 0;
>>>>> +}
>>>>> +
>>>>> +
>>>>> /**********************************************************************
>>>>> * This routine compares a given Notice and a ListItem of InformInfo type.
>>>>> * PREREQUISITE:
>>>>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>> {
>>>>> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>>>>> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>>>>> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>> cl_status_t status = CL_NOT_FOUND;
>>>>> osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>> - ib_gid_t source_gid;
>>>>> - osm_port_t *p_src_port;
>>>>> - osm_port_t *p_dest_port;
>>>>>
>>>>> OSM_LOG_ENTER(p_log);
>>>>>
>>>>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>> }
>>>>> }
>>>>>
>>>>> - /* Check if there is a pkey match. o13-17.1.1 */
>>>>> - /* Check if the issuer of the trap is the SM. If it is, then the gid
>>>>> - comparison should be done on the trap source (saved as the gid in the
>>>>> - data details field).
>>>>> - If the issuer gid is not the SM - then it is the guid of the trap
>>>>> - source */
>>>>> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>>>>> - p_subn->opt.subnet_prefix)
>>>>> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>>>>> - p_subn->sm_port_guid))
>>>>> - /* The issuer is the SM then this is trap 64-67 - compare the gid
>>>>> - with the gid saved on the data details */
>>>>> - source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>> - else
>>>>> - source_gid = p_ntc->issuer_gid;
>>>>> -
>>>>> - p_src_port =
>>>>> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>> - if (!p_src_port) {
>>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>> - cl_ntoh64(source_gid.unicast.interface_id));
>>>>> + if (!is_access_permitted(p_infr_rec, p_infr_match))
>>>>> goto Exit;
>>>>> - }
>>>>> -
>>>>> - p_dest_port =
>>>>> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>> - if (!p_dest_port) {
>>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>>> - "Cannot find destination port with LID:%u\n",
>>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>> - goto Exit;
>>>>> - }
>>>>> -
>>>>> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>> - /* According to o13-17.1.2 - If this informInfo does not have
>>>>> - lid_range_begin of 0xFFFF, then this informInfo request
>>>>> - should be removed from database */
>>>>> - if (p_ii->lid_range_begin != 0xFFFF) {
>>>>> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>> - "Need to remove this informInfo from db\n");
>>>>> - /* add the informInfo record to the remove_infr list */
>>>>> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>> - }
>>>>> - goto Exit;
>>>>> - }
>>>>>
>>>>> /* send the report to the address provided in the inform record */
>>>>> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>>>>> --
>>>>> 1.5.5
>>>>>
>>>>> There is still a problem with GID OUT trap that is not sent since source port
>>>>> was already removed.
>>>>> Patch will follow.
>>>>>
>>>>> --
>>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>>>> the body of a message to majordomo@vger.kernel.org
>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>
>
>
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <f0e08f231002080526k562b2082oa7376c50794c6f75-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
@ 2010-02-08 16:05 ` Eli Dorfman (Voltaire)
[not found] ` <4B70363C.7080101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
0 siblings, 1 reply; 11+ messages in thread
From: Eli Dorfman (Voltaire) @ 2010-02-08 16:05 UTC (permalink / raw)
To: Hal Rosenstock; +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
Hal Rosenstock wrote:
> On Sun, Feb 7, 2010 at 4:47 AM, Eli Dorfman (Voltaire)
> <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>> Hal Rosenstock wrote:
>>> On Fri, Feb 5, 2010 at 9:18 AM, Eli Dorfman <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>> On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
>>>> <hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>>> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
>>>>> <dorfman.eli-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
>>>>>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>>>>>
>>>>>> For these traps the GID in the data details is the MGID and
>>>>>> not the source port gid.
>>>>>> So the SM should check that subscriber port has the pkey of the MC group.
>>>>>> There was also an error in comparing the subnet prefix and guid due to
>>>>>> host/network order mismatch.
>>>>>>
>>>>>> Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
>>>>>> ---
>>>>>> opensm/opensm/osm_inform.c | 151 ++++++++++++++++++++++++++++---------------
>>>>>> 1 files changed, 98 insertions(+), 53 deletions(-)
>>>>>>
>>>>>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>>>>>> index 8108213..ae4fe71 100644
>>>>>> --- a/opensm/opensm/osm_inform.c
>>>>>> +++ b/opensm/opensm/osm_inform.c
>>>>>> @@ -341,6 +341,103 @@ Exit:
>>>>>> return status;
>>>>>> }
>>>>>>
>>>>>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>>>>>> + osm_infr_match_ctxt_t *p_infr_match )
>>>>>> +{
>>>>>> + cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>>> + ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>>> + ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>>> + uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>>>>>> + osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>>> + osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>>> + char gid_str[INET6_ADDRSTRLEN];
>>>>>> + osm_mgrp_t *p_mgrp;
>>>>>> + ib_gid_t source_gid;
>>>>>> + osm_port_t *p_src_port;
>>>>>> + osm_port_t *p_dest_port;
>>>>>> +
>>>>>> + /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>>>>>> + comparison should be done on the trap source (saved as the gid in the
>>>>>> + data details field).
>>>>>> + For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>>>>>> + the MGID. We need to check whether subscriber has the pky of
>>>>> typo ^^^^
>>>>>
>>>>> pkey
>>>>>
>>>>>
>>>>>> + the MC group.
>>>>> Shouldn't this be the subscriber has a compatible pkey with MC group ?
>>>>> The MC group has a full member PKey and the members can be full or
>>>>> limited.
>>>> I accept the correction.
>>> Doesn't this require a code change for handling trap cases 66-67 ?
>> I think that you referred to the comment since the code is handling this properly (in my opinion).
>
> I was referring to both the comment and the code since a port with a
> compatible limited pkey should be able to receive the reports for MC
> groups.
I agree and I think that the code is handling this case properly.
osm_physp_has_pkey() takes the 15 lower MGID pkey bits and checks whether it is the physp pkey table.
Eli
>
>>>> Sasha, can you please change this in the commit (only if there are not
>>>> other remarks).
>>> Is that what you are asking Sasha to do (beyond the typos) ?
>> I asked Sasha to fix only the typo in commit.
>>
>>>> BTW, there is no explicit reference in the IB spec for MC group
>>>> create/delete trap (at least I didn't find it).
>>> Not sure what you mean by this. What didn't you find ?
>> in the spec see o13-17.1.2
>
> Yes, there appear to be some holes in the spec in terms of this and
> maybe more in this area (event forwarding) but the intent seems clear.
>
> -- Hal
>
>> Thanks,
>> Eli
>>> -- Hal
>>>
>>>>>> + In all other cases the issuer gis is the trap source.
>>>>> typo ^^^
>>>>> gid
>>>>>
>>>> and this typo of course.
>>>>
>>>> Thanks,
>>>> Eli
>>>>> -- Hal
>>>>>
>>>>>> + */
>>>>>> + if (trap_num >= 64 && trap_num <= 67 )
>>>>>> + /* The issuer of these traps is the SM so source_gid
>>>>>> + is the gid saved on the data details */
>>>>>> + source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>>> + else
>>>>>> + source_gid = p_ntc->issuer_gid;
>>>>>> +
>>>>>> + p_dest_port =
>>>>>> + cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>> + if (!p_dest_port) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> + "Cannot find destination port with LID:%u\n",
>>>>>> + cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>> + goto Exit;
>>>>>> + }
>>>>>> +
>>>>>> + switch (trap_num) {
>>>>>> + case 66:
>>>>>> + case 67:
>>>>>> + p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>>>>>> + if (!p_mgrp) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> + "Cannot find MGID %s\n",
>>>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>>>>>> + goto Exit;
>>>>>> + }
>>>>>> +
>>>>>> + if (!osm_physp_has_pkey(p_log,
>>>>>> + p_mgrp->mcmember_rec.pkey,
>>>>>> + p_dest_port->p_physp)) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> + "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>>>>>> + inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>>>>>> + cl_ntoh64(p_dest_port->guid));
>>>>>> + goto Exit;
>>>>>> + }
>>>>>> + break;
>>>>>> +
>>>>>> + default:
>>>>>> + p_src_port =
>>>>>> + osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>>> + if (!p_src_port) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> + "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>>> + cl_ntoh64(source_gid.unicast.interface_id));
>>>>>> + goto Exit;
>>>>>> + }
>>>>>> +
>>>>>> +
>>>>>> + /* Check if there is a pkey match. o13-17.1.1 */
>>>>>> + if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>>> + /* According to o13-17.1.2 - If this informInfo does not have
>>>>>> + lid_range_begin of 0xFFFF, then this informInfo request
>>>>>> + should be removed from database */
>>>>>> + if (p_ii->lid_range_begin != 0xFFFF) {
>>>>>> + OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>>> + "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>>> + "Need to remove this informInfo from db\n");
>>>>>> + /* add the informInfo record to the remove_infr list */
>>>>>> + cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>>> + }
>>>>>> + goto Exit;
>>>>>> + }
>>>>>> + break;
>>>>>> + }
>>>>>> +
>>>>>> + return 1;
>>>>>> +Exit:
>>>>>> + return 0;
>>>>>> +}
>>>>>> +
>>>>>> +
>>>>>> /**********************************************************************
>>>>>> * This routine compares a given Notice and a ListItem of InformInfo type.
>>>>>> * PREREQUISITE:
>>>>>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>>> {
>>>>>> osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>>>>>> ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>>> - cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>>> osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>>>>>> ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>>> cl_status_t status = CL_NOT_FOUND;
>>>>>> osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>>> - osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>>> - ib_gid_t source_gid;
>>>>>> - osm_port_t *p_src_port;
>>>>>> - osm_port_t *p_dest_port;
>>>>>>
>>>>>> OSM_LOG_ENTER(p_log);
>>>>>>
>>>>>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>>> }
>>>>>> }
>>>>>>
>>>>>> - /* Check if there is a pkey match. o13-17.1.1 */
>>>>>> - /* Check if the issuer of the trap is the SM. If it is, then the gid
>>>>>> - comparison should be done on the trap source (saved as the gid in the
>>>>>> - data details field).
>>>>>> - If the issuer gid is not the SM - then it is the guid of the trap
>>>>>> - source */
>>>>>> - if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>>>>>> - p_subn->opt.subnet_prefix)
>>>>>> - && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>>>>>> - p_subn->sm_port_guid))
>>>>>> - /* The issuer is the SM then this is trap 64-67 - compare the gid
>>>>>> - with the gid saved on the data details */
>>>>>> - source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>>> - else
>>>>>> - source_gid = p_ntc->issuer_gid;
>>>>>> -
>>>>>> - p_src_port =
>>>>>> - osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>>> - if (!p_src_port) {
>>>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> - "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>>> - cl_ntoh64(source_gid.unicast.interface_id));
>>>>>> + if (!is_access_permitted(p_infr_rec, p_infr_match))
>>>>>> goto Exit;
>>>>>> - }
>>>>>> -
>>>>>> - p_dest_port =
>>>>>> - cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>> - if (!p_dest_port) {
>>>>>> - OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>> - "Cannot find destination port with LID:%u\n",
>>>>>> - cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>> - goto Exit;
>>>>>> - }
>>>>>> -
>>>>>> - if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>>> - OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>>> - /* According to o13-17.1.2 - If this informInfo does not have
>>>>>> - lid_range_begin of 0xFFFF, then this informInfo request
>>>>>> - should be removed from database */
>>>>>> - if (p_ii->lid_range_begin != 0xFFFF) {
>>>>>> - OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>>> - "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>>> - "Need to remove this informInfo from db\n");
>>>>>> - /* add the informInfo record to the remove_infr list */
>>>>>> - cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>>> - }
>>>>>> - goto Exit;
>>>>>> - }
>>>>>>
>>>>>> /* send the report to the address provided in the inform record */
>>>>>> OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>>>>>> --
>>>>>> 1.5.5
>>>>>>
>>>>>> There is still a problem with GID OUT trap that is not sent since source port
>>>>>> was already removed.
>>>>>> Patch will follow.
>>>>>>
>>>>>> --
>>>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>>>>> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
>>>>>> More majordomo info at http://vger.kernel.org/majordomo-info.html
>>>>>>
>>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <4B70363C.7080101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
@ 2010-02-08 19:06 ` Hal Rosenstock
0 siblings, 0 replies; 11+ messages in thread
From: Hal Rosenstock @ 2010-02-08 19:06 UTC (permalink / raw)
To: Eli Dorfman (Voltaire); +Cc: Sasha Khapyorsky, linux-rdma, Vladimir Koushnir
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset=UTF-8, Size: 14707 bytes --]
On Mon, Feb 8, 2010 at 11:05 AM, Eli Dorfman (Voltaire)
<dorfman.eli@gmail.com> wrote:
> Hal Rosenstock wrote:
>> On Sun, Feb 7, 2010 at 4:47 AM, Eli Dorfman (Voltaire)
>> <dorfman.eli@gmail.com> wrote:
>>> Hal Rosenstock wrote:
>>>> On Fri, Feb 5, 2010 at 9:18 AM, Eli Dorfman <dorfman.eli@gmail.com> wrote:
>>>>> On Thu, Feb 4, 2010 at 10:52 PM, Hal Rosenstock
>>>>> <hal.rosenstock@gmail.com> wrote:
>>>>>> On Thu, Feb 4, 2010 at 12:43 PM, Eli Dorfman (Voltaire)
>>>>>> <dorfman.eli@gmail.com> wrote:
>>>>>>> Subject: [PATCH] Wrong handling of MC create and delete traps
>>>>>>>
>>>>>>> For these traps the GID in the data details is the MGID and
>>>>>>> not the source port gid.
>>>>>>> So the SM should check that subscriber port has the pkey of the MC group.
>>>>>>> There was also an error in comparing the subnet prefix and guid due to
>>>>>>> host/network order mismatch.
>>>>>>>
>>>>>>> Signed-off-by: Eli Dorfman <elid@voltaire.com>
>>>>>>> ---
>>>>>>> Â opensm/opensm/osm_inform.c | Â 151 ++++++++++++++++++++++++++++---------------
>>>>>>> Â 1 files changed, 98 insertions(+), 53 deletions(-)
>>>>>>>
>>>>>>> diff --git a/opensm/opensm/osm_inform.c b/opensm/opensm/osm_inform.c
>>>>>>> index 8108213..ae4fe71 100644
>>>>>>> --- a/opensm/opensm/osm_inform.c
>>>>>>> +++ b/opensm/opensm/osm_inform.c
>>>>>>> @@ -341,6 +341,103 @@ Exit:
>>>>>>> Â Â Â Â return status;
>>>>>>> Â }
>>>>>>>
>>>>>>> +static int is_access_permitted( osm_infr_t *p_infr_rec,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â osm_infr_match_ctxt_t *p_infr_match )
>>>>>>> +{
>>>>>>> + Â Â Â cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>>>> + Â Â Â ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>>>> + Â Â Â ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>>>> + Â Â Â uint16_t trap_num = cl_ntoh16(p_ntc->g_or_v.generic.trap_num);
>>>>>>> + Â Â Â osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>>>> + Â Â Â osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>>>> + Â Â Â char gid_str[INET6_ADDRSTRLEN];
>>>>>>> + Â Â Â osm_mgrp_t *p_mgrp;
>>>>>>> + Â Â Â ib_gid_t source_gid;
>>>>>>> + Â Â Â osm_port_t *p_src_port;
>>>>>>> + Â Â Â osm_port_t *p_dest_port;
>>>>>>> +
>>>>>>> + Â Â Â /* In case of GID_IN(64) or GID_OUT(65) traps the source gid
>>>>>>> + Â Â Â Â Â comparison should be done on the trap source (saved as the gid in the
>>>>>>> + Â Â Â Â Â data details field).
>>>>>>> + Â Â Â Â Â For traps MC_CREATE(66) or MC_DELETE(67) the data details gid is
>>>>>>> + Â Â Â Â Â the MGID. We need to check whether subscriber has the pky of
>>>>>>          typo  ^^^^
>>>>>>
>>>>>> Â Â Â Â Â Â Â Â Â Â Â Â Â pkey
>>>>>>
>>>>>>
>>>>>>> + Â Â Â Â Â the MC group.
>>>>>> Shouldn't this be the subscriber has a compatible pkey with MC group ?
>>>>>> The MC group has a full member PKey and the members can be full or
>>>>>> limited.
>>>>> I accept the correction.
>>>> Doesn't this require a code change for handling trap cases 66-67 ?
>>> I think that you referred to the comment since the code is handling this properly (in my opinion).
>>
>> I was referring to both the comment and the code since a port with a
>> compatible limited pkey should be able to receive the reports for MC
>> groups.
>
> I agree and I think that the code is handling this case properly.
> osm_physp_has_pkey() takes the 15 lower MGID pkey bits and checks whether it is the physp pkey table.
You're right; the code handles it. I missed the ib_pkey_get_base call there.
-- Hal
>
> Eli
>>
>>>>> Sasha, can you please change this in the commit (only if there are not
>>>>> other remarks).
>>>> Is that what you are asking Sasha to do (beyond the typos) ?
>>> I asked Sasha to fix only the typo in commit.
>>>
>>>>> BTW, there is no explicit reference in the IB spec for MC group
>>>>> create/delete trap (at least I didn't find it).
>>>> Not sure what you mean by this. What didn't you find ?
>>> in the spec see o13-17.1.2
>>
>> Yes, there appear to be some holes in the spec in terms of this and
>> maybe more in this area (event forwarding) but the intent seems clear.
>>
>> -- Hal
>>
>>> Thanks,
>>> Eli
>>>> -- Hal
>>>>
>>>>>>> + Â Â Â Â Â In all other cases the issuer gis is the trap source.
>>>>>>                        typo  ^^^
>>>>>> Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â gid
>>>>>>
>>>>> and this typo of course.
>>>>>
>>>>> Thanks,
>>>>> Eli
>>>>>> -- Hal
>>>>>>
>>>>>>> + Â Â Â */
>>>>>>> + Â Â Â if (trap_num >= 64 && trap_num <= 67 )
>>>>>>> + Â Â Â Â Â Â Â /* The issuer of these traps is the SM so source_gid
>>>>>>> + Â Â Â Â Â Â Â Â Â is the gid saved on the data details */
>>>>>>> + Â Â Â Â Â Â Â source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>>>> + Â Â Â else
>>>>>>> + Â Â Â Â Â Â Â source_gid = p_ntc->issuer_gid;
>>>>>>> +
>>>>>>> + Â Â Â p_dest_port =
>>>>>>> + Â Â Â Â Â cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>>> + Â Â Â if (!p_dest_port) {
>>>>>>> + Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â "Cannot find destination port with LID:%u\n",
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>>> + Â Â Â Â Â Â Â goto Exit;
>>>>>>> + Â Â Â }
>>>>>>> +
>>>>>>> + Â Â Â switch (trap_num) {
>>>>>>> + Â Â Â Â Â Â Â case 66:
>>>>>>> + Â Â Â Â Â Â Â case 67:
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â p_mgrp = osm_get_mgrp_by_mgid(p_subn, &source_gid);
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â if (!p_mgrp) {
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Cannot find MGID %s\n",
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str));
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â goto Exit;
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â }
>>>>>>> +
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â if (!osm_physp_has_pkey(p_log,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â p_mgrp->mcmember_rec.pkey,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â p_dest_port->p_physp)) {
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "MGID %s and port GUID:0x%016" PRIx64 " do not share same pkey\n",
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â inet_ntop(AF_INET6, source_gid.raw, gid_str, sizeof gid_str),
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â cl_ntoh64(p_dest_port->guid));
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â goto Exit;
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â }
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â break;
>>>>>>> +
>>>>>>> + Â Â Â Â Â Â Â default:
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â p_src_port =
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â if (!p_src_port) {
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â cl_ntoh64(source_gid.unicast.interface_id));
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â goto Exit;
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â }
>>>>>>> +
>>>>>>> +
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â /* Check if there is a pkey match. o13-17.1.1 */
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â /* According to o13-17.1.2 - If this informInfo does not have
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â lid_range_begin of 0xFFFF, then this informInfo request
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â should be removed from database */
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â if (p_ii->lid_range_begin != 0xFFFF) {
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Need to remove this informInfo from db\n");
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â /* add the informInfo record to the remove_infr list */
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â }
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â goto Exit;
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â }
>>>>>>> + Â Â Â Â Â Â Â Â Â Â Â break;
>>>>>>> + Â Â Â }
>>>>>>> +
>>>>>>> + Â Â Â return 1;
>>>>>>> +Exit:
>>>>>>> + Â Â Â return 0;
>>>>>>> +}
>>>>>>> +
>>>>>>> +
>>>>>>> Â /**********************************************************************
>>>>>>> Â * This routine compares a given Notice and a ListItem of InformInfo type.
>>>>>>> Â * PREREQUISITE:
>>>>>>> @@ -351,15 +448,10 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>>>> Â {
>>>>>>> Â Â Â Â osm_infr_match_ctxt_t *p_infr_match = (osm_infr_match_ctxt_t *) context;
>>>>>>> Â Â Â Â ib_mad_notice_attr_t *p_ntc = p_infr_match->p_ntc;
>>>>>>> - Â Â Â cl_list_t *p_infr_to_remove_list = p_infr_match->p_remove_infr_list;
>>>>>>> Â Â Â Â osm_infr_t *p_infr_rec = (osm_infr_t *) p_list_item;
>>>>>>> Â Â Â Â ib_inform_info_t *p_ii = &(p_infr_rec->inform_record.inform_info);
>>>>>>> Â Â Â Â cl_status_t status = CL_NOT_FOUND;
>>>>>>> Â Â Â Â osm_log_t *p_log = p_infr_rec->sa->p_log;
>>>>>>> - Â Â Â osm_subn_t *p_subn = p_infr_rec->sa->p_subn;
>>>>>>> - Â Â Â ib_gid_t source_gid;
>>>>>>> - Â Â Â osm_port_t *p_src_port;
>>>>>>> - Â Â Â osm_port_t *p_dest_port;
>>>>>>>
>>>>>>> Â Â Â Â OSM_LOG_ENTER(p_log);
>>>>>>>
>>>>>>> @@ -460,55 +552,8 @@ static void match_notice_to_inf_rec(IN cl_list_item_t * p_list_item,
>>>>>>> Â Â Â Â Â Â Â Â }
>>>>>>> Â Â Â Â }
>>>>>>>
>>>>>>> - Â Â Â /* Check if there is a pkey match. o13-17.1.1 */
>>>>>>> - Â Â Â /* Check if the issuer of the trap is the SM. If it is, then the gid
>>>>>>> - Â Â Â Â Â comparison should be done on the trap source (saved as the gid in the
>>>>>>> - Â Â Â Â Â data details field).
>>>>>>> - Â Â Â Â Â If the issuer gid is not the SM - then it is the guid of the trap
>>>>>>> - Â Â Â Â Â source */
>>>>>>> - Â Â Â if ((cl_ntoh64(p_ntc->issuer_gid.unicast.prefix) ==
>>>>>>> - Â Â Â Â Â Â p_subn->opt.subnet_prefix)
>>>>>>> - Â Â Â Â Â && (cl_ntoh64(p_ntc->issuer_gid.unicast.interface_id) ==
>>>>>>> - Â Â Â Â Â Â Â p_subn->sm_port_guid))
>>>>>>> - Â Â Â Â Â Â Â /* The issuer is the SM then this is trap 64-67 - compare the gid
>>>>>>> - Â Â Â Â Â Â Â Â Â with the gid saved on the data details */
>>>>>>> - Â Â Â Â Â Â Â source_gid = p_ntc->data_details.ntc_64_67.gid;
>>>>>>> - Â Â Â else
>>>>>>> - Â Â Â Â Â Â Â source_gid = p_ntc->issuer_gid;
>>>>>>> -
>>>>>>> - Â Â Â p_src_port =
>>>>>>> - Â Â Â Â Â osm_get_port_by_guid(p_subn, source_gid.unicast.interface_id);
>>>>>>> - Â Â Â if (!p_src_port) {
>>>>>>> - Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â "Cannot find source port with GUID:0x%016" PRIx64 "\n",
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â cl_ntoh64(source_gid.unicast.interface_id));
>>>>>>> + Â Â Â if (!is_access_permitted(p_infr_rec, p_infr_match))
>>>>>>> Â Â Â Â Â Â Â Â goto Exit;
>>>>>>> - Â Â Â }
>>>>>>> -
>>>>>>> - Â Â Â p_dest_port =
>>>>>>> - Â Â Â Â Â cl_ptr_vector_get(&p_subn->port_lid_tbl,
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>>> - Â Â Â if (!p_dest_port) {
>>>>>>> - Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_INFO,
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â "Cannot find destination port with LID:%u\n",
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â cl_ntoh16(p_infr_rec->report_addr.dest_lid));
>>>>>>> - Â Â Â Â Â Â Â goto Exit;
>>>>>>> - Â Â Â }
>>>>>>> -
>>>>>>> - Â Â Â if (osm_port_share_pkey(p_log, p_src_port, p_dest_port) == FALSE) {
>>>>>>> - Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_DEBUG, "Mismatch by Pkey\n");
>>>>>>> - Â Â Â Â Â Â Â /* According to o13-17.1.2 - If this informInfo does not have
>>>>>>> - Â Â Â Â Â Â Â Â Â lid_range_begin of 0xFFFF, then this informInfo request
>>>>>>> - Â Â Â Â Â Â Â Â Â should be removed from database */
>>>>>>> - Â Â Â Â Â Â Â if (p_ii->lid_range_begin != 0xFFFF) {
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â OSM_LOG(p_log, OSM_LOG_VERBOSE,
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Pkey mismatch on lid_range_begin != 0xFFFF. "
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â Â Â Â Â "Need to remove this informInfo from db\n");
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â /* add the informInfo record to the remove_infr list */
>>>>>>> - Â Â Â Â Â Â Â Â Â Â Â cl_list_insert_tail(p_infr_to_remove_list, p_infr_rec);
>>>>>>> - Â Â Â Â Â Â Â }
>>>>>>> - Â Â Â Â Â Â Â goto Exit;
>>>>>>> - Â Â Â }
>>>>>>>
>>>>>>> Â Â Â Â /* send the report to the address provided in the inform record */
>>>>>>> Â Â Â Â OSM_LOG(p_log, OSM_LOG_DEBUG, "MATCH! Sending Report...\n");
>>>>>>> --
>>>>>>> 1.5.5
>>>>>>>
>>>>>>> There is still a problem with GID OUT trap that is not sent since source port
>>>>>>> was already removed.
>>>>>>> Patch will follow.
>>>>>>>
>>>>>>> --
>>>>>>> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
>>>>>>> the body of a message to majordomo@vger.kernel.org
>>>>>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>>>>>>
>>>
>
>
N‹§²æìr¸›yúèšØb²X¬¶Ç§vØ^–)Þº{.nÇ+‰·¥Š{±ÙšŠ{ayº\x1dʇڙë,j\a¢f£¢·hš‹»öì\x17/oSc¾™Ú³9˜uÀ¦æå‰È&jw¨®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿïêäz¹Þ–Šàþf£¢·hšˆ§~ˆmš
^ permalink raw reply [flat|nested] 11+ messages in thread
* Re: [PATCH v2] opensm: bug in trap report for MC create(66) and delete(67) traps
[not found] ` <4B6B0736.9010001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-04 20:52 ` Hal Rosenstock
@ 2010-11-09 19:35 ` Sasha Khapyorsky
1 sibling, 0 replies; 11+ messages in thread
From: Sasha Khapyorsky @ 2010-11-09 19:35 UTC (permalink / raw)
To: Eli Dorfman (Voltaire); +Cc: linux-rdma, Vladimir Koushnir
On 19:43 Thu 04 Feb , Eli Dorfman (Voltaire) wrote:
>
> Subject: [PATCH] Wrong handling of MC create and delete traps
>
> For these traps the GID in the data details is the MGID and
> not the source port gid.
> So the SM should check that subscriber port has the pkey of the MC group.
> There was also an error in comparing the subnet prefix and guid due to
> host/network order mismatch.
>
> Signed-off-by: Eli Dorfman <elid-smomgflXvOZWk0Htik3J/w@public.gmane.org>
Rebased and applied. Thanks.
Sasha
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 11+ messages in thread
end of thread, other threads:[~2010-11-09 19:35 UTC | newest]
Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-02 14:13 [PATCH] opensm: bug in trap report for MC create(66) and delete(67) traps Eli Dorfman (Voltaire)
[not found] ` <4B6832F8.9090200-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-03 9:49 ` Sasha Khapyorsky
2010-02-04 17:43 ` [PATCH v2] " Eli Dorfman (Voltaire)
[not found] ` <4B6B0736.9010001-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-04 20:52 ` Hal Rosenstock
[not found] ` <f0e08f231002041252s4c2f9c66jaa43d25bb3c75cbc-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-05 14:18 ` Eli Dorfman
[not found] ` <694d48601002050618s2af59695xa36522c04027d8af-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-05 16:20 ` Hal Rosenstock
[not found] ` <f0e08f231002050820j1df2b425ia44203957257a6fb-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-07 9:47 ` Eli Dorfman (Voltaire)
[not found] ` <4B6E8C46.5020807-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-08 13:26 ` Hal Rosenstock
[not found] ` <f0e08f231002080526k562b2082oa7376c50794c6f75-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2010-02-08 16:05 ` Eli Dorfman (Voltaire)
[not found] ` <4B70363C.7080101-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2010-02-08 19:06 ` Hal Rosenstock
2010-11-09 19:35 ` Sasha Khapyorsky
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).