From: Tariq Toukan <ttoukan.linux@gmail.com>
To: linux@treblig.org, tariqt@nvidia.com, andrew+netdev@lunn.ch,
davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, yishaih@nvidia.com
Cc: netdev@vger.kernel.org, linux-rdma@vger.kernel.org,
linux-kernel@vger.kernel.org, Simon Horman <horms@kernel.org>
Subject: Re: [PATCH net-next] mlx4: Remove unused functions
Date: Mon, 3 Feb 2025 23:44:00 +0200 [thread overview]
Message-ID: <f25f3831-8e03-4225-8132-b486d989604e@gmail.com> (raw)
In-Reply-To: <20250203185229.204279-1-linux@treblig.org>
On 03/02/2025 20:52, linux@treblig.org wrote:
> From: "Dr. David Alan Gilbert" <linux@treblig.org>
>
> The last use of mlx4_find_cached_mac() was removed in 2014 by
> commit 2f5bb473681b ("mlx4: Add ref counting to port MAC table for RoCE")
>
> mlx4_zone_free_entries() was added in 2014 by
> commit 7a89399ffad7 ("net/mlx4: Add mlx4_bitmap zone allocator")
> but hasn't been used. (The _unique version is used)
>
> Remove them.
>
> Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
> Reviewed-by: Simon Horman <horms@kernel.org>
> ---
> drivers/net/ethernet/mellanox/mlx4/alloc.c | 22 ----------------------
> drivers/net/ethernet/mellanox/mlx4/mlx4.h | 6 ------
> drivers/net/ethernet/mellanox/mlx4/port.c | 20 --------------------
> include/linux/mlx4/device.h | 1 -
> 4 files changed, 49 deletions(-)
>
Thanks for your patch.
Reviewed-by: Tariq Toukan <tariqt@nvidia.com>
Tariq
next prev parent reply other threads:[~2025-02-03 21:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-03 18:52 [PATCH net-next] mlx4: Remove unused functions linux
2025-02-03 21:44 ` Tariq Toukan [this message]
2025-02-04 8:20 ` Kalesh Anakkur Purayil
2025-02-04 22:20 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f25f3831-8e03-4225-8132-b486d989604e@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@treblig.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tariqt@nvidia.com \
--cc=yishaih@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox