From: "Radu Pirea (OSS)" <radu-nicolae.pirea@oss.nxp.com>
To: Sabrina Dubroca <sd@queasysnail.net>
Cc: sgoutham@marvell.com, gakula@marvell.com, sbhatta@marvell.com,
hkelam@marvell.com, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, borisp@nvidia.com,
saeedm@nvidia.com, leon@kernel.org, andrew@lunn.ch,
hkallweit1@gmail.com, linux@armlinux.org.uk,
richardcochran@gmail.com, sebastian.tobuschat@oss.nxp.com,
linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only when update_pn is true
Date: Wed, 4 Oct 2023 21:30:24 +0300 [thread overview]
Message-ID: <f4d355cc-66c0-1757-4a9b-781db451cfbc@oss.nxp.com> (raw)
In-Reply-To: <ZRwT76YcQAFXKD4k@hog>
On 03.10.2023 16:15, Sabrina Dubroca wrote:
> 2023-09-28, 11:44:25 +0300, Radu Pirea (NXP OSS) wrote:
>> When updating SA, update the PN only when the update_pn flag is true.
>> Otherwise, the PN will be reset to its previous value.
>
> This is a bugfix and should go through the net tree with a Fixes
> tag. I'd suggest taking patches 3,5,6 out of this series and
> submitting them all to net, with a Fixes tag for patches 5 and
> 6. Patch 7 doesn't fix a bug and could go through the net-next tree.
>
Patch 7 does not look like a bug fix, but it is.
Without patch 7 a user will be able to update the SA using the initial
PN value like this:
ip link add link eth0 macsec0 type macsec encrypt on offload phy
ip macsec add macsec0 tx sa 0 pn 1 on key 00
ead3664f508eb06c40ac7104cdae4ce5
ip macsec set macsec0 tx sa 0 pn 1 off #this command does not fail, but
it should
--
Radu P.
next prev parent reply other threads:[~2023-10-04 18:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-28 8:44 [PATCH net-next v6 00/10] Add MACsec support for TJA11XX C45 PHYs Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 01/10] net: macsec: move sci_to_cpu to macsec header Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 02/10] net: macsec: documentation for macsec_context and macsec_ops Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 03/10] net: macsec: indicate next pn update when offloading Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 04/10] net: macsec: introduce mdo_insert_tx_tag Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 05/10] octeontx2-pf: mcs: update PN only when update_pn is true Radu Pirea (NXP OSS)
2023-09-29 6:20 ` [EXT] " Subbaraya Sundeep Bhatta
2023-10-03 13:15 ` Sabrina Dubroca
2023-10-04 18:30 ` Radu Pirea (OSS) [this message]
2023-09-28 8:44 ` [PATCH net-next v6 06/10] net: phy: mscc: macsec: reject PN update requests Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 07/10] net/mlx5e: macsec: use update_pn flag instead of PN comparation Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 08/10] net: phy: nxp-c45-tja11xx: add MACsec support Radu Pirea (NXP OSS)
2023-10-02 21:08 ` Sabrina Dubroca
2023-09-28 8:44 ` [PATCH net-next v6 09/10] net: phy: nxp-c45-tja11xx: add MACsec statistics Radu Pirea (NXP OSS)
2023-09-28 8:44 ` [PATCH net-next v6 10/10] net: phy: nxp-c45-tja11xx: implement mdo_insert_tx_tag Radu Pirea (NXP OSS)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f4d355cc-66c0-1757-4a9b-781db451cfbc@oss.nxp.com \
--to=radu-nicolae.pirea@oss.nxp.com \
--cc=andrew@lunn.ch \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gakula@marvell.com \
--cc=hkallweit1@gmail.com \
--cc=hkelam@marvell.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=richardcochran@gmail.com \
--cc=saeedm@nvidia.com \
--cc=sbhatta@marvell.com \
--cc=sd@queasysnail.net \
--cc=sebastian.tobuschat@oss.nxp.com \
--cc=sgoutham@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox