public inbox for linux-rdma@vger.kernel.org
 help / color / mirror / Atom feed
From: "Nachum, Yonatan" <ynachum@amazon.com>
To: Leon Romanovsky <leon@kernel.org>
Cc: <jgg@nvidia.com>, <linux-rdma@vger.kernel.org>,
	<sleybo@amazon.com>, <matua@amazon.com>, <mrgolin@amazon.com>,
	Firas Jahjah <firasj@amazon.com>
Subject: Re: [PATCH] RDMA/efa: Add rdma write capability to device caps
Date: Sun, 9 Apr 2023 14:28:04 +0300	[thread overview]
Message-ID: <f738b558-f0d9-e69e-0939-a80594063d4c@amazon.com> (raw)
In-Reply-To: <20230409073228.GA14869@unreal>


>>
>>       access_flags &= ~IB_ACCESS_OPTIONAL;
>>       if (access_flags & ~supp_access_flags) {
>> diff --git a/include/uapi/rdma/efa-abi.h b/include/uapi/rdma/efa-abi.h
>> index 74406b4817ce..d94c32f28804 100644
>> --- a/include/uapi/rdma/efa-abi.h
>> +++ b/include/uapi/rdma/efa-abi.h
>> @@ -121,6 +121,7 @@ enum {
>>       EFA_QUERY_DEVICE_CAPS_CQ_NOTIFICATIONS = 1 << 2,
>>       EFA_QUERY_DEVICE_CAPS_CQ_WITH_SGID     = 1 << 3,
>>       EFA_QUERY_DEVICE_CAPS_DATA_POLLING_128 = 1 << 4,
>> +     EFA_QUERY_DEVICE_CAPS_RDMA_WRITE = 1 << 5,
> 
> Why do you need special device capability while all rdma-core users
> set IBV_ACCESS_REMOTE_WRITE anyway without relying on anything from
> providers?
> 
> Thanks

We need to query the device because not every device supprort the same RDMA capabilities. Upper layers in the SW stack needs this supported flags to indicate which flows they can use. In addition this is identical to the existing RDMA read support in our code. 

Thanks.

  reply	other threads:[~2023-04-09 11:28 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-04 15:43 [PATCH] RDMA/efa: Add rdma write capability to device caps ynachum
2023-04-09  7:32 ` Leon Romanovsky
2023-04-09 11:28   ` Nachum, Yonatan [this message]
2023-04-09 17:21     ` Leon Romanovsky
2023-04-10 12:24       ` Nachum, Yonatan
2023-04-10 12:38         ` Leon Romanovsky
2023-04-10 14:14           ` Nachum, Yonatan
2023-04-13  8:22             ` Leon Romanovsky
2023-04-13 13:43               ` Nachum, Yonatan
2023-04-18 14:03                 ` Nachum, Yonatan
2023-04-21 22:20 ` Jason Gunthorpe

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=f738b558-f0d9-e69e-0939-a80594063d4c@amazon.com \
    --to=ynachum@amazon.com \
    --cc=firasj@amazon.com \
    --cc=jgg@nvidia.com \
    --cc=leon@kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=matua@amazon.com \
    --cc=mrgolin@amazon.com \
    --cc=sleybo@amazon.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox