Re: [PATCH v11 rdma-next 6/7] RDMA/qedr: Add doorbell overflow recovery support

Jason Gunthorpe
2019-09-19T18:02:29Z

On Thu, Sep 05, 2019 at 01:01:16PM +0300, Michal Kalderon wrote:

> @@ -347,6 +360,9 @@ void qedr_mmap_free(struct rdma_user_mmap_entry *rdma_entry)
> {
> struct qedr_user_mmap_entry *entry = get_qedr_mmap_entry(rdma_entry);
>
> + if (entry->mmap_flag == QEDR_USER_MMAP_PHYS_PAGE)
> + free_page((unsigned long)phys_to_virt(entry->address));
> +

While it isn't wrong it do it this way, we don't need this mmap_free()
stuff for normal CPU pages. Those are refcounted and qedr can simply
call free_page() during the teardown of the uobject that is using the
this page. This is what other drivers already do.

I'm also not sure why qedr is using a phys_addr for a struct page
object, seems wrong.

Jason