From: 靳文宾 <jinwenbinxue@163.com>
To: linux-rdma@vger.kernel.org
Subject: [bug] rdma-core/librdmacm/cma.c rdma_create_qp_ex:add id->cq refer to qp_attr->cq, when qp_attr->cq is not NULL, and id->cq is NULL
Date: Tue, 27 Aug 2024 14:20:59 +0800 (CST) [thread overview]
Message-ID: <f819f8c.52ce.191927ea67c.Coremail.jinwenbinxue@163.com> (raw)
I think the following modification is more correct,
if there have something i dont know, pls tell me, thx
diff --git a/librdmacm/cma.c b/librdmacm/cma.c
index 7b924bd0d..9e71ba858 100644
--- a/librdmacm/cma.c
+++ b/librdmacm/cma.c
@@ -1654,10 +1654,20 @@ int rdma_create_qp_ex(struct rdma_cm_id *id,
if (ret)
return ret;
- if (!attr->send_cq)
+ if (!attr->send_cq) {
attr->send_cq = id->send_cq;
- if (!attr->recv_cq)
+ } else {
+ if (!id->recv_cq)
+ id->recv_cq = attr->recv_cq;
+ }
+ if (!attr->recv_cq) {
attr->recv_cq = id->recv_cq;
+ } else {
+ if (!id->recv_cq)
+ id->recv_cq = attr->recv_cq;
+ }
+
+
if (id->srq && !attr->srq)
attr->srq = id->srq;
qp = ibv_create_qp_ex(id->verbs, attr);
next reply other threads:[~2024-08-27 6:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-27 6:20 靳文宾 [this message]
2024-08-28 0:51 ` [bug] rdma-core/librdmacm/cma.c rdma_create_qp_ex:add id->cq refer to qp_attr->cq, when qp_attr->cq is not NULL, and id->cq is NULL Zhijian Li (Fujitsu)
2024-08-29 9:08 ` Leon Romanovsky
2024-08-29 12:04 ` [bug] rdma-core/librdmacm/cma.c rdma_create_qp_exï¼add " Zhu Yanjun
2024-09-02 7:00 ` Leon Romanovsky
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f819f8c.52ce.191927ea67c.Coremail.jinwenbinxue@163.com \
--to=jinwenbinxue@163.com \
--cc=linux-rdma@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox