From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9A7F3CDB46E for ; Thu, 12 Oct 2023 11:59:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235727AbjJLL7r (ORCPT ); Thu, 12 Oct 2023 07:59:47 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33414 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235724AbjJLL7i (ORCPT ); Thu, 12 Oct 2023 07:59:38 -0400 Received: from out-210.mta1.migadu.com (out-210.mta1.migadu.com [IPv6:2001:41d0:203:375::d2]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6D58F49D1 for ; Thu, 12 Oct 2023 04:50:12 -0700 (PDT) Message-ID: Date: Thu, 12 Oct 2023 19:49:35 +0800 MIME-Version: 1.0 Subject: Re: [PATCH 1/1] Revert "RDMA/rxe: Add workqueue support for rxe tasks" To: Jason Gunthorpe , Bart Van Assche Cc: Bob Pearson , "Daisuke Matsuda (Fujitsu)" , Leon Romanovsky , "zyjzyj2000@gmail.com" , "linux-rdma@vger.kernel.org" , "shinichiro.kawasaki@wdc.com" , "linux-scsi@vger.kernel.org" , Zhu Yanjun References: <20231004183824.GQ13795@ziepe.ca> <20231005142148.GA970053@ziepe.ca> <6a730dad-9d81-46d9-8adc-764d00745b01@acm.org> <20231010160919.GC55194@ziepe.ca> <20231011155104.GF55194@ziepe.ca> <70191324-018e-4cfe-9c1d-0bd3d17fb437@acm.org> <20231011231201.GH55194@ziepe.ca> X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Zhu Yanjun In-Reply-To: <20231011231201.GH55194@ziepe.ca> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT Precedence: bulk List-ID: X-Mailing-List: linux-rdma@vger.kernel.org 在 2023/10/12 7:12, Jason Gunthorpe 写道: > On Wed, Oct 11, 2023 at 01:14:16PM -0700, Bart Van Assche wrote: >> On 10/11/23 08:51, Jason Gunthorpe wrote: >>> If we revert it then rxe will probably just stop development >>> entirely. Daisuke's ODP work will be blocked and if Bob was able to >>> fix it he would have done so already. Which mean's Bobs ongoing work >>> is lost too. >> >> If Daisuke's work depends on the RXE changes then Daisuke may decide >> to help with the RXE changes. >> >> Introducing regressions while refactoring code is not acceptable. > > Generally, but I don't view rxe as a production part of the kernel so > I prefer to give time to resolve it. > >> I don't have enough spare time to help with the RXE driver. commit 11ab7cc7ee32d6c3e16ac74c34c4bbdbf8f99292 Author: Bart Van Assche Date: Tue Aug 22 09:57:07 2023 -0700 Change the default RDMA driver from rdma_rxe to siw Since the siw driver is more stable than the rdma_rxe driver, change the default into siw. See e.g. https://lore.kernel.org/all/c3d1a966-b9b0-d015-38ec-86270b5045fc@acm.org/. Signed-off-by: Bart Van Assche Signed-off-by: Shin'ichiro Kawasaki > > Nor I > > Jason