From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dennis Dalessandro Subject: Re: [rdma-next 13/22] RDMA/hns: Remove empty functions Date: Fri, 11 Aug 2017 08:26:38 -0400 Message-ID: References: <20170811105003.7661-1-leon@kernel.org> <20170811105003.7661-14-leon@kernel.org> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20170811105003.7661-14-leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Leon Romanovsky , Doug Ledford Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Leon Romanovsky List-Id: linux-rdma@vger.kernel.org On 8/11/2017 6:49 AM, Leon Romanovsky wrote: > From: Leon Romanovsky > > The functions which are not implemented can be simply ignored > instead of defining empty function. This patch removes such functions > from hns driver. > > Signed-off-by: Leon Romanovsky I thought I replied about this or a very similar patch, but can't find the link. Regardless, I think these sort of work-in-progress stubs are OK as incremental development, part of "showing your work" but I would have expected to see them implemented in the same series, or at least soon there-after. So the fact that these are still empty after this much time. I agree, get rid of them. Reviewed-by: Dennis Dalessandro -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html