[PATCH] librdmacm: fix compiler warning of void* arithmetic

[PATCH] librdmacm: fix compiler warning of void* arithmetic

[Jonathan Rosser]

Arithmetic on void* pointers generates a compiler warning, and projects
that include rdma/rdma_verbs.h and compile with  -Werror -Wall will fail
to build.
---
  include/rdma/rdma_verbs.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/rdma/rdma_verbs.h b/include/rdma/rdma_verbs.h
index d75d906..853ef9b 100644
--- a/include/rdma/rdma_verbs.h
+++ b/include/rdma/rdma_verbs.h
@@ -160,7 +160,7 @@ rdma_post_recv(struct rdma_cm_id *id, void *context, 
void *addr,
  {
  	struct ibv_sge sge;

-	assert((addr >= mr->addr) && ((addr + length) <= (mr->addr + 
mr->length)));
+	assert((addr >= mr->addr) && (((uint8_t*)addr + length) <= 
((uint8_t*)mr->addr + mr->length)));
  	sge.addr = (uint64_t) (uintptr_t) addr;
  	sge.length = (uint32_t) length;
  	sge.lkey = mr->lkey;
-- 
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] librdmacm: fix compiler warning of void* arithmetic

[Andrea Gozzelino]

On Oct 22, 2010 12:00 PM, Jonathan Rosser <jonathan.rosser-gjMux1o1B1/QXOPxS62xeg@public.gmane.org>
wrote:

> Arithmetic on void* pointers generates a compiler warning, and
> projects
> that include rdma/rdma_verbs.h and compile with -Werror -Wall will
> fail
> to build.
> ---
>   include/rdma/rdma_verbs.h |    2 +-
>   1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/include/rdma/rdma_verbs.h b/include/rdma/rdma_verbs.h
> index d75d906..853ef9b 100644
> --- a/include/rdma/rdma_verbs.h
> +++ b/include/rdma/rdma_verbs.h
> @@ -160,7 +160,7 @@ rdma_post_recv(struct rdma_cm_id *id, void
> *context,
> void *addr,
>   {
>   	struct ibv_sge sge;
> 
> -	assert((addr >= mr->addr) && ((addr + length) <= (mr->addr + 
> mr->length)));
> +	assert((addr >= mr->addr) && (((uint8_t*)addr + length) <= 
> ((uint8_t*)mr->addr + mr->length)));
>   	sge.addr = (uint64_t) (uintptr_t) addr;
>   	sge.length = (uint32_t) length;
>   	sge.lkey = mr->lkey;
> -- 
> 1.7.0.4
> 
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma"
> in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> 

Hi Jonathan,

I have found the same building error. Now it works fine.


Andrea Gozzelino

INFN - Laboratori Nazionali di Legnaro	(LNL)
Viale dell'Universita' 2 -I-35020 - Legnaro (PD)- ITALIA
Office: E-101
Tel: +39 049 8068346
Fax: +39 049 641925
Mail: andrea.gozzelino-PK20h7lG/Rc1GQ1Ptb7lUw@public.gmane.org
Cell: +39 3488245552				

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [PATCH] librdmacm: fix compiler warning of void* arithmetic

[Jonathan Rosser]

Arithmetic on void* pointers generates a compiler warning, and projects
that include rdma/rdma_verbs.h and compile with  -Werror -Wall will fail
to build.

Signed-off-by: Jonathan Rosser <jrosser-gjMux1o1B1/QXOPxS62xeg@public.gmane.org>
---
  include/rdma/rdma_verbs.h |    2 +-
  1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/rdma/rdma_verbs.h b/include/rdma/rdma_verbs.h
index d75d906..853ef9b 100644
--- a/include/rdma/rdma_verbs.h
+++ b/include/rdma/rdma_verbs.h
@@ -160,7 +160,7 @@ rdma_post_recv(struct rdma_cm_id *id, void *context, 
void *addr,
  {
         struct ibv_sge sge;

-       assert((addr >= mr->addr) && ((addr + length) <= (mr->addr + 
mr->length)));
+       assert((addr >= mr->addr) && (((uint8_t*)addr + length) <= 
((uint8_t*)mr->addr + mr->length)));
         sge.addr = (uint64_t) (uintptr_t) addr;
         sge.length = (uint32_t) length;
         sge.lkey = mr->lkey;
-- 
1.7.0.4



--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

RE: [PATCH] librdmacm: fix compiler warning of void* arithmetic

[Hefty, Sean]

Thanks - both applied
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html