From: Cong Wang <xiyou.wangcong@gmail.com>
To: netdev@vger.kernel.org
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup_skb return value handling bug
Date: Thu, 14 Mar 2013 05:26:20 +0000 (UTC) [thread overview]
Message-ID: <khrn1r$j3t$1@ger.gmane.org> (raw)
In-Reply-To: 1363232492-4562-1-git-send-email-zhouzhouyi@gmail.com
On Thu, 14 Mar 2013 at 03:41 GMT, Zhouyi Zhou <zhouzhouyi@gmail.com> wrote:
> Tested on my x86_64 machine
>
> Signed-off-by: Zhouyi Zhou <zhouzhouyi@gmail.com>
> ---
> drivers/infiniband/hw/cxgb4/cm.c | 12 ++++++++++++
> include/net/dst.h | 6 ++++--
> 2 files changed, 16 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/hw/cxgb4/cm.c b/drivers/infiniband/hw/cxgb4/cm.c
> index 565bfb1..6b95851 100644
> --- a/drivers/infiniband/hw/cxgb4/cm.c
> +++ b/drivers/infiniband/hw/cxgb4/cm.c
> @@ -1575,6 +1575,12 @@ static int c4iw_reconnect(struct c4iw_ep *ep)
>
> neigh = dst_neigh_lookup(ep->dst,
> &ep->com.cm_id->remote_addr.sin_addr.s_addr);
> + if (!neigh) {
> + pr_err("%s - cannot alloc neigh.\n", __func__);
> + err = -ENOMEM;
> + goto fail4;
You don't need to print error messages for OOM, the mm subsystem will
do.
next prev parent reply other threads:[~2013-03-14 5:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-14 3:41 [PATCH 1/1] Fix dst_neigh_lookup/dst_neigh_lookup_skb return value handling bug Zhouyi Zhou
2013-03-14 5:26 ` Cong Wang [this message]
[not found] ` <1363232492-4562-1-git-send-email-zhouzhouyi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2013-03-15 13:42 ` Steve Wise
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='khrn1r$j3t$1@ger.gmane.org' \
--to=xiyou.wangcong@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox