* Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
From: Parav Pandit @ 2016-09-21 4:43 UTC (permalink / raw)
To: Leon Romanovsky
Cc: Jason Gunthorpe, Christoph Hellwig, Matan Barak, Tejun Heo,
cgroups, linux-doc, Linux Kernel Mailing List, linux-rdma,
Li Zefan, Johannes Weiner, Doug Ledford, Liran Liss, Hefty, Sean,
Haggai Eran, Jonathan Corbet, james.l.morris, serge, Or Gerlitz,
Andrew Morton, linux-security-module
In-Reply-To: <20160915185629.GF26069@leon.nu>
Hi Leon,
On Fri, Sep 16, 2016 at 12:26 AM, Leon Romanovsky <leon@kernel.org> wrote:
> On Wed, Sep 14, 2016 at 12:36:19PM +0530, Parav Pandit wrote:
>> Hi Dennis,
>>
>> Do you know how would HFI1 driver would work along with rdma cgroup?
>>
>> Hi Matan, Leon, Jason,
>> Apart from HFI1, is there any other concern?
>> Or Patch is good to go?
>
> I didn't review it yet :(.
> Sorry
>
We have completed review from Tejun, Christoph.
HFI driver folks also provided feedback for Intel drivers.
Matan's also doesn't have any more comments.
If possible, if you can also review, it will be helpful.
I have some more changes unrelated to cgroup in same files in both the git tree.
Pushing them now either results into merge conflict later on for
Doug/Tejun, or requires rebase and resending patch.
If you can review, we can avoid such rework.
>>
>> 4.8 dates are close by (2 weeks) and there are two git trees involved
>> (that might cause merge error to Linus) so if there are no issues, I
>> would like to make request to Doug to consider it for 4.8 early on.
>>
>> Parav
>>
>> On Mon, Sep 12, 2016 at 10:37 AM, Leon Romanovsky <leon@kernel.org> wrote:
>> > On Sun, Sep 11, 2016 at 11:52:35AM -0600, Jason Gunthorpe wrote:
>> >> On Sun, Sep 11, 2016 at 07:24:45PM +0200, Christoph Hellwig wrote:
>> >> > > > > I've posted some initial work toward a) a while ago, and once we
>> >> > >
>> >> > > Did it get merged? Do you have a pointer?
>> >> >
>> >> > http://www.spinics.net/lists/linux-rdma/msg31958.html
>> >>
>> >> Right, I remember that. Certainly the right direction
>> >>
>> >> > > However, everything under verbs is not straightforward. The files in
>> >> > > userspace are not copies...
>> >> > >
>> >> > > user:
>> >> > >
>> >> > > struct ibv_query_device {
>> >> > > __u32 command;
>> >> > > __u16 in_words;
>> >> > > __u16 out_words;
>> >> > > __u64 response;
>> >> > > __u64 driver_data[0];
>> >> > > };
>> >> > >
>> >> > > kernel:
>> >> > >
>> >> > > struct ib_uverbs_query_device {
>> >> > > __u64 response;
>> >> > > __u64 driver_data[0];
>> >> > > };
>> >> >
>> >> > We'll obviously need different strutures for the libibvers API
>> >> > and the kernel interface in this case, and we'll need to figure out
>> >> > how to properly translate them. I think a cast, plus compile time
>> >> > type checking ala BUILD_BUG_ON is the way to go.
>> >>
>> >> I'm not sure I follow, which would I cast?
>> >>
>> >> BUILD_BUG_ON(sizeof(ibv_query_device) == sizeof(ib_uverbs_cmd_hdr) +
>> >> sizeof(ib_uverbs_query_device))
>> >>
>> >> ?
>> >>
>> >> > > I'm thinking the best way forward might be to use a script and
>> >> > > transform userspace into:
>> >> > >
>> >> > > struct ibv_query_device {
>> >> > > struct ib_uverbs_cmd_hdr hdr;
>> >> > > struct ib_uverbs_query_device cmd;
>> >> > > };
>> >> >
>> >> > That would break the users of the interface.
>> >>
>> >> Sorry, I mean doing this inside rdma-plumbing. Since the change is ABI
>> >> identical the modified libibverbs would still be binary compatible
>> >> with all providers but not source compatible. Since all kernel
>> >> supported providers are in rdma-plumbing we can add the '.cmd.' at the
>> >> same time.
>> >>
>> >> The kernel uapi header would stay the same.
>> >>
>> >> > However automatically generating the user ABI from the kernel one
>> >> > might still be a good idea in the long run.
>> >>
>> >> My preference would be to try and use the kernel headers directly.
>> >
>> > I thought the same, especially after realizing that they are almost
>> > copy/paste from the vendor *-abi.h files.
>> >
>> >>
>> >> Jason
^ permalink raw reply
* Re: [PATCH 1/3] IB/device: Convert ib-comp-wq to be CPU-bound
From: Max Gurtovoy @ 2016-09-21 7:52 UTC (permalink / raw)
To: Sagi Grimberg, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Christoph Hellwig, Bart Van Assche
In-Reply-To: <1474429063-22407-1-git-send-email-sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
Hi Sagi,
this looks correct but did you see some performance impvrovments with
this patch using iSER/NVMf/SRP ?
On 9/21/2016 6:37 AM, Sagi Grimberg wrote:
> This workqueue is used by our storage target mode ULPs
> via the new CQ API. Recent observations when working
> with very high-end flash storage devices reveal that
> UNBOUND workqueue threads can migrate between cpu cores
> and even numa nodes (although some numa locality is accounted
> for).
>
> While this attribute can be useful in some workloads,
> it does not fit in very nicely with the normal
> run-to-completion model we usually use in our target-mode
> ULPs and the block-mq irq<->cpu affinity facilities.
>
> The whole block-mq concept is that the completion will
> land on the same cpu where the submission was performed.
> The fact that our submitter thread is migrating cpus
> can break this locality.
>
> We assume that as a target mode ULP, we will serve multiple
> initiators/clients and we can spread the load enough without
> having to use unbound kworkers.
>
> Also, while we're at it, expose this workqueue via sysfs which
> is harmless and can be useful for debug.
>
> Signed-off-by: Sagi Grimberg <sagi-NQWnxTmZq1alnMjI0IkVqw@public.gmane.org>
> ---
> drivers/infiniband/core/device.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/drivers/infiniband/core/device.c b/drivers/infiniband/core/device.c
> index 760ef603a468..15f4bdf89fe1 100644
> --- a/drivers/infiniband/core/device.c
> +++ b/drivers/infiniband/core/device.c
> @@ -999,8 +999,7 @@ static int __init ib_core_init(void)
> return -ENOMEM;
>
> ib_comp_wq = alloc_workqueue("ib-comp-wq",
> - WQ_UNBOUND | WQ_HIGHPRI | WQ_MEM_RECLAIM,
> - WQ_UNBOUND_MAX_ACTIVE);
> + WQ_HIGHPRI | WQ_MEM_RECLAIM | WQ_SYSFS, 0);
> if (!ib_comp_wq) {
> ret = -ENOMEM;
> goto err;
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 11/16] Remove the auto* based build systems
From: Yishai Hadas @ 2016-09-21 13:53 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, alaa-VPRAkNaXOzVWk0Htik3J/w,
yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Doug Ledford
In-Reply-To: <1474409425-15769-12-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On 9/21/2016 1:10 AM, Jason Gunthorpe wrote:
> The unified cmake version provides the same functionality now.
Can you explain how cmake preservers some compilation options which were
enabled per vendor ? for example with previous build system someone
could run configure of libmlx5 with --with-mlx5_debug, how can it be
done now ?
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
> ibacm/INSTALL | 0
> ibacm/Makefile.am | 49 -
> ibacm/NEWS | 0
> ibacm/README | 12 -
> ibacm/autogen.sh | 5 -
> ibacm/configure.ac | 106 -
> iwpmd/Makefile.am | 11 -
> iwpmd/NEWS | 0
> iwpmd/autogen.sh | 3 -
> iwpmd/configure.ac | 37 -
> libcxgb3/Makefile.am | 27 -
> libcxgb3/autogen.sh | 8 -
> libcxgb3/config/.gitignore | 0
> libcxgb3/configure.in | 69 -
> libcxgb3/cxgb3.driver | 1 -
> libcxgb3/src/iwch.map | 6 -
> libcxgb4/Makefile.am | 27 -
> libcxgb4/autogen.sh | 8 -
> libcxgb4/config/config.guess | 1439 ----
> libcxgb4/config/config.sub | 1811 -----
> libcxgb4/config/depcomp | 530 --
> libcxgb4/config/install-sh | 323 -
> libcxgb4/configure.in | 69 -
> libcxgb4/cxgb4.driver | 1 -
> libcxgb4/src/cxgb4.map | 6 -
> libhfi1verbs/Makefile.am | 83 -
> libhfi1verbs/autogen.sh | 64 -
> libhfi1verbs/configure.in | 126 -
> libhfi1verbs/hfi1verbs.driver | 1 -
> libhfi1verbs/makefile | 107 -
> libhfi1verbs/makesrpm.sh | 21 -
> libhfi1verbs/src/hfiverbs.map | 4 -
> libi40iw/Makefile.am | 26 -
> libi40iw/configure.ac | 74 -
> libi40iw/i40iw.driver | 1 -
> libi40iw/src/i40iw.map | 39 -
> libibcm/INSTALL | 0
> libibcm/Makefile.am | 35 -
> libibcm/NEWS | 0
> libibcm/autogen.sh | 9 -
> libibcm/configure.in | 72 -
> libibumad/Makefile.am | 75 -
> libibumad/autogen.sh | 11 -
> libibumad/configure.in | 72 -
> libibverbs/Makefile.am | 132 -
> libibverbs/autogen.sh | 4 -
> libibverbs/config/.gitignore | 8 -
> libibverbs/configure.ac | 124 -
> libipathverbs/Makefile.am | 79 -
> libipathverbs/autogen.sh | 43 -
> libipathverbs/configure.in | 120 -
> libipathverbs/ipathverbs.driver | 1 -
> libipathverbs/src/ipathverbs.map | 4 -
> libmlx4/Makefile.am | 19 -
> libmlx4/autogen.sh | 4 -
> libmlx4/config/.gitignore | 8 -
> libmlx4/configure.ac | 96 -
> libmlx4/mlx4.driver | 1 -
> libmlx4/src/mlx4.map | 5 -
> libmlx5/Makefile.am | 27 -
> libmlx5/autogen.sh | 7 -
> libmlx5/config/.gitignore | 8 -
> libmlx5/configure.ac | 108 -
> libmlx5/m4/ax_gcc_func_attribute.m4 | 223 -
> libmlx5/mlx5.driver | 1 -
> libmlx5/src/mlx5.map | 5 -
> libmthca/Makefile.am | 29 -
> libmthca/autogen.sh | 8 -
> libmthca/config/.gitignore | 8 -
> libmthca/configure.in | 82 -
> libmthca/mthca.driver | 1 -
> libmthca/src/mthca.map | 5 -
> libnes/Makefile.am | 26 -
> libnes/autogen.sh | 12 -
> libnes/config/.gitignore | 0
> libnes/configure.in | 74 -
> libnes/nes.driver | 1 -
> libnes/src/nes.map | 5 -
> libocrdma/Makefile.am | 23 -
> libocrdma/autogen.sh | 8 -
> libocrdma/config/.gitignore | 8 -
> libocrdma/configure.in | 70 -
> libocrdma/ocrdma.driver | 1 -
> libocrdma/src/ocrdma.map | 5 -
> librdmacm/INSTALL | 0
> librdmacm/Makefile.am | 141 -
> librdmacm/NEWS | 0
> librdmacm/autogen.sh | 5 -
> librdmacm/configure.ac | 108 -
> librxe/AUTHORS | 0
> librxe/COPYING | 0
> librxe/INSTALL | 0
> librxe/Makefile.am | 36 -
> librxe/Makefile.in | 939 ---
> librxe/NEWS | 0
> librxe/README | 0
> librxe/aclocal.m4 | 9390 ----------------------
> librxe/config.h.in | 89 -
> librxe/config/config.guess | 1526 ----
> librxe/config/config.sub | 1658 ----
> librxe/config/depcomp | 530 --
> librxe/config/install-sh | 519 --
> librxe/config/ltmain.sh | 9636 ----------------------
> librxe/config/missing | 360 -
> librxe/configure | 14728 ----------------------------------
> librxe/configure.in | 77 -
> librxe/librxe.spec | 55 -
> librxe/rxe.driver | 1 -
> librxe/src/rxe.map | 5 -
> srp_daemon/Makefile.am | 80 -
> srp_daemon/autogen.sh | 7 -
> srp_daemon/build-deb.sh | 68 -
> srp_daemon/configure.ac | 73 -
> 113 files changed, 46792 deletions(-)
> delete mode 100644 ibacm/INSTALL
> delete mode 100644 ibacm/Makefile.am
> delete mode 100644 ibacm/NEWS
> delete mode 100644 ibacm/README
> delete mode 100755 ibacm/autogen.sh
> delete mode 100644 ibacm/configure.ac
> delete mode 100644 iwpmd/Makefile.am
> delete mode 100644 iwpmd/NEWS
> delete mode 100755 iwpmd/autogen.sh
> delete mode 100644 iwpmd/configure.ac
> delete mode 100644 libcxgb3/Makefile.am
> delete mode 100755 libcxgb3/autogen.sh
> delete mode 100644 libcxgb3/config/.gitignore
> delete mode 100644 libcxgb3/configure.in
> delete mode 100644 libcxgb3/cxgb3.driver
> delete mode 100644 libcxgb3/src/iwch.map
> delete mode 100644 libcxgb4/Makefile.am
> delete mode 100755 libcxgb4/autogen.sh
> delete mode 100755 libcxgb4/config/config.guess
> delete mode 100755 libcxgb4/config/config.sub
> delete mode 100755 libcxgb4/config/depcomp
> delete mode 100755 libcxgb4/config/install-sh
> delete mode 100644 libcxgb4/configure.in
> delete mode 100644 libcxgb4/cxgb4.driver
> delete mode 100644 libcxgb4/src/cxgb4.map
> delete mode 100644 libhfi1verbs/Makefile.am
> delete mode 100755 libhfi1verbs/autogen.sh
> delete mode 100644 libhfi1verbs/configure.in
> delete mode 100644 libhfi1verbs/hfi1verbs.driver
> delete mode 100644 libhfi1verbs/makefile
> delete mode 100644 libhfi1verbs/makesrpm.sh
> delete mode 100644 libhfi1verbs/src/hfiverbs.map
> delete mode 100644 libi40iw/Makefile.am
> delete mode 100644 libi40iw/configure.ac
> delete mode 100644 libi40iw/i40iw.driver
> delete mode 100644 libi40iw/src/i40iw.map
> delete mode 100644 libibcm/INSTALL
> delete mode 100644 libibcm/Makefile.am
> delete mode 100644 libibcm/NEWS
> delete mode 100755 libibcm/autogen.sh
> delete mode 100644 libibcm/configure.in
> delete mode 100644 libibumad/Makefile.am
> delete mode 100755 libibumad/autogen.sh
> delete mode 100644 libibumad/configure.in
> delete mode 100644 libibverbs/Makefile.am
> delete mode 100755 libibverbs/autogen.sh
> delete mode 100644 libibverbs/config/.gitignore
> delete mode 100644 libibverbs/configure.ac
> delete mode 100644 libipathverbs/Makefile.am
> delete mode 100755 libipathverbs/autogen.sh
> delete mode 100644 libipathverbs/configure.in
> delete mode 100644 libipathverbs/ipathverbs.driver
> delete mode 100644 libipathverbs/src/ipathverbs.map
> delete mode 100644 libmlx4/Makefile.am
> delete mode 100755 libmlx4/autogen.sh
> delete mode 100644 libmlx4/config/.gitignore
> delete mode 100644 libmlx4/configure.ac
> delete mode 100644 libmlx4/mlx4.driver
> delete mode 100644 libmlx4/src/mlx4.map
> delete mode 100644 libmlx5/Makefile.am
> delete mode 100755 libmlx5/autogen.sh
> delete mode 100644 libmlx5/config/.gitignore
> delete mode 100644 libmlx5/configure.ac
> delete mode 100644 libmlx5/m4/ax_gcc_func_attribute.m4
> delete mode 100644 libmlx5/mlx5.driver
> delete mode 100644 libmlx5/src/mlx5.map
> delete mode 100644 libmthca/Makefile.am
> delete mode 100755 libmthca/autogen.sh
> delete mode 100644 libmthca/config/.gitignore
> delete mode 100644 libmthca/configure.in
> delete mode 100644 libmthca/mthca.driver
> delete mode 100644 libmthca/src/mthca.map
> delete mode 100644 libnes/Makefile.am
> delete mode 100755 libnes/autogen.sh
> delete mode 100644 libnes/config/.gitignore
> delete mode 100644 libnes/configure.in
> delete mode 100644 libnes/nes.driver
> delete mode 100644 libnes/src/nes.map
> delete mode 100644 libocrdma/Makefile.am
> delete mode 100644 libocrdma/autogen.sh
> delete mode 100644 libocrdma/config/.gitignore
> delete mode 100644 libocrdma/configure.in
> delete mode 100644 libocrdma/ocrdma.driver
> delete mode 100644 libocrdma/src/ocrdma.map
> delete mode 100644 librdmacm/INSTALL
> delete mode 100644 librdmacm/Makefile.am
> delete mode 100644 librdmacm/NEWS
> delete mode 100755 librdmacm/autogen.sh
> delete mode 100644 librdmacm/configure.ac
> delete mode 100644 librxe/AUTHORS
> delete mode 100644 librxe/COPYING
> delete mode 100644 librxe/INSTALL
> delete mode 100644 librxe/Makefile.am
> delete mode 100644 librxe/Makefile.in
> delete mode 100644 librxe/NEWS
> delete mode 100644 librxe/README
> delete mode 100644 librxe/aclocal.m4
> delete mode 100644 librxe/config.h.in
> delete mode 100755 librxe/config/config.guess
> delete mode 100755 librxe/config/config.sub
> delete mode 100755 librxe/config/depcomp
> delete mode 100755 librxe/config/install-sh
> delete mode 100755 librxe/config/ltmain.sh
> delete mode 100755 librxe/config/missing
> delete mode 100755 librxe/configure
> delete mode 100644 librxe/configure.in
> delete mode 100644 librxe/librxe.spec
> delete mode 100644 librxe/rxe.driver
> delete mode 100644 librxe/src/rxe.map
> delete mode 100644 srp_daemon/Makefile.am
> delete mode 100755 srp_daemon/autogen.sh
> delete mode 100755 srp_daemon/build-deb.sh
> delete mode 100644 srp_daemon/configure.ac
>
> diff --git a/ibacm/INSTALL b/ibacm/INSTALL
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/ibacm/Makefile.am b/ibacm/Makefile.am
> deleted file mode 100644
> index c5cdc6905714..000000000000
> diff --git a/ibacm/NEWS b/ibacm/NEWS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/ibacm/README b/ibacm/README
> deleted file mode 100644
> index d7868280a500..000000000000
> diff --git a/ibacm/autogen.sh b/ibacm/autogen.sh
> deleted file mode 100755
> index 24c0a769be34..000000000000
> diff --git a/ibacm/configure.ac b/ibacm/configure.ac
> deleted file mode 100644
> index 3a05bf0b3eb2..000000000000
> diff --git a/iwpmd/Makefile.am b/iwpmd/Makefile.am
> deleted file mode 100644
> index fbb4334da961..000000000000
> diff --git a/iwpmd/NEWS b/iwpmd/NEWS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/iwpmd/autogen.sh b/iwpmd/autogen.sh
> deleted file mode 100755
> index 6abb4f8446bd..000000000000
> diff --git a/iwpmd/configure.ac b/iwpmd/configure.ac
> deleted file mode 100644
> index 5d5388ba2ed9..000000000000
> diff --git a/libcxgb3/Makefile.am b/libcxgb3/Makefile.am
> deleted file mode 100644
> index 99f1cae08531..000000000000
> diff --git a/libcxgb3/autogen.sh b/libcxgb3/autogen.sh
> deleted file mode 100755
> index fd47839cae8c..000000000000
> diff --git a/libcxgb3/config/.gitignore b/libcxgb3/config/.gitignore
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/libcxgb3/configure.in b/libcxgb3/configure.in
> deleted file mode 100644
> index cc254a6e5d8d..000000000000
> diff --git a/libcxgb3/cxgb3.driver b/libcxgb3/cxgb3.driver
> deleted file mode 100644
> index cfa6186bf714..000000000000
> diff --git a/libcxgb3/src/iwch.map b/libcxgb3/src/iwch.map
> deleted file mode 100644
> index 59a8baead48f..000000000000
> diff --git a/libcxgb4/Makefile.am b/libcxgb4/Makefile.am
> deleted file mode 100644
> index f75d9641ce12..000000000000
> diff --git a/libcxgb4/autogen.sh b/libcxgb4/autogen.sh
> deleted file mode 100755
> index fd47839cae8c..000000000000
> diff --git a/libcxgb4/config/config.guess b/libcxgb4/config/config.guess
> deleted file mode 100755
> index 61754411ea95..000000000000
> diff --git a/libcxgb4/config/config.sub b/libcxgb4/config/config.sub
> deleted file mode 100755
> index 16cd209d75ed..000000000000
> diff --git a/libcxgb4/config/depcomp b/libcxgb4/config/depcomp
> deleted file mode 100755
> index 04701da536f3..000000000000
> diff --git a/libcxgb4/config/install-sh b/libcxgb4/config/install-sh
> deleted file mode 100755
> index 4d4a9519eaf8..000000000000
> diff --git a/libcxgb4/configure.in b/libcxgb4/configure.in
> deleted file mode 100644
> index 2bb930399a3e..000000000000
> diff --git a/libcxgb4/cxgb4.driver b/libcxgb4/cxgb4.driver
> deleted file mode 100644
> index e041cb24c610..000000000000
> diff --git a/libcxgb4/src/cxgb4.map b/libcxgb4/src/cxgb4.map
> deleted file mode 100644
> index 59a8baead48f..000000000000
> diff --git a/libhfi1verbs/Makefile.am b/libhfi1verbs/Makefile.am
> deleted file mode 100644
> index 135e2a2f3ec0..000000000000
> diff --git a/libhfi1verbs/autogen.sh b/libhfi1verbs/autogen.sh
> deleted file mode 100755
> index 738b034eb59a..000000000000
> diff --git a/libhfi1verbs/configure.in b/libhfi1verbs/configure.in
> deleted file mode 100644
> index a8218914f53f..000000000000
> diff --git a/libhfi1verbs/hfi1verbs.driver b/libhfi1verbs/hfi1verbs.driver
> deleted file mode 100644
> index 3ceb7ee85afb..000000000000
> diff --git a/libhfi1verbs/makefile b/libhfi1verbs/makefile
> deleted file mode 100644
> index 000e123aa70c..000000000000
> diff --git a/libhfi1verbs/makesrpm.sh b/libhfi1verbs/makesrpm.sh
> deleted file mode 100644
> index eedc578a71e4..000000000000
> diff --git a/libhfi1verbs/src/hfiverbs.map b/libhfi1verbs/src/hfiverbs.map
> deleted file mode 100644
> index d3517dd0f59b..000000000000
> diff --git a/libi40iw/Makefile.am b/libi40iw/Makefile.am
> deleted file mode 100644
> index 98d6f8ae1226..000000000000
> diff --git a/libi40iw/configure.ac b/libi40iw/configure.ac
> deleted file mode 100644
> index 108ffd5999b9..000000000000
> diff --git a/libi40iw/i40iw.driver b/libi40iw/i40iw.driver
> deleted file mode 100644
> index 7dab2f03b9e9..000000000000
> diff --git a/libi40iw/src/i40iw.map b/libi40iw/src/i40iw.map
> deleted file mode 100644
> index 112420a1d1c1..000000000000
> diff --git a/libibcm/INSTALL b/libibcm/INSTALL
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/libibcm/Makefile.am b/libibcm/Makefile.am
> deleted file mode 100644
> index ff0b1ded12a3..000000000000
> diff --git a/libibcm/NEWS b/libibcm/NEWS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/libibcm/autogen.sh b/libibcm/autogen.sh
> deleted file mode 100755
> index f433312161d2..000000000000
> diff --git a/libibcm/configure.in b/libibcm/configure.in
> deleted file mode 100644
> index 145e3a4cebf2..000000000000
> diff --git a/libibumad/Makefile.am b/libibumad/Makefile.am
> deleted file mode 100644
> index 1dddf7bb2ffd..000000000000
> diff --git a/libibumad/autogen.sh b/libibumad/autogen.sh
> deleted file mode 100755
> index 4827884ba1f1..000000000000
> diff --git a/libibumad/configure.in b/libibumad/configure.in
> deleted file mode 100644
> index 0b2794baad40..000000000000
> diff --git a/libibverbs/Makefile.am b/libibverbs/Makefile.am
> deleted file mode 100644
> index 1361e96feb7d..000000000000
> diff --git a/libibverbs/autogen.sh b/libibverbs/autogen.sh
> deleted file mode 100755
> index 6c9233e01a60..000000000000
> diff --git a/libibverbs/config/.gitignore b/libibverbs/config/.gitignore
> deleted file mode 100644
> index 4d4c7b1710b0..000000000000
> diff --git a/libibverbs/configure.ac b/libibverbs/configure.ac
> deleted file mode 100644
> index a8046f3c5a72..000000000000
> diff --git a/libipathverbs/Makefile.am b/libipathverbs/Makefile.am
> deleted file mode 100644
> index 4d3e9258d989..000000000000
> diff --git a/libipathverbs/autogen.sh b/libipathverbs/autogen.sh
> deleted file mode 100755
> index 493c586fdef7..000000000000
> diff --git a/libipathverbs/configure.in b/libipathverbs/configure.in
> deleted file mode 100644
> index 9718d56e4411..000000000000
> diff --git a/libipathverbs/ipathverbs.driver b/libipathverbs/ipathverbs.driver
> deleted file mode 100644
> index d2125786170b..000000000000
> diff --git a/libipathverbs/src/ipathverbs.map b/libipathverbs/src/ipathverbs.map
> deleted file mode 100644
> index d3517dd0f59b..000000000000
> diff --git a/libmlx4/Makefile.am b/libmlx4/Makefile.am
> deleted file mode 100644
> index 9bb90e964fe9..000000000000
> diff --git a/libmlx4/autogen.sh b/libmlx4/autogen.sh
> deleted file mode 100755
> index 6c9233e01a60..000000000000
> diff --git a/libmlx4/config/.gitignore b/libmlx4/config/.gitignore
> deleted file mode 100644
> index 4d4c7b1710b0..000000000000
> diff --git a/libmlx4/configure.ac b/libmlx4/configure.ac
> deleted file mode 100644
> index 4a500c3f4885..000000000000
> diff --git a/libmlx4/mlx4.driver b/libmlx4/mlx4.driver
> deleted file mode 100644
> index 4d29fa818afe..000000000000
> diff --git a/libmlx4/src/mlx4.map b/libmlx4/src/mlx4.map
> deleted file mode 100644
> index ae8ed861f956..000000000000
> diff --git a/libmlx5/Makefile.am b/libmlx5/Makefile.am
> deleted file mode 100644
> index 345d5afbcfee..000000000000
> diff --git a/libmlx5/autogen.sh b/libmlx5/autogen.sh
> deleted file mode 100755
> index b0ad85eb4cb9..000000000000
> diff --git a/libmlx5/config/.gitignore b/libmlx5/config/.gitignore
> deleted file mode 100644
> index 4d4c7b1710b0..000000000000
> diff --git a/libmlx5/configure.ac b/libmlx5/configure.ac
> deleted file mode 100644
> index dca7c81a88ce..000000000000
> diff --git a/libmlx5/m4/ax_gcc_func_attribute.m4 b/libmlx5/m4/ax_gcc_func_attribute.m4
> deleted file mode 100644
> index c788ca9bd435..000000000000
> diff --git a/libmlx5/mlx5.driver b/libmlx5/mlx5.driver
> deleted file mode 100644
> index 5190aa59ab50..000000000000
> diff --git a/libmlx5/src/mlx5.map b/libmlx5/src/mlx5.map
> deleted file mode 100644
> index ae8ed861f956..000000000000
> diff --git a/libmthca/Makefile.am b/libmthca/Makefile.am
> deleted file mode 100644
> index 1dd9a7ba8601..000000000000
> diff --git a/libmthca/autogen.sh b/libmthca/autogen.sh
> deleted file mode 100755
> index fd47839cae8c..000000000000
> diff --git a/libmthca/config/.gitignore b/libmthca/config/.gitignore
> deleted file mode 100644
> index 4d4c7b1710b0..000000000000
> diff --git a/libmthca/configure.in b/libmthca/configure.in
> deleted file mode 100644
> index c5454436bf8f..000000000000
> diff --git a/libmthca/mthca.driver b/libmthca/mthca.driver
> deleted file mode 100644
> index 5880a477f9c4..000000000000
> diff --git a/libmthca/src/mthca.map b/libmthca/src/mthca.map
> deleted file mode 100644
> index ae8ed861f956..000000000000
> diff --git a/libnes/Makefile.am b/libnes/Makefile.am
> deleted file mode 100644
> index ade8e8b1eee8..000000000000
> diff --git a/libnes/autogen.sh b/libnes/autogen.sh
> deleted file mode 100755
> index 1e486f86b880..000000000000
> diff --git a/libnes/config/.gitignore b/libnes/config/.gitignore
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/libnes/configure.in b/libnes/configure.in
> deleted file mode 100644
> index 08e9948ed13c..000000000000
> diff --git a/libnes/nes.driver b/libnes/nes.driver
> deleted file mode 100644
> index 1d8d85d51758..000000000000
> diff --git a/libnes/src/nes.map b/libnes/src/nes.map
> deleted file mode 100644
> index ae8ed861f956..000000000000
> diff --git a/libocrdma/Makefile.am b/libocrdma/Makefile.am
> deleted file mode 100644
> index 9b786e2b51a4..000000000000
> diff --git a/libocrdma/autogen.sh b/libocrdma/autogen.sh
> deleted file mode 100644
> index fd47839cae8c..000000000000
> diff --git a/libocrdma/config/.gitignore b/libocrdma/config/.gitignore
> deleted file mode 100644
> index 4d4c7b1710b0..000000000000
> diff --git a/libocrdma/configure.in b/libocrdma/configure.in
> deleted file mode 100644
> index 659d79f52f25..000000000000
> diff --git a/libocrdma/ocrdma.driver b/libocrdma/ocrdma.driver
> deleted file mode 100644
> index dead9f84707e..000000000000
> diff --git a/libocrdma/src/ocrdma.map b/libocrdma/src/ocrdma.map
> deleted file mode 100644
> index ae8ed861f956..000000000000
> diff --git a/librdmacm/INSTALL b/librdmacm/INSTALL
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librdmacm/Makefile.am b/librdmacm/Makefile.am
> deleted file mode 100644
> index edfb36bb4149..000000000000
> diff --git a/librdmacm/NEWS b/librdmacm/NEWS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librdmacm/autogen.sh b/librdmacm/autogen.sh
> deleted file mode 100755
> index 24c0a769be34..000000000000
> diff --git a/librdmacm/configure.ac b/librdmacm/configure.ac
> deleted file mode 100644
> index 4a43995f317c..000000000000
> diff --git a/librxe/AUTHORS b/librxe/AUTHORS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librxe/COPYING b/librxe/COPYING
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librxe/INSTALL b/librxe/INSTALL
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librxe/Makefile.am b/librxe/Makefile.am
> deleted file mode 100644
> index 972ae3b390b7..000000000000
> diff --git a/librxe/Makefile.in b/librxe/Makefile.in
> deleted file mode 100644
> index aa536082e9ef..000000000000
> diff --git a/librxe/NEWS b/librxe/NEWS
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librxe/README b/librxe/README
> deleted file mode 100644
> index e69de29bb2d1..000000000000
> diff --git a/librxe/aclocal.m4 b/librxe/aclocal.m4
> deleted file mode 100644
> index 4ccc6e2225b5..000000000000
> diff --git a/librxe/config.h.in b/librxe/config.h.in
> deleted file mode 100644
> index eda71c5b3524..000000000000
> diff --git a/librxe/config/config.guess b/librxe/config/config.guess
> deleted file mode 100755
> index f32079abda66..000000000000
> diff --git a/librxe/config/config.sub b/librxe/config/config.sub
> deleted file mode 100755
> index 6759825a5b7f..000000000000
> diff --git a/librxe/config/depcomp b/librxe/config/depcomp
> deleted file mode 100755
> index 04701da536f3..000000000000
> diff --git a/librxe/config/install-sh b/librxe/config/install-sh
> deleted file mode 100755
> index a5897de6ea7f..000000000000
> diff --git a/librxe/config/ltmain.sh b/librxe/config/ltmain.sh
> deleted file mode 100755
> index 3061e3c5a2f7..000000000000
> diff --git a/librxe/config/missing b/librxe/config/missing
> deleted file mode 100755
> index 894e786e16c1..000000000000
> diff --git a/librxe/configure b/librxe/configure
> deleted file mode 100755
> index a2af18f879ef..000000000000
> diff --git a/librxe/configure.in b/librxe/configure.in
> deleted file mode 100644
> index 957d65000704..000000000000
> diff --git a/librxe/librxe.spec b/librxe/librxe.spec
> deleted file mode 100644
> index 7f65163c1079..000000000000
> diff --git a/librxe/rxe.driver b/librxe/rxe.driver
> deleted file mode 100644
> index ed63053225fd..000000000000
> diff --git a/librxe/src/rxe.map b/librxe/src/rxe.map
> deleted file mode 100644
> index 710d82708fd1..000000000000
> diff --git a/srp_daemon/Makefile.am b/srp_daemon/Makefile.am
> deleted file mode 100644
> index 7efea9d6d506..000000000000
> diff --git a/srp_daemon/autogen.sh b/srp_daemon/autogen.sh
> deleted file mode 100755
> index 3dd3326f43f8..000000000000
> diff --git a/srp_daemon/build-deb.sh b/srp_daemon/build-deb.sh
> deleted file mode 100755
> index 481fa1895623..000000000000
> diff --git a/srp_daemon/configure.ac b/srp_daemon/configure.ac
> deleted file mode 100644
> index c3ce076fdee5..000000000000
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 13/16] Remove Debian and RPM packaging files
From: Yishai Hadas @ 2016-09-21 14:00 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, alaa-VPRAkNaXOzVWk0Htik3J/w,
yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Leon Romanovsky,
Doug Ledford
In-Reply-To: <1474409425-15769-14-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On 9/21/2016 1:10 AM, Jason Gunthorpe wrote:
> These no longer apply to the combined build.
Taking this patch without introducing an alternative leaves the system
without an option to build RPMs as it removes all packaging files.
What is the plan here ?
In addition, did we come to a decision re having RPM per component ?
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
> ibacm/ibacm.spec.in | 90 -----
> iwpmd/iwpmd.spec.in | 127 -------
> libcxgb3/libcxgb3.spec.in | 55 ---
> libcxgb4/libcxgb4.spec.in | 55 ---
> libhfi1verbs/libhfi1.spec.in | 109 ------
> libi40iw/libi40iw.spec.in | 72 ----
> libibcm/libibcm.spec.in | 53 ---
> libibumad/libibumad.spec.in | 74 ----
> libibverbs/debian/changelog | 139 --------
> libibverbs/debian/compat | 1 -
> libibverbs/debian/control | 80 -----
> libibverbs/debian/copyright | 49 ---
> libibverbs/debian/ibverbs-utils.install | 2 -
> libibverbs/debian/libibverbs-dev.install | 4 -
> libibverbs/debian/libibverbs-dev.links | 16 -
> libibverbs/debian/libibverbs1.install | 1 -
> libibverbs/debian/libibverbs1.postinst | 10 -
> libibverbs/debian/rules | 11 -
> libibverbs/debian/source/format | 1 -
> libibverbs/debian/watch | 3 -
> libibverbs/libibverbs.spec.in | 169 ---------
> libipathverbs/libipathverbs.spec.in | 104 ------
> libmlx4/debian/changelog | 73 ----
> libmlx4/debian/compat | 1 -
> libmlx4/debian/control | 47 ---
> libmlx4/debian/copyright | 43 ---
> libmlx4/debian/libmlx4-1.install | 2 -
> libmlx4/debian/libmlx4-dev.install | 1 -
> .../debian/patches/driver-plugin-directory.patch | 10 -
> libmlx4/debian/patches/series | 1 -
> libmlx4/debian/rules | 10 -
> libmlx4/debian/source/format | 1 -
> libmlx4/debian/watch | 3 -
> libmlx4/libmlx4.spec.in | 90 -----
> libmlx5/debian/changelog | 18 -
> libmlx5/debian/compat | 1 -
> libmlx5/debian/control | 47 ---
> libmlx5/debian/copyright | 43 ---
> libmlx5/debian/libmlx5-1.install | 2 -
> libmlx5/debian/libmlx5-dev.install | 1 -
> .../debian/patches/driver-plugin-directory.patch | 10 -
> libmlx5/debian/patches/series | 1 -
> libmlx5/debian/rules | 10 -
> libmlx5/debian/source/format | 1 -
> libmlx5/debian/watch | 3 -
> libmlx5/libmlx5.spec.in | 60 ----
> libmthca/debian/changelog | 73 ----
> libmthca/debian/compat | 1 -
> libmthca/debian/control | 48 ---
> libmthca/debian/copyright | 44 ---
> libmthca/debian/libmthca-dev.install | 1 -
> libmthca/debian/libmthca1.install | 2 -
> .../debian/patches/driver-plugin-directory.patch | 10 -
> libmthca/debian/patches/series | 1 -
> libmthca/debian/rules | 10 -
> libmthca/debian/source/format | 1 -
> libmthca/debian/watch | 3 -
> libmthca/libmthca.spec.in | 97 ------
> libnes/libnes.spec.in | 107 ------
> libocrdma/libocrdma.spec.in | 71 ----
> librdmacm/librdmacm.spec.in | 79 -----
> librxe/librxe.spec.in | 55 ---
> srp_daemon/debian/changelog | 11 -
> srp_daemon/debian/compat | 1 -
> srp_daemon/debian/control | 14 -
> srp_daemon/debian/copyright | 376 ---------------------
> srp_daemon/debian/postinst | 26 --
> srp_daemon/debian/prerm | 11 -
> srp_daemon/debian/rules | 14 -
> srp_daemon/debian/source/format | 1 -
> srp_daemon/srptools.spec.in | 141 --------
> 71 files changed, 2902 deletions(-)
> delete mode 100644 ibacm/ibacm.spec.in
> delete mode 100644 iwpmd/iwpmd.spec.in
> delete mode 100644 libcxgb3/libcxgb3.spec.in
> delete mode 100644 libcxgb4/libcxgb4.spec.in
> delete mode 100644 libhfi1verbs/libhfi1.spec.in
> delete mode 100644 libi40iw/libi40iw.spec.in
> delete mode 100644 libibcm/libibcm.spec.in
> delete mode 100644 libibumad/libibumad.spec.in
> delete mode 100644 libibverbs/debian/changelog
> delete mode 100644 libibverbs/debian/compat
> delete mode 100644 libibverbs/debian/control
> delete mode 100644 libibverbs/debian/copyright
> delete mode 100644 libibverbs/debian/ibverbs-utils.install
> delete mode 100644 libibverbs/debian/libibverbs-dev.install
> delete mode 100644 libibverbs/debian/libibverbs-dev.links
> delete mode 100644 libibverbs/debian/libibverbs1.install
> delete mode 100644 libibverbs/debian/libibverbs1.postinst
> delete mode 100755 libibverbs/debian/rules
> delete mode 100644 libibverbs/debian/source/format
> delete mode 100644 libibverbs/debian/watch
> delete mode 100644 libibverbs/libibverbs.spec.in
> delete mode 100644 libipathverbs/libipathverbs.spec.in
> delete mode 100644 libmlx4/debian/changelog
> delete mode 100644 libmlx4/debian/compat
> delete mode 100644 libmlx4/debian/control
> delete mode 100644 libmlx4/debian/copyright
> delete mode 100644 libmlx4/debian/libmlx4-1.install
> delete mode 100644 libmlx4/debian/libmlx4-dev.install
> delete mode 100644 libmlx4/debian/patches/driver-plugin-directory.patch
> delete mode 100644 libmlx4/debian/patches/series
> delete mode 100755 libmlx4/debian/rules
> delete mode 100644 libmlx4/debian/source/format
> delete mode 100644 libmlx4/debian/watch
> delete mode 100644 libmlx4/libmlx4.spec.in
> delete mode 100644 libmlx5/debian/changelog
> delete mode 100644 libmlx5/debian/compat
> delete mode 100644 libmlx5/debian/control
> delete mode 100644 libmlx5/debian/copyright
> delete mode 100644 libmlx5/debian/libmlx5-1.install
> delete mode 100644 libmlx5/debian/libmlx5-dev.install
> delete mode 100644 libmlx5/debian/patches/driver-plugin-directory.patch
> delete mode 100644 libmlx5/debian/patches/series
> delete mode 100755 libmlx5/debian/rules
> delete mode 100644 libmlx5/debian/source/format
> delete mode 100644 libmlx5/debian/watch
> delete mode 100644 libmlx5/libmlx5.spec.in
> delete mode 100644 libmthca/debian/changelog
> delete mode 100644 libmthca/debian/compat
> delete mode 100644 libmthca/debian/control
> delete mode 100644 libmthca/debian/copyright
> delete mode 100644 libmthca/debian/libmthca-dev.install
> delete mode 100644 libmthca/debian/libmthca1.install
> delete mode 100644 libmthca/debian/patches/driver-plugin-directory.patch
> delete mode 100644 libmthca/debian/patches/series
> delete mode 100755 libmthca/debian/rules
> delete mode 100644 libmthca/debian/source/format
> delete mode 100644 libmthca/debian/watch
> delete mode 100644 libmthca/libmthca.spec.in
> delete mode 100644 libnes/libnes.spec.in
> delete mode 100644 libocrdma/libocrdma.spec.in
> delete mode 100644 librdmacm/librdmacm.spec.in
> delete mode 100644 librxe/librxe.spec.in
> delete mode 100644 srp_daemon/debian/changelog
> delete mode 100644 srp_daemon/debian/compat
> delete mode 100644 srp_daemon/debian/control
> delete mode 100644 srp_daemon/debian/copyright
> delete mode 100644 srp_daemon/debian/postinst
> delete mode 100644 srp_daemon/debian/prerm
> delete mode 100755 srp_daemon/debian/rules
> delete mode 100644 srp_daemon/debian/source/format
> delete mode 100644 srp_daemon/srptools.spec.in
>
> diff --git a/ibacm/ibacm.spec.in b/ibacm/ibacm.spec.in
> deleted file mode 100644
> index bc337e213516..000000000000
> diff --git a/iwpmd/iwpmd.spec.in b/iwpmd/iwpmd.spec.in
> deleted file mode 100644
> index b00dab0a123e..000000000000
> diff --git a/libcxgb3/libcxgb3.spec.in b/libcxgb3/libcxgb3.spec.in
> deleted file mode 100644
> index 1ae72d793111..000000000000
> diff --git a/libcxgb4/libcxgb4.spec.in b/libcxgb4/libcxgb4.spec.in
> deleted file mode 100644
> index 6b4294468cf0..000000000000
> diff --git a/libhfi1verbs/libhfi1.spec.in b/libhfi1verbs/libhfi1.spec.in
> deleted file mode 100644
> index c6a11ee2a450..000000000000
> diff --git a/libi40iw/libi40iw.spec.in b/libi40iw/libi40iw.spec.in
> deleted file mode 100644
> index 4e794fa1898c..000000000000
> diff --git a/libibcm/libibcm.spec.in b/libibcm/libibcm.spec.in
> deleted file mode 100644
> index ce082726e7dc..000000000000
> diff --git a/libibumad/libibumad.spec.in b/libibumad/libibumad.spec.in
> deleted file mode 100644
> index b01757ff0ef3..000000000000
> diff --git a/libibverbs/debian/changelog b/libibverbs/debian/changelog
> deleted file mode 100644
> index 3ae7711648ce..000000000000
> diff --git a/libibverbs/debian/compat b/libibverbs/debian/compat
> deleted file mode 100644
> index 7f8f011eb73d..000000000000
> diff --git a/libibverbs/debian/control b/libibverbs/debian/control
> deleted file mode 100644
> index a26b75c2aea1..000000000000
> diff --git a/libibverbs/debian/copyright b/libibverbs/debian/copyright
> deleted file mode 100644
> index 5009e7a6039e..000000000000
> diff --git a/libibverbs/debian/ibverbs-utils.install b/libibverbs/debian/ibverbs-utils.install
> deleted file mode 100644
> index 98d15831b4c5..000000000000
> diff --git a/libibverbs/debian/libibverbs-dev.install b/libibverbs/debian/libibverbs-dev.install
> deleted file mode 100644
> index b4c75ce6f1c3..000000000000
> diff --git a/libibverbs/debian/libibverbs-dev.links b/libibverbs/debian/libibverbs-dev.links
> deleted file mode 100644
> index 702902885798..000000000000
> diff --git a/libibverbs/debian/libibverbs1.install b/libibverbs/debian/libibverbs1.install
> deleted file mode 100644
> index 0f3523db5354..000000000000
> diff --git a/libibverbs/debian/libibverbs1.postinst b/libibverbs/debian/libibverbs1.postinst
> deleted file mode 100644
> index 784458a6e0b5..000000000000
> diff --git a/libibverbs/debian/rules b/libibverbs/debian/rules
> deleted file mode 100755
> index 205a8b75e47e..000000000000
> diff --git a/libibverbs/debian/source/format b/libibverbs/debian/source/format
> deleted file mode 100644
> index 163aaf8d82b6..000000000000
> diff --git a/libibverbs/debian/watch b/libibverbs/debian/watch
> deleted file mode 100644
> index eff271adabca..000000000000
> diff --git a/libibverbs/libibverbs.spec.in b/libibverbs/libibverbs.spec.in
> deleted file mode 100644
> index 040948efce17..000000000000
> diff --git a/libipathverbs/libipathverbs.spec.in b/libipathverbs/libipathverbs.spec.in
> deleted file mode 100644
> index d029696d70ef..000000000000
> diff --git a/libmlx4/debian/changelog b/libmlx4/debian/changelog
> deleted file mode 100644
> index ec7ba21e0573..000000000000
> diff --git a/libmlx4/debian/compat b/libmlx4/debian/compat
> deleted file mode 100644
> index 7f8f011eb73d..000000000000
> diff --git a/libmlx4/debian/control b/libmlx4/debian/control
> deleted file mode 100644
> index ab08e00e4eeb..000000000000
> diff --git a/libmlx4/debian/copyright b/libmlx4/debian/copyright
> deleted file mode 100644
> index db07a25fcbf1..000000000000
> diff --git a/libmlx4/debian/libmlx4-1.install b/libmlx4/debian/libmlx4-1.install
> deleted file mode 100644
> index 8cab406b098d..000000000000
> diff --git a/libmlx4/debian/libmlx4-dev.install b/libmlx4/debian/libmlx4-dev.install
> deleted file mode 100644
> index 8f70e5214388..000000000000
> diff --git a/libmlx4/debian/patches/driver-plugin-directory.patch b/libmlx4/debian/patches/driver-plugin-directory.patch
> deleted file mode 100644
> index fd73a739f424..000000000000
> diff --git a/libmlx4/debian/patches/series b/libmlx4/debian/patches/series
> deleted file mode 100644
> index 213f49e4c278..000000000000
> diff --git a/libmlx4/debian/rules b/libmlx4/debian/rules
> deleted file mode 100755
> index 9d15bec7c2a8..000000000000
> diff --git a/libmlx4/debian/source/format b/libmlx4/debian/source/format
> deleted file mode 100644
> index 163aaf8d82b6..000000000000
> diff --git a/libmlx4/debian/watch b/libmlx4/debian/watch
> deleted file mode 100644
> index 06bae51d7eb3..000000000000
> diff --git a/libmlx4/libmlx4.spec.in b/libmlx4/libmlx4.spec.in
> deleted file mode 100644
> index 3c93122b5a02..000000000000
> diff --git a/libmlx5/debian/changelog b/libmlx5/debian/changelog
> deleted file mode 100644
> index f43b43f41dfd..000000000000
> diff --git a/libmlx5/debian/compat b/libmlx5/debian/compat
> deleted file mode 100644
> index 7f8f011eb73d..000000000000
> diff --git a/libmlx5/debian/control b/libmlx5/debian/control
> deleted file mode 100644
> index 0aceae4a25ae..000000000000
> diff --git a/libmlx5/debian/copyright b/libmlx5/debian/copyright
> deleted file mode 100644
> index db07a25fcbf1..000000000000
> diff --git a/libmlx5/debian/libmlx5-1.install b/libmlx5/debian/libmlx5-1.install
> deleted file mode 100644
> index 1af89543be5a..000000000000
> diff --git a/libmlx5/debian/libmlx5-dev.install b/libmlx5/debian/libmlx5-dev.install
> deleted file mode 100644
> index 7de9fbe4978b..000000000000
> diff --git a/libmlx5/debian/patches/driver-plugin-directory.patch b/libmlx5/debian/patches/driver-plugin-directory.patch
> deleted file mode 100644
> index 91eb0482b3bb..000000000000
> diff --git a/libmlx5/debian/patches/series b/libmlx5/debian/patches/series
> deleted file mode 100644
> index 213f49e4c278..000000000000
> diff --git a/libmlx5/debian/rules b/libmlx5/debian/rules
> deleted file mode 100755
> index c8a46746512a..000000000000
> diff --git a/libmlx5/debian/source/format b/libmlx5/debian/source/format
> deleted file mode 100644
> index 163aaf8d82b6..000000000000
> diff --git a/libmlx5/debian/watch b/libmlx5/debian/watch
> deleted file mode 100644
> index cf13e694b2f8..000000000000
> diff --git a/libmlx5/libmlx5.spec.in b/libmlx5/libmlx5.spec.in
> deleted file mode 100644
> index 8c73c40fea39..000000000000
> diff --git a/libmthca/debian/changelog b/libmthca/debian/changelog
> deleted file mode 100644
> index d106ed76b49a..000000000000
> diff --git a/libmthca/debian/compat b/libmthca/debian/compat
> deleted file mode 100644
> index 7f8f011eb73d..000000000000
> diff --git a/libmthca/debian/control b/libmthca/debian/control
> deleted file mode 100644
> index 5ad14106b85c..000000000000
> diff --git a/libmthca/debian/copyright b/libmthca/debian/copyright
> deleted file mode 100644
> index 04abee0b74f7..000000000000
> diff --git a/libmthca/debian/libmthca-dev.install b/libmthca/debian/libmthca-dev.install
> deleted file mode 100644
> index e8122b99f572..000000000000
> diff --git a/libmthca/debian/libmthca1.install b/libmthca/debian/libmthca1.install
> deleted file mode 100644
> index 7d1d899e896f..000000000000
> diff --git a/libmthca/debian/patches/driver-plugin-directory.patch b/libmthca/debian/patches/driver-plugin-directory.patch
> deleted file mode 100644
> index 2ed7a66a24c0..000000000000
> diff --git a/libmthca/debian/patches/series b/libmthca/debian/patches/series
> deleted file mode 100644
> index 213f49e4c278..000000000000
> diff --git a/libmthca/debian/rules b/libmthca/debian/rules
> deleted file mode 100755
> index 902923802e67..000000000000
> diff --git a/libmthca/debian/source/format b/libmthca/debian/source/format
> deleted file mode 100644
> index 163aaf8d82b6..000000000000
> diff --git a/libmthca/debian/watch b/libmthca/debian/watch
> deleted file mode 100644
> index 8010f867b5d5..000000000000
> diff --git a/libmthca/libmthca.spec.in b/libmthca/libmthca.spec.in
> deleted file mode 100644
> index f23a159a5b97..000000000000
> diff --git a/libnes/libnes.spec.in b/libnes/libnes.spec.in
> deleted file mode 100644
> index 251365aedd1d..000000000000
> diff --git a/libocrdma/libocrdma.spec.in b/libocrdma/libocrdma.spec.in
> deleted file mode 100644
> index 5f7d9f13c527..000000000000
> diff --git a/librdmacm/librdmacm.spec.in b/librdmacm/librdmacm.spec.in
> deleted file mode 100644
> index e89aa16095bf..000000000000
> diff --git a/librxe/librxe.spec.in b/librxe/librxe.spec.in
> deleted file mode 100644
> index 16dbaa615946..000000000000
> diff --git a/srp_daemon/debian/changelog b/srp_daemon/debian/changelog
> deleted file mode 100644
> index edf8422ace3f..000000000000
> diff --git a/srp_daemon/debian/compat b/srp_daemon/debian/compat
> deleted file mode 100644
> index 45a4fb75db86..000000000000
> diff --git a/srp_daemon/debian/control b/srp_daemon/debian/control
> deleted file mode 100644
> index c2b24a5d66ff..000000000000
> diff --git a/srp_daemon/debian/copyright b/srp_daemon/debian/copyright
> deleted file mode 100644
> index 34994d31ea0b..000000000000
> diff --git a/srp_daemon/debian/postinst b/srp_daemon/debian/postinst
> deleted file mode 100644
> index 12e59820e44a..000000000000
> diff --git a/srp_daemon/debian/prerm b/srp_daemon/debian/prerm
> deleted file mode 100644
> index eb39bcb74d3c..000000000000
> diff --git a/srp_daemon/debian/rules b/srp_daemon/debian/rules
> deleted file mode 100755
> index 648c6aa5c167..000000000000
> diff --git a/srp_daemon/debian/source/format b/srp_daemon/debian/source/format
> deleted file mode 100644
> index 163aaf8d82b6..000000000000
> diff --git a/srp_daemon/srptools.spec.in b/srp_daemon/srptools.spec.in
> deleted file mode 100644
> index 750cab3cc485..000000000000
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* RE: [RFC v2 06/12] qedr: Add support for QP verbs
From: Amrani, Ram @ 2016-09-21 14:15 UTC (permalink / raw)
To: Leon Romanovsky
Cc: davem@davemloft.net, dledford@redhat.com, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
In-Reply-To: <20160920163048.GQ26673@leon.nu>
> > include/uapi/rdma/providers/qedr-abi.h | 35 +
>
> Please be aware that the last version for ABI header files doesn't have "provider"
> name in directory path (include/uapi/rdma/qedr-abi.h)
OK. Note that I was using https://www.spinics.net/lists/linux-rdma/msg40414.html that dates to 7 days ago and it contains the "providers" folder.
Can you point to the most recent patch?
> > diff --git a/drivers/infiniband/hw/qedr/main.c
> > b/drivers/infiniband/hw/qedr/main.c
> > index c99dd6a..10ad9ed 100644
> > --- a/drivers/infiniband/hw/qedr/main.c
> > +++ b/drivers/infiniband/hw/qedr/main.c
> > @@ -52,7 +52,7 @@ uint debug;
> > module_param(debug, uint, 0);
> > MODULE_PARM_DESC(debug, "Default debug msglevel");
> >
> > -static LIST_HEAD(qedr_dev_list);
>
> You are removing code which was added in previous patches, why do you do it?
>
Sure. Will fix. Thanks.
> > diff --git a/drivers/infiniband/hw/qedr/qedr.h
> > b/drivers/infiniband/hw/qedr/qedr.h
> > index dd974d5..05017be 100644
> > --- a/drivers/infiniband/hw/qedr/qedr.h
> > +++ b/drivers/infiniband/hw/qedr/qedr.h
> > @@ -49,6 +49,9 @@
> > enum DP_QEDR_MODULE {
> > QEDR_MSG_INIT = 0x10000,
>
> We prefer shift notation (1 << 16) instead of 0x10000.
>
OK, I'll convert accordingly.
^ permalink raw reply
* RE: [RFC v2 04/12] qedr: Add support for user context verbs
From: Amrani, Ram @ 2016-09-21 14:18 UTC (permalink / raw)
To: Leon Romanovsky
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <20160920164556.GS26673-2ukJVAZIZ/Y@public.gmane.org>
> Are you sure that you want GPL-only license?
Thanks for pointing this out. This is something we will obviously fix.
> > +#define QEDR_ABI_VERSION (6)
>
> Is it possible to start new file with new driver from ABI version 1 and not 6?
This is something that we cannot do since we already have a few libraries out there and we wouldn't like a user to use mismatch a library and a driver...
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* RE: [RFC v2 00/11] QLogic RDMA Driver (qedr) RFC
From: Amrani, Ram @ 2016-09-21 14:19 UTC (permalink / raw)
To: Leon Romanovsky, Elior, Ariel
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <20160920162306.GP26673-2ukJVAZIZ/Y@public.gmane.org>
>
> The module parameters is no-go.
>
We'll remove it.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* RE: [RFC v2 04/12] qedr: Add support for user context verbs
From: Amrani, Ram @ 2016-09-21 14:20 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: davem@davemloft.net, dledford@redhat.com, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma@vger.kernel.org, netdev@vger.kernel.org
In-Reply-To: <20160920152729.GC32020@obsidianresearch.com>
> uapi headers need the __ varients and the #include <linux/types.h>
>
> Follow what Leon has done.
OK
^ permalink raw reply
* RE: [RFC v2 06/12] qedr: Add support for QP verbs
From: Amrani, Ram @ 2016-09-21 14:23 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <20160920152849.GD32020-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Ugh, each patch keeps adding to this?
The logic in the patch series is to have each patch contain only what is necessary for the specific functionality it adds.
This made it harder on us to prepare but, IMHO, easier for the reviewer.
If you'd like to have this file in one chunk, I can do this. What do you prefer?
> > +struct qedr_create_qp_ureq {
> > + u32 qp_handle_hi;
> > + u32 qp_handle_lo;
> > +
> > + /* SQ */
> > + /* user space virtual address of SQ buffer */
> > + u64 sq_addr;
> > +
> > + /* length of SQ buffer */
> > + size_t sq_len;
>
> Do not use size_t, that is just asking for 32/64 bit interop problems.
OK
> > +struct qedr_create_qp_uresp {
> > + u32 qp_id;
> > + int atomic_supported;
>
> int again, etc. You get the idea.
Yeah, I did. Thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
From: Tejun Heo @ 2016-09-21 14:26 UTC (permalink / raw)
To: Parav Pandit
Cc: Leon Romanovsky, Jason Gunthorpe, Christoph Hellwig, Matan Barak,
cgroups, linux-doc, Linux Kernel Mailing List, linux-rdma,
Li Zefan, Johannes Weiner, Doug Ledford, Liran Liss, Hefty, Sean,
Haggai Eran, Jonathan Corbet, james.l.morris, serge, Or Gerlitz,
Andrew Morton, linux-security-module
In-Reply-To: <CAG53R5XBS0B5XaTzjKC3-zgoB2-fz2ctbk_E2YG76zBgzOfG-A@mail.gmail.com>
Hello, Parav.
On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote:
> We have completed review from Tejun, Christoph.
> HFI driver folks also provided feedback for Intel drivers.
> Matan's also doesn't have any more comments.
>
> If possible, if you can also review, it will be helpful.
>
> I have some more changes unrelated to cgroup in same files in both the git tree.
> Pushing them now either results into merge conflict later on for
> Doug/Tejun, or requires rebase and resending patch.
> If you can review, we can avoid such rework.
My impression of the thread was that there doesn't seem to be enough
of consensus around how rdma resources should be defined. Is that
part agreed upon now?
Thanks.
--
tejun
^ permalink raw reply
* [RFC] IB/mad: Eliminate redundant SM class version defines for OPA
From: Hal Rosenstock @ 2016-09-21 14:41 UTC (permalink / raw)
To: Weiny, Ira; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
and rename class version define to SM rather than SMP or SMI
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/drivers/infiniband/core/mad.c b/drivers/infiniband/core/mad.c
index 2d49228..17ba07d 100644
--- a/drivers/infiniband/core/mad.c
+++ b/drivers/infiniband/core/mad.c
@@ -769,7 +769,7 @@ static int handle_outgoing_dr_smp(struct ib_mad_agent_private *mad_agent_priv,
* If we are at the start of the LID routed part, don't update the
* hop_ptr or hop_cnt. See section 14.2.2, Vol 1 IB spec.
*/
- if (opa && smp->class_version == OPA_SMP_CLASS_VERSION) {
+ if (opa && smp->class_version == OPA_SM_CLASS_VERSION) {
u32 opa_drslid;
if ((opa_get_smp_direction(opa_smp)
@@ -2167,7 +2167,7 @@ handle_smi(struct ib_mad_port_private *port_priv,
struct ib_mad_hdr *mad_hdr = (struct ib_mad_hdr *)recv->mad;
if (opa && mad_hdr->base_version == OPA_MGMT_BASE_VERSION &&
- mad_hdr->class_version == OPA_SMI_CLASS_VERSION)
+ mad_hdr->class_version == OPA_SM_CLASS_VERSION)
return handle_opa_smi(port_priv, qp_info, wc, port_num, recv,
response);
diff --git a/drivers/infiniband/hw/hfi1/mad.c b/drivers/infiniband/hw/hfi1/mad.c
index 7ffc14f..484ed60 100644
--- a/drivers/infiniband/hw/hfi1/mad.c
+++ b/drivers/infiniband/hw/hfi1/mad.c
@@ -128,7 +128,7 @@ static void send_trap(struct hfi1_ibport *ibp, void *data, unsigned len)
smp = send_buf->mad;
smp->base_version = OPA_MGMT_BASE_VERSION;
smp->mgmt_class = IB_MGMT_CLASS_SUBN_LID_ROUTED;
- smp->class_version = OPA_SMI_CLASS_VERSION;
+ smp->class_version = OPA_SM_CLASS_VERSION;
smp->method = IB_MGMT_METHOD_TRAP;
ibp->rvp.tid++;
smp->tid = cpu_to_be64(ibp->rvp.tid);
@@ -343,7 +343,7 @@ static int __subn_get_opa_nodeinfo(struct opa_smp *smp, u32 am, u8 *data,
ni->port_guid = cpu_to_be64(dd->pport[pidx].guid);
ni->base_version = OPA_MGMT_BASE_VERSION;
- ni->class_version = OPA_SMI_CLASS_VERSION;
+ ni->class_version = OPA_SM_CLASS_VERSION;
ni->node_type = 1; /* channel adapter */
ni->num_ports = ibdev->phys_port_cnt;
/* This is already in network order */
@@ -379,7 +379,7 @@ static int subn_get_nodeinfo(struct ib_smp *smp, struct ib_device *ibdev,
nip->port_guid = cpu_to_be64(dd->pport[pidx].guid);
nip->base_version = OPA_MGMT_BASE_VERSION;
- nip->class_version = OPA_SMI_CLASS_VERSION;
+ nip->class_version = OPA_SM_CLASS_VERSION;
nip->node_type = 1; /* channel adapter */
nip->num_ports = ibdev->phys_port_cnt;
/* This is already in network order */
@@ -2309,7 +2309,7 @@ static int pma_get_opa_classportinfo(struct opa_pma_mad *pmp,
pmp->mad_hdr.status |= IB_SMP_INVALID_FIELD;
p->base_version = OPA_MGMT_BASE_VERSION;
- p->class_version = OPA_SMI_CLASS_VERSION;
+ p->class_version = OPA_SM_CLASS_VERSION;
/*
* Expected response time is 4.096 usec. * 2^18 == 1.073741824 sec.
*/
@@ -4029,7 +4029,7 @@ static int process_subn_opa(struct ib_device *ibdev, int mad_flags,
am = be32_to_cpu(smp->attr_mod);
attr_id = smp->attr_id;
- if (smp->class_version != OPA_SMI_CLASS_VERSION) {
+ if (smp->class_version != OPA_SM_CLASS_VERSION) {
smp->status |= IB_SMP_UNSUP_VERSION;
ret = reply((struct ib_mad_hdr *)smp);
return ret;
@@ -4239,7 +4239,7 @@ static int process_perf_opa(struct ib_device *ibdev, u8 port,
*out_mad = *in_mad;
- if (pmp->mad_hdr.class_version != OPA_SMI_CLASS_VERSION) {
+ if (pmp->mad_hdr.class_version != OPA_SM_CLASS_VERSION) {
pmp->mad_hdr.status |= IB_SMP_UNSUP_VERSION;
return reply((struct ib_mad_hdr *)pmp);
}
diff --git a/include/rdma/ib_mad.h b/include/rdma/ib_mad.h
index c8a773f..981214b 100644
--- a/include/rdma/ib_mad.h
+++ b/include/rdma/ib_mad.h
@@ -46,7 +46,7 @@
#define IB_MGMT_BASE_VERSION 1
#define OPA_MGMT_BASE_VERSION 0x80
-#define OPA_SMP_CLASS_VERSION 0x80
+#define OPA_SM_CLASS_VERSION 0x80
/* Management classes */
#define IB_MGMT_CLASS_SUBN_LID_ROUTED 0x01
diff --git a/include/rdma/opa_smi.h b/include/rdma/opa_smi.h
index 4a529ef..f789611 100644
--- a/include/rdma/opa_smi.h
+++ b/include/rdma/opa_smi.h
@@ -44,8 +44,6 @@
#define OPA_MAX_SLS 32
#define OPA_MAX_SCS 32
-#define OPA_SMI_CLASS_VERSION 0x80
-
#define OPA_LID_PERMISSIVE cpu_to_be32(0xFFFFFFFF)
struct opa_smp {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH 11/16] Remove the auto* based build systems
From: Jason Gunthorpe @ 2016-09-21 15:44 UTC (permalink / raw)
To: Yishai Hadas
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, alaa-VPRAkNaXOzVWk0Htik3J/w,
yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Doug Ledford
In-Reply-To: <6e3d2ab0-7c86-fe1c-affd-b7fb9ba59c20-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Wed, Sep 21, 2016 at 04:53:23PM +0300, Yishai Hadas wrote:
> On 9/21/2016 1:10 AM, Jason Gunthorpe wrote:
> >The unified cmake version provides the same functionality now.
>
> Can you explain how cmake preservers some compilation options which were
> enabled per vendor ? for example with previous build system someone could
> run configure of libmlx5 with --with-mlx5_debug, how can it be done now ?
On option is to do the usual 'CPPFLAGS="-DMLX5_DEBUG" cmake ..'
However we may as well document these options and provide a command
line switch as follows:
>From f964f6be593b7ef362af3168bd3c6bc8640b976d Mon Sep 17 00:00:00 2001
From: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Date: Wed, 21 Sep 2016 09:42:16 -0600
Subject: [PATCH] mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
Simply enable -D flags when building.
Use as:
$ cmake -DMLX5_DEBUG=TRUE -DMLX5_MW_DEBUG=TRUE
Reported-by: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
providers/mlx5/CMakeLists.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/providers/mlx5/CMakeLists.txt b/providers/mlx5/CMakeLists.txt
index a34a8063eeb2..44df83b47d96 100644
--- a/providers/mlx5/CMakeLists.txt
+++ b/providers/mlx5/CMakeLists.txt
@@ -1,3 +1,15 @@
+set(MLX5_DEBUG "FALSE" CACHE BOOL
+ "Enable expensive runtime logging options for the mlx5 verbs provider")
+if (MLX5_DEBUG)
+ add_definitions("-DMLX5_DEBUG")
+endif()
+
+set(MLX5_MW_DEBUG "FALSE" CACHE BOOL
+ "Enable extra validation of memory windows for the mlx5 verbs provider")
+if (MLX5_MW_DEBUG)
+ add_definitions("-DMW_DEBUG")
+endif()
+
rdma_provider(mlx5
buf.c
cq.c
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH 13/16] Remove Debian and RPM packaging files
From: Jason Gunthorpe @ 2016-09-21 15:52 UTC (permalink / raw)
To: Yishai Hadas
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, alaa-VPRAkNaXOzVWk0Htik3J/w,
yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org, Leon Romanovsky,
Doug Ledford
In-Reply-To: <2447bfda-5a48-18db-94b3-d031d5913a8e-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
On Wed, Sep 21, 2016 at 05:00:41PM +0300, Yishai Hadas wrote:
> On 9/21/2016 1:10 AM, Jason Gunthorpe wrote:
> >These no longer apply to the combined build.
>
> Taking this patch without introducing an alternative leaves the system
> without an option to build RPMs as it removes all packaging files.
The packaging was largely broken at the merge commit when we renamed
the sub trees. It was rendered totally useless by commit 11 which
deleted the build system it relied on. There is no reason to keep the
files at this point in the git history.
> What is the plan here ?
As I explined in the cover letter my preview tree contains
RPM and DEB packaging. It will take a bit before all the prerequists
for those patches go through the review process. Use my preview tree
to test packaging please.
This is only the first 16 out of 80 patches.
> In addition, did we come to a decision re having RPM per component ?
This is not our decision. The distros will follow their internal
policies. I recommend the layout seen in the debian/ sample packaging.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [RFC v2 06/12] qedr: Add support for QP verbs
From: Jason Gunthorpe @ 2016-09-21 15:55 UTC (permalink / raw)
To: Amrani, Ram
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Wed, Sep 21, 2016 at 02:23:46PM +0000, Amrani, Ram wrote:
> > Ugh, each patch keeps adding to this?
>
> The logic in the patch series is to have each patch contain only
> what is necessary for the specific functionality it adds. This made
> it harder on us to prepare but, IMHO, easier for the reviewer. If
> you'd like to have this file in one chunk, I can do this. What do
> you prefer?
I wouldn't change anything at this point, but I'm not sure it is
easier to review like this than the one patch per file scheme.
Do you have a git tree?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
From: Parav Pandit @ 2016-09-21 16:02 UTC (permalink / raw)
To: Tejun Heo
Cc: Leon Romanovsky, Jason Gunthorpe, Christoph Hellwig, Matan Barak,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-doc-u79uwXL29TY76Z2rM5mHXA,
Linux Kernel Mailing List, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Li Zefan, Johannes Weiner, Doug Ledford, Liran Liss, Hefty, Sean,
Haggai Eran, Jonathan Corbet,
james.l.morris-QHcLZuEGTsvQT0dZR+AlfA,
serge-A9i7LUbDfNHQT0dZR+AlfA, Or Gerlitz, Andrew Morton,
linux-security-module-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160921142645.GB10734-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
Hi Tejun,
On Wed, Sep 21, 2016 at 7:56 PM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Hello, Parav.
>
> On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote:
>> We have completed review from Tejun, Christoph.
>> HFI driver folks also provided feedback for Intel drivers.
>> Matan's also doesn't have any more comments.
>>
>> If possible, if you can also review, it will be helpful.
>>
>> I have some more changes unrelated to cgroup in same files in both the git tree.
>> Pushing them now either results into merge conflict later on for
>> Doug/Tejun, or requires rebase and resending patch.
>> If you can review, we can avoid such rework.
>
> My impression of the thread was that there doesn't seem to be enough
> of consensus around how rdma resources should be defined. Is that
> part agreed upon now?
>
We ended up discussing few points on different thread [1].
There was confusion on how some non-rdma/non-IB drivers would work
with rdma cgroup from Matan.
Christoph explained how they don't fit in the rdma subsystem and
therefore its not prime target to addess.
Intel driver maintainer Denny also acknowledged same on [2].
IB compliant drivers of Intel support rdma cgroup as explained in [2].
With that usnic and Intel psm drivers falls out of rdma cgroup support
as they don't fit very well in the verbs definition.
[1] https://www.spinics.net/lists/linux-rdma/msg40340.html
[2] http://www.spinics.net/lists/linux-rdma/msg40717.html
I will wait for Leon's review comments if he has different view on architecture.
Back in April when I met face-to-face to Leon and Haggai, Leon was in
support to have kernel defined the rdma resources as suggested by
Christoph and Tejun instead of IB/RDMA subsystem.
I will wait for his comments if his views have changed with new uAPI
taking shape.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v3 0/9] SELinux support for Infiniband RDMA
From: ira.weiny @ 2016-09-21 16:16 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Daniel Jurgens, Liran Liss, Paul Moore, Leon Romanovsky,
chrisw@sous-sol.org, Stephen Smalley, Eric Paris,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, selinux@tycho.nsa.gov,
linux-security-module@vger.kernel.org, linux-rdma@vger.kernel.org,
Yevgeny Petrilin
In-Reply-To: <20160908193235.GA1868@obsidianresearch.com>
On Thu, Sep 08, 2016 at 01:32:35PM -0600, Jason Gunthorpe wrote:
> On Thu, Sep 08, 2016 at 06:59:13PM +0000, Daniel Jurgens wrote:
>
> > >> Net has variety of means of enforcement, one of which is controlling
> > >> access to ports <tcp/udp,port number>, which is the most like what
> > >> I'm doing here.
> > > No, the analog the tcp/udp,port number is <ib, service_id>
>
> > I should have been clearer here. From the SELinux perspective this
> > scheme is very similar to net ports.
>
> It really isn't. net ports and service_ids are global things that do
> not need machine-specific customizations while subnet prefix or device
> name/port are both machine-local information.
I agree that service_ids are more analogous to net ports.
However, subnet prefixes are _not_ machine-local. They are controlled by the
Admin of the fabric by a central entity (the SM). This is more helpful than in
ethernet where if you configure the wrong port with the wrong subnet things
just don't work. In IB I can physically plug my network into any IB port I
want and the system is _told_ which "subnet" that port belongs to. (OPA is the
same way.)
So for IB/OPA a subnet prefix is a really good way to ID which network (subnet)
you want to use. Unfortunately, I'm not sure how to translate that to
iwarp/roce seamlessly except to have some concept of "domain" as I mentioned in
my other email.
Ira
^ permalink raw reply
* Re: [RFCv2 00/15] RFCv2: Consolidated userspace RDMA library repo
From: ira.weiny @ 2016-09-21 17:21 UTC (permalink / raw)
To: Doug Ledford
Cc: Leon Romanovsky, Jason Gunthorpe, Jarod Wilson, Steve Wise,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, 'Devesh Sharma',
'Hal Rosenstock', 'Mike Marciniszyn',
'Moni Shoua', 'Sean Hefty',
'Tatyana Nikolova', 'Vladimir Sokolovsky',
'Yishai Hadas'
In-Reply-To: <fcfcff11-fe5c-6cf5-3575-52da4b9241ed-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Unfortunataely, what you speak of is not really realistic, both for the
> reasons I've cited and a whole litany of other reasons I didn't mention.
>
> But I don't think Jason jumped in to work on this because of the goal of
> making Red Hat's life easier in packaging up the separate code. He did
> it for upstream related reasons:
>
> 1) Put all of the providers and libibverbs in one place so that they can
> be kept in sync. This allows us to do the exact same thing we do with
> the kernel in user space. Namely, if someone makes an incompatible
> change in the libibverbs core, we can require that they fix up all
> providers in the same patch series. This works rather well for the
> kernel, and it would be good to bring that policy to user space too.
>
> 2) Put all of the kernel interacting libraries in one place. This makes
> it easier to perform the write->ioctl conversion we've been discussing
> as there would be only one larger package that needs to be updated for
> any given kernel ioctl update.
>
> 3) Bring librdmacm and libibverbs together so that the occasional
> incompatible update between the two is not an issue any more.
>
> 4) Create an easier to build/install package for developers to use.
>
> Those are the issues we should be discussing the relative merits of in
> order to determine whether this work should be adopted.
>
I see one more benefit here. This should give us an opportunity to consolidate
and clarify the interface to the _users_ of these libraries. For example it
has always bothered me is there are about 3 places that a PathRecord struct was
defined. To be clear I think PathRecords should be hidden from the user but in
general keeping a clean interface to the user between librdmacm, libibverbs,
and to a lesser extent (or maybe not at all) libibumad would be very nice for
the end user.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [RFC v2 07/12] qedr: Add support for memory registeration verbs
From: Sagi Grimberg @ 2016-09-21 19:53 UTC (permalink / raw)
To: Ram Amrani, davem, dledford
Cc: Ariel.Elior, Michal.Kalderon, Yuval.Mintz, rajesh.borundia,
linux-rdma, netdev
In-Reply-To: <1474367764-9555-8-git-send-email-Ram.Amrani@cavium.com>
> +static int qedr_set_page(struct ib_mr *ibmr, u64 addr)
> +{
> + struct qedr_mr *mr = get_qedr_mr(ibmr);
> + struct qedr_pbl *pbl_table;
> + struct regpair *pbe;
> + u32 pbes_in_page;
> +
> + if (unlikely(mr->npages == mr->info.pbl_info.num_pbes)) {
> + DP_ERR(mr->dev, "qedr_set_page failes when %d\n", mr->npages);
> + return -ENOMEM;
> + }
> +
> + DP_VERBOSE(mr->dev, QEDR_MSG_MR, "qedr_set_page pages[%d] = 0x%llx\n",
> + mr->npages, addr);
> +
> + pbes_in_page = mr->info.pbl_info.pbl_size / sizeof(u64);
> + pbl_table = mr->info.pbl_table + (mr->npages / pbes_in_page);
> + pbe = (struct regpair *)pbl_table->va;
> + pbe += mr->npages % pbes_in_page;
> + pbe->lo = cpu_to_le32((u32)addr);
> + pbe->hi = cpu_to_le32((u32)upper_32_bits(addr));
> +
> + mr->npages++;
> +
> + return 0;
> +}
Looks better.
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply
* RE: [PATCH 14/16] ibacm: Remove windows support files
From: Hefty, Sean @ 2016-09-21 20:17 UTC (permalink / raw)
To: Jason Gunthorpe,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <1474409425-15769-15-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Building these is no longer supported.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Thanks
Acked-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 00/16] Consolidated RDMA userspace: rdma-core
From: Doug Ledford @ 2016-09-21 22:01 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Amrani, Ram, Adit Ranadive, Bart Van Assche, Christoph Hellwig,
Dalessandro, Dennis, Devesh Sharma, Donald Dutile, Hal Rosenstock,
Honggang Li, Jarod Wilson, John Jolly, Kamal Heib, Knut Omang,
Leon Romanovsky, Mike Marciniszyn, Moni Shoua, Sean Hefty,
Selvin Xavier, Steve Wise, Tatyana Nikolova <Tatyana.E.Nik>
In-Reply-To: <1474409425-15769-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 2191 bytes --]
On 9/20/2016 6:10 PM, Jason Gunthorpe wrote:
> Hello Everyone,
>
> We are starting the transition to the consolidated user space. Doug has setup
> a shared github here:
>
> https://github.com/linux-rdma/rdma-core
>
> Which now contains the base 'merge' commit, this is simply each of the
> original 18 repositories placed in a sub directory, unmodified.
>
> This tree will not be rebased. New work can target this tree.
>
> An earlier version of the patch series that follows has already been
> posted, and has been part of my preview tree for some time. The
> original mailing list threads are here:
>
> http://www.spinics.net/lists/linux-rdma/msg39026.html
> http://www.spinics.net/lists/linux-rdma/msg39328.html
> http://www.spinics.net/lists/linux-rdma/msg40014.html
> http://www.spinics.net/lists/linux-rdma/msg40086.html
>
> This series to unify the build system (+ any comments) will be applied to the
> tree right away and Doug + Leon will start generally accepting patches.
>
> My preview tree:
> https://github.com/jgunthorpe/rdma-plumbing
>
> Contains another ~70 patches which will be batched up and posted to this list
> for review. Notably those patches include the sample RPM and DEB packaging,
> and other packaging related items.
>
> Jason
>
> Christoph Hellwig (2):
> Remove README files in the provider directories
> Remove iwpmd/README
>
> Jason Gunthorpe (14):
> Fix bogus executable file permissions
> Include pthreads in the provider libraries
> Be explicit about _GNU_SOURCE
> hfi/ipath: Use the name of the provider for the .driver file
> ibcm: Actually use the version script when linking
> iwpm: Update autotools enough to build
> rdmacm: Control symbol export from librspreload
> Unified CMake build system
> Support obsolete cmake from 2013
> Add a MAINTAINERS file
> Remove the auto* based build systems
> Remove the ChangeLog files
> Remove Debian and RPM packaging files
> ibacm: Remove windows support files
It's looking good. Nice work Jason.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
* [PATCH 00/23] rdma-core Trivial fixes and documentation updates
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
This is the next batch of fixes, the 23 patches are all straight forward and
should be uncontroversial. Most are documentation updates, plus a few
obviously correct fixes from static checkers.
Please forward Acks and I will apply this to the github soonish.
The tree is here:
https://github.com/linux-rdma/rdma-core
View the patches on github:
https://github.com/linux-rdma/rdma-core/pull/2
Christoph Hellwig (6):
Add reporting bugs and submitting patches sections to README.md
verbs: Move documentation to Documentation/
rdmacm: Move documentation to Documentation/
ibcm: Move documentation to Documentation/
rxe: Move documentation to Documentation/
srp_daemon: Move documentation to Documentation/
Jason Gunthorpe (16):
Consolidate the .gitignore files
Move the AUTHORS files into MAINTAINERS
mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
ipathverbs: Recognize bashisms in truescale-serdes.cmds
nes: Fix clang 3.6 warning
-Wtautological-constant-out-of-range-compare
ocrdma: Fix incorrect type of ibwc_status
ocrdma: Fix incorrect enum constant
verbs: Fix incorrect type of len
verbs: Use inttypes.h format string macros
rdmacm: Use correct format specifier for size_t
rdmacm: Fix leading \'s in rcopy man page
rdmacm: Fix typos
umad: Replace .nl with .sp in man pages
iwpmd: Install ancillary files for iwpm
iwpmd: Remove syslog.target from service file
srp_daemon: Use SRP_DEFAULT_START/STOP for substitution
Steve Wise (1):
iwpmd: Add man pages
.gitignore | 71 +++++++++++
CMakeLists.txt | 1 +
Documentation/ibsrpdm.md | 41 +++++++
libibcm/README => Documentation/libibcm.md | 14 +--
Documentation/libibverbs.md | 58 +++++++++
librdmacm/README => Documentation/librdmacm.md | 27 +---
Documentation/rxe.md | 22 ++++
MAINTAINERS | 13 ++
README.md | 28 +++++
ibacm/AUTHORS | 1 -
iwpmd/AUTHORS | 2 -
iwpmd/CMakeLists.txt | 4 +
iwpmd/iwpmd.1 | 56 +++++++++
iwpmd/iwpmd.conf.5 | 20 +++
iwpmd/iwpmd.service | 2 +-
iwpmd/src/CMakeLists.txt | 10 +-
libcxgb3/AUTHORS | 1 -
libcxgb4/AUTHORS | 1 -
libhfi1verbs/.gitignore | 18 ---
libhfi1verbs/AUTHORS | 1 -
libi40iw/AUTHORS | 1 -
libibcm/AUTHORS | 2 -
libibumad/AUTHORS | 3 -
libibumad/man/umad_get_ca.3 | 2 +-
libibumad/man/umad_get_port.3 | 2 +-
libibumad/man/umad_init.3 | 2 +-
libibverbs/.gitignore | 24 ----
libibverbs/AUTHORS | 4 -
libibverbs/README | 164 -------------------------
libibverbs/examples/.gitignore | 10 --
libibverbs/examples/devinfo.c | 4 +-
libibverbs/src/.gitignore | 3 -
libipathverbs/.gitignore | 22 ----
libipathverbs/AUTHORS | 1 -
libipathverbs/truescale-serdes.cmds | 2 +-
libmlx4/.gitignore | 17 ---
libmlx4/AUTHORS | 2 -
libmlx4/src/.gitignore | 3 -
libmlx5/.gitignore | 33 -----
libmlx5/AUTHORS | 2 -
libmlx5/src/.gitignore | 3 -
libmlx5/src/CMakeLists.txt | 12 ++
libmthca/.gitignore | 17 ---
libmthca/AUTHORS | 2 -
libmthca/src/.gitignore | 3 -
libnes/AUTHORS | 1 -
libnes/src/nes_uverbs.c | 8 +-
libocrdma/AUTHORS | 1 -
libocrdma/src/ocrdma_verbs.c | 4 +-
librdmacm/.gitignore | 64 ----------
librdmacm/AUTHORS | 1 -
librdmacm/examples/.gitignore | 23 ----
librdmacm/examples/rping.c | 2 +-
librdmacm/examples/udpong.c | 2 +-
librdmacm/include/rdma/rdma_cma.h | 2 +-
librdmacm/man/mckey.1 | 2 +-
librdmacm/man/rcopy.1 | 6 +-
librdmacm/man/rdma_cm.7 | 4 +-
librdmacm/man/rdma_migrate_id.3 | 2 +-
librdmacm/man/rdma_post_write.3 | 2 +-
librdmacm/man/rdma_post_writev.3 | 2 +-
librdmacm/man/rdma_reg_msgs.3 | 2 +-
librdmacm/man/rdma_set_option.3 | 2 +-
librdmacm/src/.gitignore | 9 --
librxe/README.md | 63 ----------
srp_daemon/.gitignore | 18 ---
srp_daemon/README | 82 -------------
srp_daemon/srp_daemon/CMakeLists.txt | 4 +-
srp_daemon/srp_daemon/srpd.in | 4 +-
69 files changed, 372 insertions(+), 669 deletions(-)
create mode 100644 .gitignore
create mode 100644 Documentation/ibsrpdm.md
rename libibcm/README => Documentation/libibcm.md (54%)
create mode 100644 Documentation/libibverbs.md
rename librdmacm/README => Documentation/librdmacm.md (65%)
create mode 100644 Documentation/rxe.md
delete mode 100644 ibacm/AUTHORS
delete mode 100644 iwpmd/AUTHORS
create mode 100644 iwpmd/CMakeLists.txt
create mode 100644 iwpmd/iwpmd.1
create mode 100644 iwpmd/iwpmd.conf.5
delete mode 100644 libcxgb3/AUTHORS
delete mode 100644 libcxgb4/AUTHORS
delete mode 100644 libhfi1verbs/.gitignore
delete mode 100644 libhfi1verbs/AUTHORS
delete mode 100644 libi40iw/AUTHORS
delete mode 100644 libibcm/AUTHORS
delete mode 100644 libibumad/AUTHORS
delete mode 100644 libibverbs/.gitignore
delete mode 100644 libibverbs/AUTHORS
delete mode 100644 libibverbs/README
delete mode 100644 libibverbs/examples/.gitignore
delete mode 100644 libibverbs/src/.gitignore
delete mode 100644 libipathverbs/.gitignore
delete mode 100644 libipathverbs/AUTHORS
delete mode 100644 libmlx4/.gitignore
delete mode 100644 libmlx4/AUTHORS
delete mode 100644 libmlx4/src/.gitignore
delete mode 100644 libmlx5/.gitignore
delete mode 100644 libmlx5/AUTHORS
delete mode 100644 libmlx5/src/.gitignore
delete mode 100644 libmthca/.gitignore
delete mode 100644 libmthca/AUTHORS
delete mode 100644 libmthca/src/.gitignore
delete mode 100644 libnes/AUTHORS
delete mode 100644 libocrdma/AUTHORS
delete mode 100644 librdmacm/.gitignore
delete mode 100644 librdmacm/AUTHORS
delete mode 100644 librdmacm/examples/.gitignore
delete mode 100644 librdmacm/src/.gitignore
delete mode 100644 librxe/README.md
delete mode 100644 srp_daemon/.gitignore
delete mode 100644 srp_daemon/README
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH 01/23] Consolidate the .gitignore files
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Remove auto* stuff in the sub directories and replace it with one
copy of cmake stuff in the top level.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
.gitignore | 71 ++++++++++++++++++++++++++++++++++++++++++
libhfi1verbs/.gitignore | 18 -----------
libibverbs/.gitignore | 24 --------------
libibverbs/examples/.gitignore | 10 ------
libibverbs/src/.gitignore | 3 --
libipathverbs/.gitignore | 22 -------------
libmlx4/.gitignore | 17 ----------
libmlx4/src/.gitignore | 3 --
libmlx5/.gitignore | 33 --------------------
libmlx5/src/.gitignore | 3 --
libmthca/.gitignore | 17 ----------
libmthca/src/.gitignore | 3 --
librdmacm/.gitignore | 64 -------------------------------------
librdmacm/examples/.gitignore | 23 --------------
librdmacm/src/.gitignore | 9 ------
srp_daemon/.gitignore | 18 -----------
16 files changed, 71 insertions(+), 267 deletions(-)
create mode 100644 .gitignore
delete mode 100644 libhfi1verbs/.gitignore
delete mode 100644 libibverbs/.gitignore
delete mode 100644 libibverbs/examples/.gitignore
delete mode 100644 libibverbs/src/.gitignore
delete mode 100644 libipathverbs/.gitignore
delete mode 100644 libmlx4/.gitignore
delete mode 100644 libmlx4/src/.gitignore
delete mode 100644 libmlx5/.gitignore
delete mode 100644 libmlx5/src/.gitignore
delete mode 100644 libmthca/.gitignore
delete mode 100644 libmthca/src/.gitignore
delete mode 100644 librdmacm/.gitignore
delete mode 100644 librdmacm/examples/.gitignore
delete mode 100644 librdmacm/src/.gitignore
delete mode 100644 srp_daemon/.gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000000000000..f31a0617882d
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,71 @@
+# -*- mode: gitignore; -*-
+# CMake
+cmake_install.cmake
+CMakeFiles
+CMakeCache.txt
+lib*.a
+/bin/**
+/lib/**
+/include/**
+/.ninja*
+*.ninja
+Makefile
+
+# Tags
+TAGS
+.TAGS
+!TAGS/
+tags
+.tags
+!tags/
+gtags.files
+GTAGS
+GRTAGS
+GPATH
+
+# cscope
+cscope.files
+cscope.out
+cscope.in.out
+cscope.po.out
+
+# Emacs
+*~
+\#*\#
+/.emacs.desktop
+/.emacs.desktop.lock
+*.elc
+auto-save-list
+tramp
+.\#*
+
+# Org-mode
+.org-id-locations
+*_archive
+
+# flymake-mode
+*_flymake.*
+
+# eshell files
+/eshell/history
+/eshell/lastdir
+
+# elpa packages
+/elpa/
+
+# reftex files
+*.rel
+
+# AUCTeX auto folder
+/auto/
+
+# cask packages
+.cask/
+
+# vim
+[._]*.s[a-w][a-z]
+[._]s[a-w][a-z]
+*.un~
+Session.vim
+.netrwhist
+*~
diff --git a/libhfi1verbs/.gitignore b/libhfi1verbs/.gitignore
deleted file mode 100644
index 1fd7e821926c..000000000000
diff --git a/libibverbs/.gitignore b/libibverbs/.gitignore
deleted file mode 100644
index 9fb29eae8cd4..000000000000
diff --git a/libibverbs/examples/.gitignore b/libibverbs/examples/.gitignore
deleted file mode 100644
index ebecbdc0cf56..000000000000
diff --git a/libibverbs/src/.gitignore b/libibverbs/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libipathverbs/.gitignore b/libipathverbs/.gitignore
deleted file mode 100644
index 007a003f6e53..000000000000
diff --git a/libmlx4/.gitignore b/libmlx4/.gitignore
deleted file mode 100644
index 4c45b0912563..000000000000
diff --git a/libmlx4/src/.gitignore b/libmlx4/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libmlx5/.gitignore b/libmlx5/.gitignore
deleted file mode 100644
index 7878db2d068e..000000000000
diff --git a/libmlx5/src/.gitignore b/libmlx5/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libmthca/.gitignore b/libmthca/.gitignore
deleted file mode 100644
index 43f0908f1de0..000000000000
diff --git a/libmthca/src/.gitignore b/libmthca/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/librdmacm/.gitignore b/librdmacm/.gitignore
deleted file mode 100644
index cea1f714f199..000000000000
diff --git a/librdmacm/examples/.gitignore b/librdmacm/examples/.gitignore
deleted file mode 100644
index ce9156d4a97f..000000000000
diff --git a/librdmacm/src/.gitignore b/librdmacm/src/.gitignore
deleted file mode 100644
index 139417a24de1..000000000000
diff --git a/srp_daemon/.gitignore b/srp_daemon/.gitignore
deleted file mode 100644
index b055c68141c3..000000000000
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 02/23] Move the AUTHORS files into MAINTAINERS
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Mark historical past authors using the 'H:' tag. We don't need this
information sprinkled throughout the tree.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
MAINTAINERS | 13 +++++++++++++
ibacm/AUTHORS | 1 -
iwpmd/AUTHORS | 2 --
libcxgb3/AUTHORS | 1 -
libcxgb4/AUTHORS | 1 -
libhfi1verbs/AUTHORS | 1 -
libi40iw/AUTHORS | 1 -
libibcm/AUTHORS | 2 --
libibumad/AUTHORS | 3 ---
libibverbs/AUTHORS | 4 ----
libipathverbs/AUTHORS | 1 -
libmlx4/AUTHORS | 2 --
libmlx5/AUTHORS | 2 --
libmthca/AUTHORS | 2 --
libnes/AUTHORS | 1 -
libocrdma/AUTHORS | 1 -
librdmacm/AUTHORS | 1 -
17 files changed, 13 insertions(+), 26 deletions(-)
delete mode 100644 ibacm/AUTHORS
delete mode 100644 iwpmd/AUTHORS
delete mode 100644 libcxgb3/AUTHORS
delete mode 100644 libcxgb4/AUTHORS
delete mode 100644 libhfi1verbs/AUTHORS
delete mode 100644 libi40iw/AUTHORS
delete mode 100644 libibcm/AUTHORS
delete mode 100644 libibumad/AUTHORS
delete mode 100644 libibverbs/AUTHORS
delete mode 100644 libipathverbs/AUTHORS
delete mode 100644 libmlx4/AUTHORS
delete mode 100644 libmlx5/AUTHORS
delete mode 100644 libmthca/AUTHORS
delete mode 100644 libnes/AUTHORS
delete mode 100644 libocrdma/AUTHORS
delete mode 100644 librdmacm/AUTHORS
diff --git a/MAINTAINERS b/MAINTAINERS
index 71e8724f87ac..b39529feec9b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11,6 +11,7 @@ Descriptions of section entries:
F: providers/* all files in drivers/net, but not below
F: */net/* all files in "any top level directory"/net
One pattern per line. Multiple F: lines acceptable.
+ H: Historical authors
L: Mailing list that is relevant to this area
M: Designated reviewer: FullName <address@domain>
These reviewers should be CCed on patches.
@@ -73,22 +74,30 @@ F: libipathverbs/
IWARP PORT MAPPER DAEMON (for iwarp kernel providers)
M: Tatyana Nikolova <Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Robert Sharp <robert.o.sharp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
S: Supported
F: iwpmd/
LIBIBCM USERSPACE LIBRARY FOR IB CONNECTION MANAGEMENT (/dev/infiniband/ucmX)
M: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Libor Michalek <libor-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Obsolete
F: libibcm/
LIBIBUMAD USERSPACE LIBRARY FOR SMP AND GMP MAD PROCESSING (/dev/infiniband/umadX)
M: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
+H: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
+H: Shahar Frank <shahar-smomgflXvOZWk0Htik3J/w@public.gmane.org>
S: Supported
F: libibumad/
LIBIBVERBS USERSPACE LIBRARY FOR RDMA VERBS (/dev/infiniband/uverbsX)
M: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
M: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
+H: Michael S. Tsirkin <mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
+H: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Dotan Barak <dotanba-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
+H: Roland Dreier <roland-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Supported
F: libibverbs/
@@ -99,16 +108,20 @@ F: librdmacm/
MLX4 USERSPACE PROVIDER (for mlx4_ib.ko)
M: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
S: Supported
F: libmlx4/
MLX5 USERSPACE PROVIDER (for mlx5_ib.ko)
M: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
S: Supported
F: libmlx5/
MTHCA USERSPACE PROVIDER (for ib_mthca.ko)
M: Vladimir Sokolovsky <vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Michael S. Tsirkin <mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
+H: Roland Dreier <roland-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Supported
F: libmthca/
diff --git a/ibacm/AUTHORS b/ibacm/AUTHORS
deleted file mode 100644
index f76b870b4dba..000000000000
diff --git a/iwpmd/AUTHORS b/iwpmd/AUTHORS
deleted file mode 100644
index 10d4e6567693..000000000000
diff --git a/libcxgb3/AUTHORS b/libcxgb3/AUTHORS
deleted file mode 100644
index 5d9d2e254c6c..000000000000
diff --git a/libcxgb4/AUTHORS b/libcxgb4/AUTHORS
deleted file mode 100644
index 5d9d2e254c6c..000000000000
diff --git a/libhfi1verbs/AUTHORS b/libhfi1verbs/AUTHORS
deleted file mode 100644
index 669766569127..000000000000
diff --git a/libi40iw/AUTHORS b/libi40iw/AUTHORS
deleted file mode 100644
index 64c97fbe1f34..000000000000
diff --git a/libibcm/AUTHORS b/libibcm/AUTHORS
deleted file mode 100644
index a694ab7046b6..000000000000
diff --git a/libibumad/AUTHORS b/libibumad/AUTHORS
deleted file mode 100644
index d09c13fe2781..000000000000
diff --git a/libibverbs/AUTHORS b/libibverbs/AUTHORS
deleted file mode 100644
index fcea3504a516..000000000000
diff --git a/libipathverbs/AUTHORS b/libipathverbs/AUTHORS
deleted file mode 100644
index 48d6abcd54b9..000000000000
diff --git a/libmlx4/AUTHORS b/libmlx4/AUTHORS
deleted file mode 100644
index 4d0f22c2632b..000000000000
diff --git a/libmlx5/AUTHORS b/libmlx5/AUTHORS
deleted file mode 100644
index 11cba6b7cb32..000000000000
diff --git a/libmthca/AUTHORS b/libmthca/AUTHORS
deleted file mode 100644
index 165aea78cd02..000000000000
diff --git a/libnes/AUTHORS b/libnes/AUTHORS
deleted file mode 100644
index 64c97fbe1f34..000000000000
diff --git a/libocrdma/AUTHORS b/libocrdma/AUTHORS
deleted file mode 100644
index b930ad385164..000000000000
diff --git a/librdmacm/AUTHORS b/librdmacm/AUTHORS
deleted file mode 100644
index f76b870b4dba..000000000000
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 03/23] Add reporting bugs and submitting patches sections to README.md
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Based on the wording from the libibverbs and srp_daemon README files.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
README.md | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/README.md b/README.md
index 65c7644ad770..8c31944c91a8 100644
--- a/README.md
+++ b/README.md
@@ -95,3 +95,31 @@ $ install -m755 ninja /usr/local/bin/ninja
```
Use the 'cmake3' program in place of `cmake` in the above instructions.
+
+# Reporting bugs
+
+Bugs should be reported to the <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> mailing list
+In your bug report, please include:
+
+ * Information about your system:
+ - Linux distribution and version
+ - Linux kernel and version
+ - InfiniBand hardware and firmware version
+ - ... any other relevant information
+
+ * How to reproduce the bug.
+
+ * If the bug is a crash, the exact output printed out when the crash
+ occurred, including any kernel messages produced.
+
+# Submitting patches
+
+Patches should also be submitted to the <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
+mailing list. Please use unified diff form (the -u option to GNU diff),
+and include a good description of what your patch does and why it should
+be applied. If your patch fixes a bug, please make sure to describe the
+bug and how your fix works.
+
+Make sure that your contribution can be licensed under the same
+license as the original code you are patching, and that you have all
+necessary permissions to release your work.
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 04/23] mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Yishai Hadas
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Simply enable -D flags when building.
Use as:
$ cmake -DMLX5_DEBUG=TRUE -DMLX5_MW_DEBUG=TRUE
Reported-by: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libmlx5/src/CMakeLists.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/libmlx5/src/CMakeLists.txt b/libmlx5/src/CMakeLists.txt
index a34a8063eeb2..44df83b47d96 100644
--- a/libmlx5/src/CMakeLists.txt
+++ b/libmlx5/src/CMakeLists.txt
@@ -1,3 +1,15 @@
+set(MLX5_DEBUG "FALSE" CACHE BOOL
+ "Enable expensive runtime logging options for the mlx5 verbs provider")
+if (MLX5_DEBUG)
+ add_definitions("-DMLX5_DEBUG")
+endif()
+
+set(MLX5_MW_DEBUG "FALSE" CACHE BOOL
+ "Enable extra validation of memory windows for the mlx5 verbs provider")
+if (MLX5_MW_DEBUG)
+ add_definitions("-DMW_DEBUG")
+endif()
+
rdma_provider(mlx5
buf.c
cq.c
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox