* [PATCH 17/23] umad: Replace .nl with .sp in man pages
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Hal Rosenstock
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Debian's Lintian remarks:
W: rdma-plumbing: manpage-has-errors-from-man usr/share/man/man3/umad_get_ca.3.gz 11: warning: macro `nl' not defined
W: rdma-plumbing: manpage-has-errors-from-man usr/share/man/man3/umad_get_port.3.gz 11: warning: macro `nl' not defined
W: rdma-plumbing: manpage-has-errors-from-man usr/share/man/man3/umad_init.3.gz 11: warning: macro `nl' not defined
We use .sp in other the man pages to separate function signatures, follow
that practice consistently.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libibumad/man/umad_get_ca.3 | 2 +-
libibumad/man/umad_get_port.3 | 2 +-
libibumad/man/umad_init.3 | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/libibumad/man/umad_get_ca.3 b/libibumad/man/umad_get_ca.3
index 2f5fd1a71420..8de61d06d6d3 100644
--- a/libibumad/man/umad_get_ca.3
+++ b/libibumad/man/umad_get_ca.3
@@ -8,7 +8,7 @@ umad_get_ca, umad_release_ca \- get and release InfiniBand device port attribute
.B #include <infiniband/umad.h>
.sp
.BI "int umad_get_ca(char " "*ca_name" ", umad_ca_t " "*ca" );
-.nl
+.sp
.BI "int umad_release_ca(umad_ca_t " "*ca" );
.fi
.SH "DESCRIPTION"
diff --git a/libibumad/man/umad_get_port.3 b/libibumad/man/umad_get_port.3
index 863afa7f8286..8dfa1d61933f 100644
--- a/libibumad/man/umad_get_port.3
+++ b/libibumad/man/umad_get_port.3
@@ -8,7 +8,7 @@ umad_get_port, umad_release_port \- open and close an InfiniBand port
.B #include <infiniband/umad.h>
.sp
.BI "int umad_get_port(char " "*ca_name" ", int " "portnum" ", umad_port_t " "*port" );
-.nl
+.sp
.BI "int umad_release_port(umad_port_t " "*port" );
.fi
.SH "DESCRIPTION"
diff --git a/libibumad/man/umad_init.3 b/libibumad/man/umad_init.3
index a8108773c09f..4c22d927d8ec 100644
--- a/libibumad/man/umad_init.3
+++ b/libibumad/man/umad_init.3
@@ -8,7 +8,7 @@ umad_init, umad_done \- perform library initialization and finalization
.B #include <infiniband/umad.h>
.sp
.BI "int umad_init(void);
-.nl
+.sp
.BI "int umad_done(void);
.fi
.SH "DESCRIPTION"
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 16/23] ibcm: Move documentation to Documentation/
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig, Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
And drop bits that are outdated or replaced by top-level Documentation.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
libibcm/README => Documentation/libibcm.md | 14 +-------------
1 file changed, 1 insertion(+), 13 deletions(-)
rename libibcm/README => Documentation/libibcm.md (54%)
diff --git a/libibcm/README b/Documentation/libibcm.md
similarity index 54%
rename from libibcm/README
rename to Documentation/libibcm.md
index 4dda13c185eb..663e7736d2f1 100644
--- a/libibcm/README
+++ b/Documentation/libibcm.md
@@ -1,16 +1,4 @@
-This README is for userspace cm library.
-
-Building
-
-To make this directory, run:
-./autogen.sh && ./configure && make && make install
-
-Typically the autogen and configure steps only need be done the first
-time unless configure.in or Makefile.am changes.
-
-Libraries are installed by default at /usr/local/lib.
-
-Device files
+# Device files
The userspace CM uses a device file per adapter present.
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 15/23] rdmacm: Move documentation to Documentation/
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig, Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
And drop bits that are outdated or replaced by top-level Documentation.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
librdmacm/README => Documentation/librdmacm.md | 27 ++++++--------------------
1 file changed, 6 insertions(+), 21 deletions(-)
rename librdmacm/README => Documentation/librdmacm.md (65%)
diff --git a/librdmacm/README b/Documentation/librdmacm.md
similarity index 65%
rename from librdmacm/README
rename to Documentation/librdmacm.md
index e1f222740144..817383661c06 100644
--- a/librdmacm/README
+++ b/Documentation/librdmacm.md
@@ -1,19 +1,5 @@
-This README is for userspace RDMA cm library.
+# Device files
-
-Building
-========
-To make this directory, run:
-./autogen.sh && ./configure && make && make install
-
-Typically the autogen and configure steps only need be done the first
-time unless configure.in or Makefile.am changes.
-
-Libraries are installed by default at /usr/local/lib.
-
-
-Device files
-============
The userspace CMA uses a single device file regardless of the number
of adapters or ports present.
@@ -31,17 +17,16 @@ or you can create it manually
mknod /dev/infiniband/rdma_cm c 231 255
-Common issues
-=============
+# Common issues
Using multiple interfaces
- The librdmacm does support multiple interfaces. To make use
+: The librdmacm does support multiple interfaces. To make use
of multiple interfaces, however, you need to instruct linux
to only send ARP reples on the interface targetted in the ARP
request. This can be done using a command similar to the
following:
- sysctl -w net.ipv4.conf.all.arp_ignore=2
+ sysctl -w net.ipv4.conf.all.arp_ignore=2
Without this change, it's possible for linux to resopnd to ARP
requests on a different interface (IP address) than the IP
@@ -50,12 +35,12 @@ Using multiple interfaces
device.
Using loopback
- The librdmacm relies on ARP to resolve IP address to RDMA
+: The librdmacm relies on ARP to resolve IP address to RDMA
addresses. To support loopback connections between different
ports on the same system, ARP must be enabled for local
resolution:
- sysctl net.ipv4.conf.all.accept_local=1
+ sysctl net.ipv4.conf.all.accept_local=1
Without this setting, loopback connections may timeout
during address resolution.
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 14/23] rdmacm: Fix typos
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Benjamin Drung <benjamin.drung-EIkl63zCoXaH+58JC4qpiA@public.gmane.org> (debian)
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
librdmacm/include/rdma/rdma_cma.h | 2 +-
librdmacm/man/mckey.1 | 2 +-
librdmacm/man/rdma_cm.7 | 4 ++--
librdmacm/man/rdma_migrate_id.3 | 2 +-
librdmacm/man/rdma_post_write.3 | 2 +-
librdmacm/man/rdma_post_writev.3 | 2 +-
librdmacm/man/rdma_reg_msgs.3 | 2 +-
librdmacm/man/rdma_set_option.3 | 2 +-
8 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/librdmacm/include/rdma/rdma_cma.h b/librdmacm/include/rdma/rdma_cma.h
index 4826c0304b0b..2055665a1496 100644
--- a/librdmacm/include/rdma/rdma_cma.h
+++ b/librdmacm/include/rdma/rdma_cma.h
@@ -278,7 +278,7 @@ int rdma_create_ep(struct rdma_cm_id **id, struct rdma_addrinfo *res,
/**
* rdma_destroy_ep - Deallocates a communication identifier and qp.
- * @id: The communication identifer to destroy.
+ * @id: The communication identifier to destroy.
* Description:
* Destroys the specified rdma_cm_id and any associated QP created
* on that id.
diff --git a/librdmacm/man/mckey.1 b/librdmacm/man/mckey.1
index 441881919dd2..86a51a35e971 100644
--- a/librdmacm/man/mckey.1
+++ b/librdmacm/man/mckey.1
@@ -47,7 +47,7 @@ UDP (0x0111) or IPoIB (0x0002) port space. (default RDMA_PS_UDP)
Basic usage is to start mckey -m multicast_address on a server system,
then run mckey -m multicast_address -s on a client system.
.P
-Unique Infiniband SA assigned multicast GIDs can be retrived by
+Unique Infiniband SA assigned multicast GIDs can be retrieved by
invoking mckey with a zero MGID or IP address. (Example, -M 0 or
-m 0.0.0.0). The assigned address will be displayed to allow
mckey clients to join the created group.
diff --git a/librdmacm/man/rdma_cm.7 b/librdmacm/man/rdma_cm.7
index ee8427a29223..451035bfb588 100644
--- a/librdmacm/man/rdma_cm.7
+++ b/librdmacm/man/rdma_cm.7
@@ -67,7 +67,7 @@ low level call details shown. For
synchronous operation, calls to rdma_create_event_channel, rdma_get_cm_event,
rdma_ack_cm_event, and rdma_destroy_event_channel
would be eliminated. Abstracted calls, such as rdma_create_ep encapsulate
-serveral of these calls under a single API.
+several of these calls under a single API.
Users may also refer to the example applications for
code samples. A general connection flow would be:
.IP rdma_getaddrinfo
@@ -171,7 +171,7 @@ regarding the reason for the failure.
.P
Prior versions of the library would return -errno and not set errno for some cases
related to ENOMEM, ENODEV, ENODATA, EINVAL, and EADDRNOTAVAIL codes. Applications
-that want to check these codes and have compatability with prior library versions
+that want to check these codes and have compatibility with prior library versions
must manually set errno to the negative of the return code if it is < -1.
.SH "SEE ALSO"
rdma_accept(3),
diff --git a/librdmacm/man/rdma_migrate_id.3 b/librdmacm/man/rdma_migrate_id.3
index 8683c93090bf..8c2d7dd6e40a 100644
--- a/librdmacm/man/rdma_migrate_id.3
+++ b/librdmacm/man/rdma_migrate_id.3
@@ -1,6 +1,6 @@
.TH "RDMA_MIGRATE_ID" 3 "2007-11-13" "librdmacm" "Librdmacm Programmer's Manual" librdmacm
.SH NAME
-rdma_migrate_id \- Move a communication identifer to a different event channel.
+rdma_migrate_id \- Move a communication identifier to a different event channel.
.SH SYNOPSIS
.B "#include <rdma/rdma_cma.h>"
.P
diff --git a/librdmacm/man/rdma_post_write.3 b/librdmacm/man/rdma_post_write.3
index 896996ce5f62..5ab4fdb5dc4b 100644
--- a/librdmacm/man/rdma_post_write.3
+++ b/librdmacm/man/rdma_post_write.3
@@ -34,7 +34,7 @@ The registered memory key associated with the remote address.
.SH "DESCRIPTION"
Posts a work request to the send queue of the queue pair associated
with the rdma_cm_id. The contents of the local data buffer will be
-writen into the remote memory region.
+written into the remote memory region.
.SH "RETURN VALUE"
Returns 0 on success, or -1 on error. If an error occurs, errno will be
set to indicate the failure reason.
diff --git a/librdmacm/man/rdma_post_writev.3 b/librdmacm/man/rdma_post_writev.3
index f5b23fdcb7bc..1fc7b0a6c709 100644
--- a/librdmacm/man/rdma_post_writev.3
+++ b/librdmacm/man/rdma_post_writev.3
@@ -31,7 +31,7 @@ The registered memory key associated with the remote address.
.SH "DESCRIPTION"
Posts a work request to the send queue of the queue pair associated
with the rdma_cm_id. The contents of the local data buffers will be
-writen into the remote memory region.
+written into the remote memory region.
.SH "RETURN VALUE"
Returns 0 on success, or -1 on error. If an error occurs, errno will be
set to indicate the failure reason.
diff --git a/librdmacm/man/rdma_reg_msgs.3 b/librdmacm/man/rdma_reg_msgs.3
index c2c93593bba9..4f5656313734 100644
--- a/librdmacm/man/rdma_reg_msgs.3
+++ b/librdmacm/man/rdma_reg_msgs.3
@@ -21,7 +21,7 @@ Registers an array of memory buffers used for sending and receiving
messages or for RDMA operations. Memory buffers registered using
rdma_reg_msgs may be posted to an rdma_cm_id using
rdma_post_send or rdma_post_recv, or specified as the target of an RDMA
-read operation or the source of an RDMA write reqeust.
+read operation or the source of an RDMA write request.
.SH "RETURN VALUE"
Returns a reference to the registered memory region on success, or NULL on
error. If an error occurs, errno will be set to indicate the failure reason.
diff --git a/librdmacm/man/rdma_set_option.3 b/librdmacm/man/rdma_set_option.3
index 8e344abc3f8a..74bf5ceba88d 100644
--- a/librdmacm/man/rdma_set_option.3
+++ b/librdmacm/man/rdma_set_option.3
@@ -28,6 +28,6 @@ the default system settings.
Returns 0 on success, or -1 on error. If an error occurs, errno will be
set to indicate the failure reason.
.SH "NOTES"
-Option details may be found in the relevent header files.
+Option details may be found in the relevant header files.
.SH "SEE ALSO"
rdma_create_id(3)
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 13/23] rdmacm: Fix leading \'s in rcopy man page
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Debian's Lintian remarks:
W: rdma-plumbing: manpage-has-errors-from-man usr/share/man/man1/rcopy.1.gz 15: warning: numeric expression expected (got `u')
And indeed the man page displays corrupted. The leading \ is only needed
if the text starts with - so drop it on all other cases.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
librdmacm/man/rcopy.1 | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/librdmacm/man/rcopy.1 b/librdmacm/man/rcopy.1
index a5ad76aa8742..e875458bf162 100644
--- a/librdmacm/man/rcopy.1
+++ b/librdmacm/man/rcopy.1
@@ -12,13 +12,13 @@ Uses sockets over RDMA interface to copy a source file to the
specified destination.
.SH "OPTIONS"
.TP
-\source
+source
The name and path of the source file to copy.
.TP
-\server
+server
The name or address of the destination server.
.TP
-\:destination
+:destination
An optional destination filename and path. If not given, the destination
filename will match that of the source.
.TP
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 12/23] rdmacm: Use correct format specifier for size_t
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
clang 3.6 remarks:
../librdmacm/examples/rping.c:1203:30: warning: invalid conversion specifier 'Z' [-Wformat-invalid-specifier]
"(valid range is %Zd to %d)\n",
And indeed, the correct specifier for size_t is '%zd'
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
librdmacm/examples/rping.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/librdmacm/examples/rping.c b/librdmacm/examples/rping.c
index 171857dcb5ca..c248e66aaa83 100644
--- a/librdmacm/examples/rping.c
+++ b/librdmacm/examples/rping.c
@@ -1201,7 +1201,7 @@ int main(int argc, char *argv[])
if ((cb->size < RPING_MIN_BUFSIZE) ||
(cb->size > (RPING_BUFSIZE - 1))) {
fprintf(stderr, "Invalid size %d "
- "(valid range is %Zd to %d)\n",
+ "(valid range is %zd to %d)\n",
cb->size, RPING_MIN_BUFSIZE, RPING_BUFSIZE);
ret = EINVAL;
} else
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 11/23] verbs: Move documentation to Documentation/
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
And drop bits that are outdated or replaced by top-level Documentation.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
Documentation/libibverbs.md | 58 ++++++++++++++++
libibverbs/README | 164 --------------------------------------------
2 files changed, 58 insertions(+), 164 deletions(-)
create mode 100644 Documentation/libibverbs.md
delete mode 100644 libibverbs/README
diff --git a/Documentation/libibverbs.md b/Documentation/libibverbs.md
new file mode 100644
index 000000000000..cbe076e0fcab
--- /dev/null
+++ b/Documentation/libibverbs.md
@@ -0,0 +1,58 @@
+# Introduction
+
+libibverbs is a library that allows programs to use RDMA "verbs" for
+direct access to RDMA (currently InfiniBand and iWARP) hardware from
+userspace. For more information on RDMA verbs, see the InfiniBand
+Architecture Specification vol. 1, especially chapter 11, and the RDMA
+Consortium's RDMA Protocol Verbs Specification.
+
+# Using libibverbs
+
+### Device nodes
+
+The verbs library expects special character device files named
+/dev/infiniband/uverbsN to be created. When you load the kernel
+modules, including both the low-level driver for your IB hardware as
+well as the ib_uverbs module, you should see one or more uverbsN
+entries in /sys/class/infiniband_verbs in addition to the
+/dev/infiniband/uverbsN character device files.
+
+To create the appropriate character device files automatically with
+udev, a rule like
+
+ KERNEL="uverbs*", NAME="infiniband/%k"
+
+can be used. This will create device nodes named
+
+ /dev/infiniband/uverbs0
+
+and so on. Since the RDMA userspace verbs should be safe for use by
+non-privileged users, you may want to add an appropriate MODE or GROUP
+to your udev rule.
+
+### Permissions
+
+To use IB verbs from userspace, a process must be able to access the
+appropriate /dev/infiniband/uverbsN special device file. You can
+check the permissions on this file with the command
+
+ ls -l /dev/infiniband/uverbs*
+
+Make sure that the permissions on these files are such that the
+user/group that your verbs program runs as can access the device file.
+
+To use IB verbs from userspace, a process must also have permission to
+tell the kernel to lock sufficient memory for all of your registered
+memory regions as well as the memory used internally by IB resources
+such as queue pairs (QPs) and completion queues (CQs). To check your
+resource limits, use the command
+
+ ulimit -l
+
+(or "limit memorylocked" for csh-like shells).
+
+If you see a small number such as 32 (the units are KB) then you will
+need to increase this limit. This is usually done for ordinary users
+via the file /etc/security/limits.conf. More configuration may be
+necessary if you are logging in via OpenSSH and your sshd is
+configured to use privilege separation.
diff --git a/libibverbs/README b/libibverbs/README
deleted file mode 100644
index 848eb05917fb..000000000000
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 10/23] verbs: Use inttypes.h format string macros
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Doug Ledford, Yishai Hadas
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Otherwise a 32bit compile of ibv_devinfo will print garbage for
these values.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libibverbs/examples/devinfo.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libibverbs/examples/devinfo.c b/libibverbs/examples/devinfo.c
index 1d0c2dbde9b0..e814bacdf7aa 100644
--- a/libibverbs/examples/devinfo.c
+++ b/libibverbs/examples/devinfo.c
@@ -474,13 +474,13 @@ static int print_hca_cap(struct ibv_device *ib_dev, uint8_t ib_port)
print_odp_caps(&device_attr.odp_caps);
if (device_attr.completion_timestamp_mask)
- printf("\tcompletion timestamp_mask:\t\t\t0x%016lx\n",
+ printf("\tcompletion timestamp_mask:\t\t\t0x%016" PRIx64 "\n",
device_attr.completion_timestamp_mask);
else
printf("\tcompletion_timestamp_mask not supported\n");
if (device_attr.hca_core_clock)
- printf("\thca_core_clock:\t\t\t%lukHZ\n", device_attr.hca_core_clock);
+ printf("\thca_core_clock:\t\t\t%" PRIu64 "kHZ\n", device_attr.hca_core_clock);
else
printf("\tcore clock not supported\n");
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 09/23] verbs: Fix incorrect type of len
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Sean Hefty
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
gcc remarks:
../librdmacm/examples/udpong.c:301:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits]
if (len < 0)
len is set by:
len = svr_recv(&msg, sizeof msg, &addr, &addrlen);
And svr_recv returns:
static ssize_t svr_recv(struct message *msg, size_t size,
So clearly len is the wrong type, and the error test does
not work.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
librdmacm/examples/udpong.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/librdmacm/examples/udpong.c b/librdmacm/examples/udpong.c
index 6affc62d5a84..0f44f50e6e88 100644
--- a/librdmacm/examples/udpong.c
+++ b/librdmacm/examples/udpong.c
@@ -291,7 +291,7 @@ out:
static int svr_run(void)
{
- size_t len;
+ ssize_t len;
int ret;
ret = svr_bind();
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 08/23] ocrdma: Fix incorrect enum constant
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Devesh Sharma
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
clang 3.6 remarks:
../providers/ocrdma/ocrdma_verbs.c:597:14: warning: implicit conversion from enumeration type 'enum ibv_qp_state' to different enumeration type 'enum ocrdma_qp_state' [-Wenum-conversion]
qp->state = IBV_QPS_RESET;
And it is not wrong. IBV_QPS_RESET=0 and OCRDMA_QPS_RST=0 so this
patch is a NOP.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libocrdma/src/ocrdma_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libocrdma/src/ocrdma_verbs.c b/libocrdma/src/ocrdma_verbs.c
index b3c77c47d660..60626260656d 100644
--- a/libocrdma/src/ocrdma_verbs.c
+++ b/libocrdma/src/ocrdma_verbs.c
@@ -620,7 +620,7 @@ struct ibv_qp *ocrdma_create_qp(struct ibv_pd *pd,
qp->dpp_cq = 0;
}
}
- qp->state = IBV_QPS_RESET;
+ qp->state = OCRDMA_QPS_RST;
INIT_DBLY_LIST_NODE(&qp->sq_entry);
INIT_DBLY_LIST_NODE(&qp->rq_entry);
return &qp->ibv_qp;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 07/23] ocrdma: Fix incorrect type of ibwc_status
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Devesh Sharma
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
clang 3.6 remarks:
../providers/ocrdma/ocrdma_verbs.c:1517:35: warning: implicit conversion from enumeration type 'enum ibv_wc_status' to different enumeration type 'enum ibv_wc_opcode' [-Wenum-conversion]
enum ibv_wc_opcode ibwc_status = IBV_WC_GENERAL_ERR;
And it is not wrong, the enum should be ib_wc_status not opcode.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libocrdma/src/ocrdma_verbs.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libocrdma/src/ocrdma_verbs.c b/libocrdma/src/ocrdma_verbs.c
index 5248e7e26c7b..b3c77c47d660 100644
--- a/libocrdma/src/ocrdma_verbs.c
+++ b/libocrdma/src/ocrdma_verbs.c
@@ -1539,7 +1539,7 @@ int ocrdma_post_recv(struct ibv_qp *ibqp, struct ibv_recv_wr *wr,
static enum ibv_wc_status ocrdma_to_ibwc_err(uint16_t status)
{
- enum ibv_wc_opcode ibwc_status = IBV_WC_GENERAL_ERR;
+ enum ibv_wc_status ibwc_status = IBV_WC_GENERAL_ERR;
switch (status) {
case OCRDMA_CQE_GENERAL_ERR:
ibwc_status = IBV_WC_GENERAL_ERR;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 06/23] nes: Fix clang 3.6 warning -Wtautological-constant-out-of-range-compare
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Tatyana Nikolova
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
clang will miscompile this code because it make assumptions
about the signededness of enums.
Instead create a constant for an invalid ibv_wc_opcode and use that
everywhere. Unsigned enums will use -1, signed enums should use INT_MAX.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libnes/src/nes_uverbs.c | 8 +++++---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/libnes/src/nes_uverbs.c b/libnes/src/nes_uverbs.c
index 12e6222313ad..80891d6243c7 100644
--- a/libnes/src/nes_uverbs.c
+++ b/libnes/src/nes_uverbs.c
@@ -471,13 +471,15 @@ int nes_ima_upoll_cq(struct ibv_cq *cq, int num_entries, struct ibv_wc *entry)
}
while (cqe_count < num_entries) {
- entry->opcode = -1;
+ const enum ibv_wc_opcode INVAL_OP = -1;
+
+ entry->opcode = INVAL_OP;
cqe = &cqes[head];
cqe_misc =
le32_to_cpu(cqe->cqe_words[NES_NIC_CQE_MISC_IDX]);
if (cqe_misc & NES_NIC_CQE_VALID) {
memset(entry, 0, sizeof *entry);
- entry->opcode = -1;
+ entry->opcode = INVAL_OP;
cqe->cqe_words[NES_NIC_CQE_MISC_IDX] = 0;
entry->status = (cqe_misc & NES_NIC_CQE_ERRV_MASK) >>
NES_NIC_CQE_ERRV_SHIFT;
@@ -523,7 +525,7 @@ int nes_ima_upoll_cq(struct ibv_cq *cq, int num_entries, struct ibv_wc *entry)
if (++head >= cq_size)
head = 0;
- if (entry->opcode != -1) {
+ if (entry->opcode != INVAL_OP) {
/* it is possible that no entry will be
available */
cqe_count++;
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 05/23] ipathverbs: Recognize bashisms in truescale-serdes.cmds
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Mike Marciniszyn,
open list:IPATH/QIB USERSPACE PROVIDER for ib_qib.ko
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Debian's Lintian remarks:
E: rdma-plumbing: shell-script-fails-syntax-check usr/lib/truescale-serdes.cmds
And indeed:
$ sh -n providers/ipathverbs/truescale-serdes.cmds
providers/ipathverbs/truescale-serdes.cmds: 100: providers/ipathverbs/truescale-serdes.cmds: Syntax error: "(" unexpected (expecting "}")
This is a bashism, change the script to require bash.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libipathverbs/truescale-serdes.cmds | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libipathverbs/truescale-serdes.cmds b/libipathverbs/truescale-serdes.cmds
index 345813dbfef5..0f8933765efe 100755
--- a/libipathverbs/truescale-serdes.cmds
+++ b/libipathverbs/truescale-serdes.cmds
@@ -1,4 +1,4 @@
-#!/bin/sh
+#!/bin/bash
# Copyright (c) 2013 Intel Corporation. All rights reserved.
# Copyright (c) 2010 QLogic Corporation.
# All rights reserved.
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 04/23] mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Yishai Hadas
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Simply enable -D flags when building.
Use as:
$ cmake -DMLX5_DEBUG=TRUE -DMLX5_MW_DEBUG=TRUE
Reported-by: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
libmlx5/src/CMakeLists.txt | 12 ++++++++++++
1 file changed, 12 insertions(+)
diff --git a/libmlx5/src/CMakeLists.txt b/libmlx5/src/CMakeLists.txt
index a34a8063eeb2..44df83b47d96 100644
--- a/libmlx5/src/CMakeLists.txt
+++ b/libmlx5/src/CMakeLists.txt
@@ -1,3 +1,15 @@
+set(MLX5_DEBUG "FALSE" CACHE BOOL
+ "Enable expensive runtime logging options for the mlx5 verbs provider")
+if (MLX5_DEBUG)
+ add_definitions("-DMLX5_DEBUG")
+endif()
+
+set(MLX5_MW_DEBUG "FALSE" CACHE BOOL
+ "Enable extra validation of memory windows for the mlx5 verbs provider")
+if (MLX5_MW_DEBUG)
+ add_definitions("-DMW_DEBUG")
+endif()
+
rdma_provider(mlx5
buf.c
cq.c
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 03/23] Add reporting bugs and submitting patches sections to README.md
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
From: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
Based on the wording from the libibverbs and srp_daemon README files.
Signed-off-by: Christoph Hellwig <hch-jcswGhMUV9g@public.gmane.org>
---
README.md | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/README.md b/README.md
index 65c7644ad770..8c31944c91a8 100644
--- a/README.md
+++ b/README.md
@@ -95,3 +95,31 @@ $ install -m755 ninja /usr/local/bin/ninja
```
Use the 'cmake3' program in place of `cmake` in the above instructions.
+
+# Reporting bugs
+
+Bugs should be reported to the <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> mailing list
+In your bug report, please include:
+
+ * Information about your system:
+ - Linux distribution and version
+ - Linux kernel and version
+ - InfiniBand hardware and firmware version
+ - ... any other relevant information
+
+ * How to reproduce the bug.
+
+ * If the bug is a crash, the exact output printed out when the crash
+ occurred, including any kernel messages produced.
+
+# Submitting patches
+
+Patches should also be submitted to the <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
+mailing list. Please use unified diff form (the -u option to GNU diff),
+and include a good description of what your patch does and why it should
+be applied. If your patch fixes a bug, please make sure to describe the
+bug and how your fix works.
+
+Make sure that your contribution can be licensed under the same
+license as the original code you are patching, and that you have all
+necessary permissions to release your work.
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 02/23] Move the AUTHORS files into MAINTAINERS
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Mark historical past authors using the 'H:' tag. We don't need this
information sprinkled throughout the tree.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
MAINTAINERS | 13 +++++++++++++
ibacm/AUTHORS | 1 -
iwpmd/AUTHORS | 2 --
libcxgb3/AUTHORS | 1 -
libcxgb4/AUTHORS | 1 -
libhfi1verbs/AUTHORS | 1 -
libi40iw/AUTHORS | 1 -
libibcm/AUTHORS | 2 --
libibumad/AUTHORS | 3 ---
libibverbs/AUTHORS | 4 ----
libipathverbs/AUTHORS | 1 -
libmlx4/AUTHORS | 2 --
libmlx5/AUTHORS | 2 --
libmthca/AUTHORS | 2 --
libnes/AUTHORS | 1 -
libocrdma/AUTHORS | 1 -
librdmacm/AUTHORS | 1 -
17 files changed, 13 insertions(+), 26 deletions(-)
delete mode 100644 ibacm/AUTHORS
delete mode 100644 iwpmd/AUTHORS
delete mode 100644 libcxgb3/AUTHORS
delete mode 100644 libcxgb4/AUTHORS
delete mode 100644 libhfi1verbs/AUTHORS
delete mode 100644 libi40iw/AUTHORS
delete mode 100644 libibcm/AUTHORS
delete mode 100644 libibumad/AUTHORS
delete mode 100644 libibverbs/AUTHORS
delete mode 100644 libipathverbs/AUTHORS
delete mode 100644 libmlx4/AUTHORS
delete mode 100644 libmlx5/AUTHORS
delete mode 100644 libmthca/AUTHORS
delete mode 100644 libnes/AUTHORS
delete mode 100644 libocrdma/AUTHORS
delete mode 100644 librdmacm/AUTHORS
diff --git a/MAINTAINERS b/MAINTAINERS
index 71e8724f87ac..b39529feec9b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11,6 +11,7 @@ Descriptions of section entries:
F: providers/* all files in drivers/net, but not below
F: */net/* all files in "any top level directory"/net
One pattern per line. Multiple F: lines acceptable.
+ H: Historical authors
L: Mailing list that is relevant to this area
M: Designated reviewer: FullName <address@domain>
These reviewers should be CCed on patches.
@@ -73,22 +74,30 @@ F: libipathverbs/
IWARP PORT MAPPER DAEMON (for iwarp kernel providers)
M: Tatyana Nikolova <Tatyana.E.Nikolova-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Robert Sharp <robert.o.sharp-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
S: Supported
F: iwpmd/
LIBIBCM USERSPACE LIBRARY FOR IB CONNECTION MANAGEMENT (/dev/infiniband/ucmX)
M: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Libor Michalek <libor-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Obsolete
F: libibcm/
LIBIBUMAD USERSPACE LIBRARY FOR SMP AND GMP MAD PROCESSING (/dev/infiniband/umadX)
M: Hal Rosenstock <hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
+H: Sasha Khapyorsky <sashak-smomgflXvOZWk0Htik3J/w@public.gmane.org>
+H: Shahar Frank <shahar-smomgflXvOZWk0Htik3J/w@public.gmane.org>
S: Supported
F: libibumad/
LIBIBVERBS USERSPACE LIBRARY FOR RDMA VERBS (/dev/infiniband/uverbsX)
M: Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
M: Yishai Hadas <yishaih-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
+H: Michael S. Tsirkin <mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
+H: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
+H: Dotan Barak <dotanba-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
+H: Roland Dreier <roland-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Supported
F: libibverbs/
@@ -99,16 +108,20 @@ F: librdmacm/
MLX4 USERSPACE PROVIDER (for mlx4_ib.ko)
M: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Roland Dreier <rolandd-FYB4Gu1CFyUAvxtiuMwx3w@public.gmane.org>
S: Supported
F: libmlx4/
MLX5 USERSPACE PROVIDER (for mlx5_ib.ko)
M: Yishai Hadas <yishaih-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Eli Cohen <eli-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
S: Supported
F: libmlx5/
MTHCA USERSPACE PROVIDER (for ib_mthca.ko)
M: Vladimir Sokolovsky <vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
+H: Michael S. Tsirkin <mst-VPRAkNaXOzVS1MOuV/RT9w@public.gmane.org>
+H: Roland Dreier <roland-nF87da4h5whBDgjK7y7TUQ@public.gmane.org>
S: Supported
F: libmthca/
diff --git a/ibacm/AUTHORS b/ibacm/AUTHORS
deleted file mode 100644
index f76b870b4dba..000000000000
diff --git a/iwpmd/AUTHORS b/iwpmd/AUTHORS
deleted file mode 100644
index 10d4e6567693..000000000000
diff --git a/libcxgb3/AUTHORS b/libcxgb3/AUTHORS
deleted file mode 100644
index 5d9d2e254c6c..000000000000
diff --git a/libcxgb4/AUTHORS b/libcxgb4/AUTHORS
deleted file mode 100644
index 5d9d2e254c6c..000000000000
diff --git a/libhfi1verbs/AUTHORS b/libhfi1verbs/AUTHORS
deleted file mode 100644
index 669766569127..000000000000
diff --git a/libi40iw/AUTHORS b/libi40iw/AUTHORS
deleted file mode 100644
index 64c97fbe1f34..000000000000
diff --git a/libibcm/AUTHORS b/libibcm/AUTHORS
deleted file mode 100644
index a694ab7046b6..000000000000
diff --git a/libibumad/AUTHORS b/libibumad/AUTHORS
deleted file mode 100644
index d09c13fe2781..000000000000
diff --git a/libibverbs/AUTHORS b/libibverbs/AUTHORS
deleted file mode 100644
index fcea3504a516..000000000000
diff --git a/libipathverbs/AUTHORS b/libipathverbs/AUTHORS
deleted file mode 100644
index 48d6abcd54b9..000000000000
diff --git a/libmlx4/AUTHORS b/libmlx4/AUTHORS
deleted file mode 100644
index 4d0f22c2632b..000000000000
diff --git a/libmlx5/AUTHORS b/libmlx5/AUTHORS
deleted file mode 100644
index 11cba6b7cb32..000000000000
diff --git a/libmthca/AUTHORS b/libmthca/AUTHORS
deleted file mode 100644
index 165aea78cd02..000000000000
diff --git a/libnes/AUTHORS b/libnes/AUTHORS
deleted file mode 100644
index 64c97fbe1f34..000000000000
diff --git a/libocrdma/AUTHORS b/libocrdma/AUTHORS
deleted file mode 100644
index b930ad385164..000000000000
diff --git a/librdmacm/AUTHORS b/librdmacm/AUTHORS
deleted file mode 100644
index f76b870b4dba..000000000000
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 01/23] Consolidate the .gitignore files
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Remove auto* stuff in the sub directories and replace it with one
copy of cmake stuff in the top level.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
.gitignore | 71 ++++++++++++++++++++++++++++++++++++++++++
libhfi1verbs/.gitignore | 18 -----------
libibverbs/.gitignore | 24 --------------
libibverbs/examples/.gitignore | 10 ------
libibverbs/src/.gitignore | 3 --
libipathverbs/.gitignore | 22 -------------
libmlx4/.gitignore | 17 ----------
libmlx4/src/.gitignore | 3 --
libmlx5/.gitignore | 33 --------------------
libmlx5/src/.gitignore | 3 --
libmthca/.gitignore | 17 ----------
libmthca/src/.gitignore | 3 --
librdmacm/.gitignore | 64 -------------------------------------
librdmacm/examples/.gitignore | 23 --------------
librdmacm/src/.gitignore | 9 ------
srp_daemon/.gitignore | 18 -----------
16 files changed, 71 insertions(+), 267 deletions(-)
create mode 100644 .gitignore
delete mode 100644 libhfi1verbs/.gitignore
delete mode 100644 libibverbs/.gitignore
delete mode 100644 libibverbs/examples/.gitignore
delete mode 100644 libibverbs/src/.gitignore
delete mode 100644 libipathverbs/.gitignore
delete mode 100644 libmlx4/.gitignore
delete mode 100644 libmlx4/src/.gitignore
delete mode 100644 libmlx5/.gitignore
delete mode 100644 libmlx5/src/.gitignore
delete mode 100644 libmthca/.gitignore
delete mode 100644 libmthca/src/.gitignore
delete mode 100644 librdmacm/.gitignore
delete mode 100644 librdmacm/examples/.gitignore
delete mode 100644 librdmacm/src/.gitignore
delete mode 100644 srp_daemon/.gitignore
diff --git a/.gitignore b/.gitignore
new file mode 100644
index 000000000000..f31a0617882d
--- /dev/null
+++ b/.gitignore
@@ -0,0 +1,71 @@
+# -*- mode: gitignore; -*-
+# CMake
+cmake_install.cmake
+CMakeFiles
+CMakeCache.txt
+lib*.a
+/bin/**
+/lib/**
+/include/**
+/.ninja*
+*.ninja
+Makefile
+
+# Tags
+TAGS
+.TAGS
+!TAGS/
+tags
+.tags
+!tags/
+gtags.files
+GTAGS
+GRTAGS
+GPATH
+
+# cscope
+cscope.files
+cscope.out
+cscope.in.out
+cscope.po.out
+
+# Emacs
+*~
+\#*\#
+/.emacs.desktop
+/.emacs.desktop.lock
+*.elc
+auto-save-list
+tramp
+.\#*
+
+# Org-mode
+.org-id-locations
+*_archive
+
+# flymake-mode
+*_flymake.*
+
+# eshell files
+/eshell/history
+/eshell/lastdir
+
+# elpa packages
+/elpa/
+
+# reftex files
+*.rel
+
+# AUCTeX auto folder
+/auto/
+
+# cask packages
+.cask/
+
+# vim
+[._]*.s[a-w][a-z]
+[._]s[a-w][a-z]
+*.un~
+Session.vim
+.netrwhist
+*~
diff --git a/libhfi1verbs/.gitignore b/libhfi1verbs/.gitignore
deleted file mode 100644
index 1fd7e821926c..000000000000
diff --git a/libibverbs/.gitignore b/libibverbs/.gitignore
deleted file mode 100644
index 9fb29eae8cd4..000000000000
diff --git a/libibverbs/examples/.gitignore b/libibverbs/examples/.gitignore
deleted file mode 100644
index ebecbdc0cf56..000000000000
diff --git a/libibverbs/src/.gitignore b/libibverbs/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libipathverbs/.gitignore b/libipathverbs/.gitignore
deleted file mode 100644
index 007a003f6e53..000000000000
diff --git a/libmlx4/.gitignore b/libmlx4/.gitignore
deleted file mode 100644
index 4c45b0912563..000000000000
diff --git a/libmlx4/src/.gitignore b/libmlx4/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libmlx5/.gitignore b/libmlx5/.gitignore
deleted file mode 100644
index 7878db2d068e..000000000000
diff --git a/libmlx5/src/.gitignore b/libmlx5/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/libmthca/.gitignore b/libmthca/.gitignore
deleted file mode 100644
index 43f0908f1de0..000000000000
diff --git a/libmthca/src/.gitignore b/libmthca/src/.gitignore
deleted file mode 100644
index 7297cbb20ade..000000000000
diff --git a/librdmacm/.gitignore b/librdmacm/.gitignore
deleted file mode 100644
index cea1f714f199..000000000000
diff --git a/librdmacm/examples/.gitignore b/librdmacm/examples/.gitignore
deleted file mode 100644
index ce9156d4a97f..000000000000
diff --git a/librdmacm/src/.gitignore b/librdmacm/src/.gitignore
deleted file mode 100644
index 139417a24de1..000000000000
diff --git a/srp_daemon/.gitignore b/srp_daemon/.gitignore
deleted file mode 100644
index b055c68141c3..000000000000
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH 00/23] rdma-core Trivial fixes and documentation updates
From: Jason Gunthorpe @ 2016-09-21 22:08 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA
This is the next batch of fixes, the 23 patches are all straight forward and
should be uncontroversial. Most are documentation updates, plus a few
obviously correct fixes from static checkers.
Please forward Acks and I will apply this to the github soonish.
The tree is here:
https://github.com/linux-rdma/rdma-core
View the patches on github:
https://github.com/linux-rdma/rdma-core/pull/2
Christoph Hellwig (6):
Add reporting bugs and submitting patches sections to README.md
verbs: Move documentation to Documentation/
rdmacm: Move documentation to Documentation/
ibcm: Move documentation to Documentation/
rxe: Move documentation to Documentation/
srp_daemon: Move documentation to Documentation/
Jason Gunthorpe (16):
Consolidate the .gitignore files
Move the AUTHORS files into MAINTAINERS
mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
ipathverbs: Recognize bashisms in truescale-serdes.cmds
nes: Fix clang 3.6 warning
-Wtautological-constant-out-of-range-compare
ocrdma: Fix incorrect type of ibwc_status
ocrdma: Fix incorrect enum constant
verbs: Fix incorrect type of len
verbs: Use inttypes.h format string macros
rdmacm: Use correct format specifier for size_t
rdmacm: Fix leading \'s in rcopy man page
rdmacm: Fix typos
umad: Replace .nl with .sp in man pages
iwpmd: Install ancillary files for iwpm
iwpmd: Remove syslog.target from service file
srp_daemon: Use SRP_DEFAULT_START/STOP for substitution
Steve Wise (1):
iwpmd: Add man pages
.gitignore | 71 +++++++++++
CMakeLists.txt | 1 +
Documentation/ibsrpdm.md | 41 +++++++
libibcm/README => Documentation/libibcm.md | 14 +--
Documentation/libibverbs.md | 58 +++++++++
librdmacm/README => Documentation/librdmacm.md | 27 +---
Documentation/rxe.md | 22 ++++
MAINTAINERS | 13 ++
README.md | 28 +++++
ibacm/AUTHORS | 1 -
iwpmd/AUTHORS | 2 -
iwpmd/CMakeLists.txt | 4 +
iwpmd/iwpmd.1 | 56 +++++++++
iwpmd/iwpmd.conf.5 | 20 +++
iwpmd/iwpmd.service | 2 +-
iwpmd/src/CMakeLists.txt | 10 +-
libcxgb3/AUTHORS | 1 -
libcxgb4/AUTHORS | 1 -
libhfi1verbs/.gitignore | 18 ---
libhfi1verbs/AUTHORS | 1 -
libi40iw/AUTHORS | 1 -
libibcm/AUTHORS | 2 -
libibumad/AUTHORS | 3 -
libibumad/man/umad_get_ca.3 | 2 +-
libibumad/man/umad_get_port.3 | 2 +-
libibumad/man/umad_init.3 | 2 +-
libibverbs/.gitignore | 24 ----
libibverbs/AUTHORS | 4 -
libibverbs/README | 164 -------------------------
libibverbs/examples/.gitignore | 10 --
libibverbs/examples/devinfo.c | 4 +-
libibverbs/src/.gitignore | 3 -
libipathverbs/.gitignore | 22 ----
libipathverbs/AUTHORS | 1 -
libipathverbs/truescale-serdes.cmds | 2 +-
libmlx4/.gitignore | 17 ---
libmlx4/AUTHORS | 2 -
libmlx4/src/.gitignore | 3 -
libmlx5/.gitignore | 33 -----
libmlx5/AUTHORS | 2 -
libmlx5/src/.gitignore | 3 -
libmlx5/src/CMakeLists.txt | 12 ++
libmthca/.gitignore | 17 ---
libmthca/AUTHORS | 2 -
libmthca/src/.gitignore | 3 -
libnes/AUTHORS | 1 -
libnes/src/nes_uverbs.c | 8 +-
libocrdma/AUTHORS | 1 -
libocrdma/src/ocrdma_verbs.c | 4 +-
librdmacm/.gitignore | 64 ----------
librdmacm/AUTHORS | 1 -
librdmacm/examples/.gitignore | 23 ----
librdmacm/examples/rping.c | 2 +-
librdmacm/examples/udpong.c | 2 +-
librdmacm/include/rdma/rdma_cma.h | 2 +-
librdmacm/man/mckey.1 | 2 +-
librdmacm/man/rcopy.1 | 6 +-
librdmacm/man/rdma_cm.7 | 4 +-
librdmacm/man/rdma_migrate_id.3 | 2 +-
librdmacm/man/rdma_post_write.3 | 2 +-
librdmacm/man/rdma_post_writev.3 | 2 +-
librdmacm/man/rdma_reg_msgs.3 | 2 +-
librdmacm/man/rdma_set_option.3 | 2 +-
librdmacm/src/.gitignore | 9 --
librxe/README.md | 63 ----------
srp_daemon/.gitignore | 18 ---
srp_daemon/README | 82 -------------
srp_daemon/srp_daemon/CMakeLists.txt | 4 +-
srp_daemon/srp_daemon/srpd.in | 4 +-
69 files changed, 372 insertions(+), 669 deletions(-)
create mode 100644 .gitignore
create mode 100644 Documentation/ibsrpdm.md
rename libibcm/README => Documentation/libibcm.md (54%)
create mode 100644 Documentation/libibverbs.md
rename librdmacm/README => Documentation/librdmacm.md (65%)
create mode 100644 Documentation/rxe.md
delete mode 100644 ibacm/AUTHORS
delete mode 100644 iwpmd/AUTHORS
create mode 100644 iwpmd/CMakeLists.txt
create mode 100644 iwpmd/iwpmd.1
create mode 100644 iwpmd/iwpmd.conf.5
delete mode 100644 libcxgb3/AUTHORS
delete mode 100644 libcxgb4/AUTHORS
delete mode 100644 libhfi1verbs/.gitignore
delete mode 100644 libhfi1verbs/AUTHORS
delete mode 100644 libi40iw/AUTHORS
delete mode 100644 libibcm/AUTHORS
delete mode 100644 libibumad/AUTHORS
delete mode 100644 libibverbs/.gitignore
delete mode 100644 libibverbs/AUTHORS
delete mode 100644 libibverbs/README
delete mode 100644 libibverbs/examples/.gitignore
delete mode 100644 libibverbs/src/.gitignore
delete mode 100644 libipathverbs/.gitignore
delete mode 100644 libipathverbs/AUTHORS
delete mode 100644 libmlx4/.gitignore
delete mode 100644 libmlx4/AUTHORS
delete mode 100644 libmlx4/src/.gitignore
delete mode 100644 libmlx5/.gitignore
delete mode 100644 libmlx5/AUTHORS
delete mode 100644 libmlx5/src/.gitignore
delete mode 100644 libmthca/.gitignore
delete mode 100644 libmthca/AUTHORS
delete mode 100644 libmthca/src/.gitignore
delete mode 100644 libnes/AUTHORS
delete mode 100644 libocrdma/AUTHORS
delete mode 100644 librdmacm/.gitignore
delete mode 100644 librdmacm/AUTHORS
delete mode 100644 librdmacm/examples/.gitignore
delete mode 100644 librdmacm/src/.gitignore
delete mode 100644 librxe/README.md
delete mode 100644 srp_daemon/.gitignore
delete mode 100644 srp_daemon/README
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 00/16] Consolidated RDMA userspace: rdma-core
From: Doug Ledford @ 2016-09-21 22:01 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA
Cc: Amrani, Ram, Adit Ranadive, Bart Van Assche, Christoph Hellwig,
Dalessandro, Dennis, Devesh Sharma, Donald Dutile, Hal Rosenstock,
Honggang Li, Jarod Wilson, John Jolly, Kamal Heib, Knut Omang,
Leon Romanovsky, Mike Marciniszyn, Moni Shoua, Sean Hefty,
Selvin Xavier, Steve Wise, Tatyana Nikolova <Tatyana.E.Nik>
In-Reply-To: <1474409425-15769-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 2191 bytes --]
On 9/20/2016 6:10 PM, Jason Gunthorpe wrote:
> Hello Everyone,
>
> We are starting the transition to the consolidated user space. Doug has setup
> a shared github here:
>
> https://github.com/linux-rdma/rdma-core
>
> Which now contains the base 'merge' commit, this is simply each of the
> original 18 repositories placed in a sub directory, unmodified.
>
> This tree will not be rebased. New work can target this tree.
>
> An earlier version of the patch series that follows has already been
> posted, and has been part of my preview tree for some time. The
> original mailing list threads are here:
>
> http://www.spinics.net/lists/linux-rdma/msg39026.html
> http://www.spinics.net/lists/linux-rdma/msg39328.html
> http://www.spinics.net/lists/linux-rdma/msg40014.html
> http://www.spinics.net/lists/linux-rdma/msg40086.html
>
> This series to unify the build system (+ any comments) will be applied to the
> tree right away and Doug + Leon will start generally accepting patches.
>
> My preview tree:
> https://github.com/jgunthorpe/rdma-plumbing
>
> Contains another ~70 patches which will be batched up and posted to this list
> for review. Notably those patches include the sample RPM and DEB packaging,
> and other packaging related items.
>
> Jason
>
> Christoph Hellwig (2):
> Remove README files in the provider directories
> Remove iwpmd/README
>
> Jason Gunthorpe (14):
> Fix bogus executable file permissions
> Include pthreads in the provider libraries
> Be explicit about _GNU_SOURCE
> hfi/ipath: Use the name of the provider for the .driver file
> ibcm: Actually use the version script when linking
> iwpm: Update autotools enough to build
> rdmacm: Control symbol export from librspreload
> Unified CMake build system
> Support obsolete cmake from 2013
> Add a MAINTAINERS file
> Remove the auto* based build systems
> Remove the ChangeLog files
> Remove Debian and RPM packaging files
> ibacm: Remove windows support files
It's looking good. Nice work Jason.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
* RE: [PATCH 14/16] ibacm: Remove windows support files
From: Hefty, Sean @ 2016-09-21 20:17 UTC (permalink / raw)
To: Jason Gunthorpe,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <1474409425-15769-15-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> Building these is no longer supported.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
Thanks
Acked-by: Sean Hefty <sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [RFC v2 07/12] qedr: Add support for memory registeration verbs
From: Sagi Grimberg @ 2016-09-21 19:53 UTC (permalink / raw)
To: Ram Amrani, davem, dledford
Cc: Ariel.Elior, Michal.Kalderon, Yuval.Mintz, rajesh.borundia,
linux-rdma, netdev
In-Reply-To: <1474367764-9555-8-git-send-email-Ram.Amrani@cavium.com>
> +static int qedr_set_page(struct ib_mr *ibmr, u64 addr)
> +{
> + struct qedr_mr *mr = get_qedr_mr(ibmr);
> + struct qedr_pbl *pbl_table;
> + struct regpair *pbe;
> + u32 pbes_in_page;
> +
> + if (unlikely(mr->npages == mr->info.pbl_info.num_pbes)) {
> + DP_ERR(mr->dev, "qedr_set_page failes when %d\n", mr->npages);
> + return -ENOMEM;
> + }
> +
> + DP_VERBOSE(mr->dev, QEDR_MSG_MR, "qedr_set_page pages[%d] = 0x%llx\n",
> + mr->npages, addr);
> +
> + pbes_in_page = mr->info.pbl_info.pbl_size / sizeof(u64);
> + pbl_table = mr->info.pbl_table + (mr->npages / pbes_in_page);
> + pbe = (struct regpair *)pbl_table->va;
> + pbe += mr->npages % pbes_in_page;
> + pbe->lo = cpu_to_le32((u32)addr);
> + pbe->hi = cpu_to_le32((u32)upper_32_bits(addr));
> +
> + mr->npages++;
> +
> + return 0;
> +}
Looks better.
Reviewed-by: Sagi Grimberg <sagi@grimberg.me>
^ permalink raw reply
* Re: [RFCv2 00/15] RFCv2: Consolidated userspace RDMA library repo
From: ira.weiny @ 2016-09-21 17:21 UTC (permalink / raw)
To: Doug Ledford
Cc: Leon Romanovsky, Jason Gunthorpe, Jarod Wilson, Steve Wise,
linux-rdma-u79uwXL29TY76Z2rM5mHXA, 'Devesh Sharma',
'Hal Rosenstock', 'Mike Marciniszyn',
'Moni Shoua', 'Sean Hefty',
'Tatyana Nikolova', 'Vladimir Sokolovsky',
'Yishai Hadas'
In-Reply-To: <fcfcff11-fe5c-6cf5-3575-52da4b9241ed-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
>
> Unfortunataely, what you speak of is not really realistic, both for the
> reasons I've cited and a whole litany of other reasons I didn't mention.
>
> But I don't think Jason jumped in to work on this because of the goal of
> making Red Hat's life easier in packaging up the separate code. He did
> it for upstream related reasons:
>
> 1) Put all of the providers and libibverbs in one place so that they can
> be kept in sync. This allows us to do the exact same thing we do with
> the kernel in user space. Namely, if someone makes an incompatible
> change in the libibverbs core, we can require that they fix up all
> providers in the same patch series. This works rather well for the
> kernel, and it would be good to bring that policy to user space too.
>
> 2) Put all of the kernel interacting libraries in one place. This makes
> it easier to perform the write->ioctl conversion we've been discussing
> as there would be only one larger package that needs to be updated for
> any given kernel ioctl update.
>
> 3) Bring librdmacm and libibverbs together so that the occasional
> incompatible update between the two is not an issue any more.
>
> 4) Create an easier to build/install package for developers to use.
>
> Those are the issues we should be discussing the relative merits of in
> order to determine whether this work should be adopted.
>
I see one more benefit here. This should give us an opportunity to consolidate
and clarify the interface to the _users_ of these libraries. For example it
has always bothered me is there are about 3 places that a PathRecord struct was
defined. To be clear I think PathRecords should be hidden from the user but in
general keeping a clean interface to the user between librdmacm, libibverbs,
and to a lesser extent (or maybe not at all) libibumad would be very nice for
the end user.
Ira
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v3 0/9] SELinux support for Infiniband RDMA
From: ira.weiny @ 2016-09-21 16:16 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Daniel Jurgens, Liran Liss, Paul Moore, Leon Romanovsky,
chrisw@sous-sol.org, Stephen Smalley, Eric Paris,
dledford@redhat.com, sean.hefty@intel.com,
hal.rosenstock@gmail.com, selinux@tycho.nsa.gov,
linux-security-module@vger.kernel.org, linux-rdma@vger.kernel.org,
Yevgeny Petrilin
In-Reply-To: <20160908193235.GA1868@obsidianresearch.com>
On Thu, Sep 08, 2016 at 01:32:35PM -0600, Jason Gunthorpe wrote:
> On Thu, Sep 08, 2016 at 06:59:13PM +0000, Daniel Jurgens wrote:
>
> > >> Net has variety of means of enforcement, one of which is controlling
> > >> access to ports <tcp/udp,port number>, which is the most like what
> > >> I'm doing here.
> > > No, the analog the tcp/udp,port number is <ib, service_id>
>
> > I should have been clearer here. From the SELinux perspective this
> > scheme is very similar to net ports.
>
> It really isn't. net ports and service_ids are global things that do
> not need machine-specific customizations while subnet prefix or device
> name/port are both machine-local information.
I agree that service_ids are more analogous to net ports.
However, subnet prefixes are _not_ machine-local. They are controlled by the
Admin of the fabric by a central entity (the SM). This is more helpful than in
ethernet where if you configure the wrong port with the wrong subnet things
just don't work. In IB I can physically plug my network into any IB port I
want and the system is _told_ which "subnet" that port belongs to. (OPA is the
same way.)
So for IB/OPA a subnet prefix is a really good way to ID which network (subnet)
you want to use. Unfortunately, I'm not sure how to translate that to
iwarp/roce seamlessly except to have some concept of "domain" as I mentioned in
my other email.
Ira
^ permalink raw reply
* Re: [PATCHv12 1/3] rdmacg: Added rdma cgroup controller
From: Parav Pandit @ 2016-09-21 16:02 UTC (permalink / raw)
To: Tejun Heo
Cc: Leon Romanovsky, Jason Gunthorpe, Christoph Hellwig, Matan Barak,
cgroups-u79uwXL29TY76Z2rM5mHXA, linux-doc-u79uwXL29TY76Z2rM5mHXA,
Linux Kernel Mailing List, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Li Zefan, Johannes Weiner, Doug Ledford, Liran Liss, Hefty, Sean,
Haggai Eran, Jonathan Corbet,
james.l.morris-QHcLZuEGTsvQT0dZR+AlfA,
serge-A9i7LUbDfNHQT0dZR+AlfA, Or Gerlitz, Andrew Morton,
linux-security-module-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160921142645.GB10734-piEFEHQLUPpN0TnZuCh8vA@public.gmane.org>
Hi Tejun,
On Wed, Sep 21, 2016 at 7:56 PM, Tejun Heo <tj-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org> wrote:
> Hello, Parav.
>
> On Wed, Sep 21, 2016 at 10:13:38AM +0530, Parav Pandit wrote:
>> We have completed review from Tejun, Christoph.
>> HFI driver folks also provided feedback for Intel drivers.
>> Matan's also doesn't have any more comments.
>>
>> If possible, if you can also review, it will be helpful.
>>
>> I have some more changes unrelated to cgroup in same files in both the git tree.
>> Pushing them now either results into merge conflict later on for
>> Doug/Tejun, or requires rebase and resending patch.
>> If you can review, we can avoid such rework.
>
> My impression of the thread was that there doesn't seem to be enough
> of consensus around how rdma resources should be defined. Is that
> part agreed upon now?
>
We ended up discussing few points on different thread [1].
There was confusion on how some non-rdma/non-IB drivers would work
with rdma cgroup from Matan.
Christoph explained how they don't fit in the rdma subsystem and
therefore its not prime target to addess.
Intel driver maintainer Denny also acknowledged same on [2].
IB compliant drivers of Intel support rdma cgroup as explained in [2].
With that usnic and Intel psm drivers falls out of rdma cgroup support
as they don't fit very well in the verbs definition.
[1] https://www.spinics.net/lists/linux-rdma/msg40340.html
[2] http://www.spinics.net/lists/linux-rdma/msg40717.html
I will wait for Leon's review comments if he has different view on architecture.
Back in April when I met face-to-face to Leon and Haggai, Leon was in
support to have kernel defined the rdma resources as suggested by
Christoph and Tejun instead of IB/RDMA subsystem.
I will wait for his comments if his views have changed with new uAPI
taking shape.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [RFC v2 06/12] qedr: Add support for QP verbs
From: Jason Gunthorpe @ 2016-09-21 15:55 UTC (permalink / raw)
To: Amrani, Ram
Cc: davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, Elior, Ariel,
Kalderon, Michal, Mintz, Yuval, Borundia, Rajesh,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
In-Reply-To: <SN1PR07MB2207B94372F7A910C0E6AF0AF8F60-mikhvbZlbf8TSoR2DauN2+FPX92sqiQdvxpqHgZTriW3zl9H0oFU5g@public.gmane.org>
On Wed, Sep 21, 2016 at 02:23:46PM +0000, Amrani, Ram wrote:
> > Ugh, each patch keeps adding to this?
>
> The logic in the patch series is to have each patch contain only
> what is necessary for the specific functionality it adds. This made
> it harder on us to prepare but, IMHO, easier for the reviewer. If
> you'd like to have this file in one chunk, I can do this. What do
> you prefer?
I wouldn't change anything at this point, but I'm not sure it is
easier to review like this than the one patch per file scheme.
Do you have a git tree?
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox