* RE: rdma-core, cmake/ninja question
From: Steve Wise @ 2016-09-22 19:34 UTC (permalink / raw)
To: 'Jason Gunthorpe'; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160922192932.GA25659-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> On Thu, Sep 22, 2016 at 01:43:36PM -0500, Steve Wise wrote:
>
> > > Apply this patch:
> > >
> > > https://github.com/jgunthorpe/rdma-
> > > plumbing/commit/64ed4fd30a2157bdaf0a8f7f1b04d2dad02c1b8f
> > >
> > > It hardwires the search path into libverbs and libverbs will look into
> > > the place it was installed before searching the system library
> > > path. That will eliminate the problem you mentioned above.
> > >
> > > Further, after that patch is applied you can do a rough imitation of
> > > 'run-in-place' like this:
> > >
> > > $ cmake .. -DVERBS_PROVIDER_DIR:PATH=`pwd`/lib -
> > > DSYSCONF_INSTALL_DIR:PATH=/etc
> > >
> >
> > And how do I build this after the cmake?
>
> Sorry, you always need the -GNinja, I was just being brief
>
> I also mistyped the ETC name.
>
> I tested this:
>
> $ mkdir build ; cd build
> $ cmake .. -GNinja -DVERBS_PROVIDER_DIR:PATH=`pwd`/lib -
> DCMAKE_INSTALL_SYSCONFDIR:PATH=/etc
> $ ninja
> $ strace bin/ibv_devinfo 2>&1 | grep -i rdmav2
> open("/tmp/rdma-core/build/lib/libmlx4-rdmav2.so", O_RDONLY|O_CLOEXEC) = 3
>
> Note LD_LIBRARY_PATH is needed to run things from outside build/bin/
>
> I have some thoughts to make this simpler, call it a proof of concept for
> run-from-build ..
>
No worries. I'm just thick headed. :) Its working for me. I've made a change
to libcxgb4 and can test by running in the build tree. I compile with and
without my change and see that the correct libcxgb4 is being used. Ship it! :)
So if I have a libcxgb4 change to submit, I should submit it against rdma-core,
ja?
Thanks Jason!
Steve.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: rdma-core, cmake/ninja question
From: Jason Gunthorpe @ 2016-09-22 19:38 UTC (permalink / raw)
To: Steve Wise; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <01a301d21508$559b52d0$00d1f870$@opengridcomputing.com>
On Thu, Sep 22, 2016 at 02:34:28PM -0500, Steve Wise wrote:
> So if I have a libcxgb4 change to submit, I should submit it against rdma-core,
> ja?
Yes, Doug or Leon will apply it.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH v3 0/6] server-side NFS/RDMA patches proposed for v4.9
From: J. Bruce Fields @ 2016-09-22 20:38 UTC (permalink / raw)
To: Chuck Lever
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA,
linux-nfs-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160913144246.5733.66229.stgit-Hs+gFlyCn65vLzlybtyyYzGyq/o6K9yX@public.gmane.org>
On Tue, Sep 13, 2016 at 10:52:33AM -0400, Chuck Lever wrote:
> Hi Bruce-
>
> These are ready for you to consider for your "for v4.9" branch. They
> include:
Sorry for the delay--applying for for 4.9.--b.
>
> - Fix a couple of reference counting issues
> - Introduce simple RDMA-CM private message exchange
> - Support Remote Invalidation
>
> Available in the "nfsd-rdma-for-4.9" topic branch of this git repo:
>
> git://git.linux-nfs.org/projects/cel/cel-2.6.git
>
>
> Or for browsing:
>
> http://git.linux-nfs.org/?p=cel/cel-2.6.git;a=log;h=refs/heads/nfsd-rdma-for-4.9
>
>
> Changes since v2:
> - Rebased on v4.8-rc6
> - "SUNRPC: Silence WARN_ON when NFSv4.1 over RDMA is in use" has been merged
> - Revert 64c59a3726f2 (add a "Cc: stable" if you think that's appropriate)
>
>
> Changes since v1:
> - Rebased on v4.8-rc3
> - Added Reviewed-by tags
> - Fixed additional bugs found in v4.8
>
>
> ---
>
> Chuck Lever (6):
> svcauth_gss: Revert 64c59a3726f2 ("Remove unnecessary allocation")
> svcrdma: Tail iovec leaves an orphaned DMA mapping
> svcrdma: Skip put_page() when send_reply() fails
> rpcrdma: RDMA/CM private message data structure
> svcrdma: Server-side support for rpcrdma_connect_private
> svcrdma: support Remote Invalidation
>
>
> include/linux/sunrpc/rpc_rdma.h | 35 ++++++++++++
> include/linux/sunrpc/svc_rdma.h | 10 +++
> net/sunrpc/auth_gss/svcauth_gss.c | 5 +-
> net/sunrpc/xprtrdma/svc_rdma_backchannel.c | 2 -
> net/sunrpc/xprtrdma/svc_rdma_recvfrom.c | 2 -
> net/sunrpc/xprtrdma/svc_rdma_sendto.c | 82 ++++++++++++++++++++--------
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 60 +++++++++++++++++---
> 7 files changed, 159 insertions(+), 37 deletions(-)
>
> --
> Chuck Lever
--
To unsubscribe from this list: send the line "unsubscribe linux-nfs" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH 22/23] srp_daemon: Move documentation to Documentation/
From: Bart Van Assche @ 2016-09-23 0:07 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Christoph Hellwig
In-Reply-To: <1474495729-17604-23-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
On 09/21/2016 03:08 PM, Jason Gunthorpe wrote:
> [ ... ]
Reviewed-by: Bart Van Assche <bart.vanassche-XdAiOPVOjttBDgjK7y7TUQ@public.gmane.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH rdma-core] Improve global COPYING files
From: Jason Gunthorpe @ 2016-09-23 4:13 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA; +Cc: Doug Ledford, Leon Romanovsky
Upon deeper analysis it seems there are two variations of the 'OpenIB.org BSD
license', I am calling them the MIT and FreeBSD variants. They differ only in
the text of the disclaimer. The MIT version is used widely as the source
license so that version should be the 'default' in the source tree, not the
FreeBSD version I had selected initially.
Retain the FreeBSD version as we will refer to it in future commits.
Elaborate the COPYING file to discuss the license situation in
more depth.
Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
---
COPYING | 6 ------
COPYING.BSD | 26 ----------------------
COPYING.BSD_FB | 22 +++++++++++++++++++
COPYING.BSD_MIT | 20 +++++++++++++++++
COPYING.md | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
5 files changed, 109 insertions(+), 32 deletions(-)
delete mode 100644 COPYING
delete mode 100644 COPYING.BSD
create mode 100644 COPYING.BSD_FB
create mode 100644 COPYING.BSD_MIT
create mode 100644 COPYING.md
I have reviewed most of the files now for copyright considerations to
make sure our licensing is in order.
This is my proposal for the top level COPYING file, and it contains a
summary of my findings on licensing.
Due to various mistakes in the past things are overly complex, I would
appreciate any patches to reduce the complexity. eg ensuring that all
files have a license reference and the removal of the sub dir COPYING
files.
It would be appreciated if those who hold the copyrights can adjust
their licenses to match the so-called 'Default Dual License', eg by
patching the remaining COPYING files to use the correct disclaimer.
Here is my first jab at simplifying:
https://github.com/jgunthorpe/rdma-plumbing/commit/079d840b102906c79ff07b7fe9d5db6bba26517c
diff --git a/COPYING b/COPYING
deleted file mode 100644
index ac58180e900c..000000000000
--- a/COPYING
+++ /dev/null
@@ -1,6 +0,0 @@
-Unless otherwise stated this software is available to you under a choice of
-one of two licenses. You may choose to be licensed under the terms of the the
-OpenIB.org BSD license (see COPYING.BSD) or the GNU General Public License
-(GPL) Version 2 (see COPYING.GPL2), both included in this package.
-
-Refer to individual files for information on the copyright holders.
diff --git a/COPYING.BSD b/COPYING.BSD
deleted file mode 100644
index 59b3a397a13b..000000000000
--- a/COPYING.BSD
+++ /dev/null
@@ -1,26 +0,0 @@
- OpenIB.org BSD license
-
-Redistribution and use in source and binary forms, with or without
-modification, are permitted provided that the following conditions
-are met:
-
- * Redistributions of source code must retain the above copyright
- notice, this list of conditions and the following disclaimer.
-
- * Redistributions in binary form must reproduce the above
- copyright notice, this list of conditions and the following
- disclaimer in the documentation and/or other materials provided
- with the distribution.
-
-THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
-"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
-LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
-FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
-COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
-INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
-BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
-LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
-CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
-LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
-ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
-POSSIBILITY OF SUCH DAMAGE.
diff --git a/COPYING.BSD_FB b/COPYING.BSD_FB
new file mode 100644
index 000000000000..44237612faa3
--- /dev/null
+++ b/COPYING.BSD_FB
@@ -0,0 +1,22 @@
+ OpenIB.org BSD license (FreeBSD Variant)
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+ - Redistributions of source code must retain the above copyright notice,
+ this list of conditions and the following disclaimer.
+
+ - Redistributions in binary form must reproduce the above copyright notice,
+ this list of conditions and the following disclaimer in the documentation
+ and/or other materials provided with the distribution.
+
+THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
+AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
+IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
+DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
+FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
+DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
+SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
+CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
+OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
+OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
diff --git a/COPYING.BSD_MIT b/COPYING.BSD_MIT
new file mode 100644
index 000000000000..a1432b6134e6
--- /dev/null
+++ b/COPYING.BSD_MIT
@@ -0,0 +1,20 @@
+ OpenIB.org BSD license (MIT variant)
+
+Redistribution and use in source and binary forms, with or without
+modification, are permitted provided that the following conditions are met:
+
+ - Redistributions of source code must retain the above copyright notice,
+ this list of conditions and the following disclaimer.
+
+ - Redistributions in binary form must reproduce the above copyright notice,
+ this list of conditions and the following disclaimer in the documentation
+ and/or other materials provided with the distribution.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
+AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
+OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
+SOFTWARE.
+
diff --git a/COPYING.md b/COPYING.md
new file mode 100644
index 000000000000..edcb01af9954
--- /dev/null
+++ b/COPYING.md
@@ -0,0 +1,67 @@
+# Default Dual License
+
+Unless otherwise stated this software is available to you under a choice of
+one of two licenses. You may choose to be licensed under the terms of the the
+OpenIB.org BSD (MIT variant) license (see COPYING.BSD_MIT) or the GNU General
+Public License (GPL) Version 2 (see COPYING.GPL2), both included in this
+package.
+
+Files marked 'See COPYING file' are licensed under the above Dual License.
+
+# Other Options
+
+Individual source files may use a license different from the above Defaul Dual
+License. If a license is declared in the file then it supersedes the Default
+License.
+
+If a directory contains a COPYING file then the License from that file becomes
+the Default License for files in that directory and below.
+
+# Copyright Holders
+
+Refer to individual files for information on the copyright holders.
+
+# License Catalog (Informative, Non Binding)
+
+## Providers
+
+The following providers use a different license than the Default Dual
+License. Refer to files in each directory for details.
+
+cxbg4
+: A combination of the
+ - Default Dual License
+ - cxgb4/src/queue.h: BSD 3 clause license.
+
+hfi1verbs
+: Dual License: GPLv2 or Intel 3 clause BSD license
+
+ipathverbs
+: Dual License: GPLv2 or PathScale BSD Patent license
+
+ocrdma
+: Dual License: GPLv2 or OpenIB.org BSD (FreeBSD variant), See COPYING.BSD_FB
+
+rxe
+: A combination of the
+ - Default Dual License
+ - GPLv2 or PathScale BSD Patent license
+
+## Libraries
+
+All library compilable source code (.c and .h files) are available under the
+Default Dual License.
+
+Unmarked ancillary files may be available under a Dual License: GPLv2 or
+OpenIB.org BSD (FreeBSD variant).
+
+## Tools (iwpmd, srp_deamon, ibacm)
+
+All compilable source code (.c and .h files) are available under the Default
+Dual License.
+
+Unmarked ancillary files may be available under a Dual License: GPLv2 or
+OpenIB.org BSD (FreeBSD variant).
+
+srp_daemon/srp_daemon/srp_daemon.sh: Any one of the GPLv2, a 2 clause BSD
+license or the CPLv1.
--
2.7.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* [PATCH infiniband-diags] ibportstate: Fixed peer port probing when using DR routing
From: Knut Omang @ 2016-09-23 6:42 UTC (permalink / raw)
To: Ira Weiny
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Line Holen, Knut Omang,
Dag Moxnes
From: Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
When querying a remote port using ibportportstate, queries to the peer port
would result in timeouts. The reason for this is that the DR path (or partial
DR path was not correctly constructed.
Signed-off-by: Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Reviewed-by: Line Holen <line.holen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Signed-off-by: Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
---
src/ibportstate.c | 36 +++++++++++++++++++++++++++---------
1 file changed, 27 insertions(+), 9 deletions(-)
diff --git a/src/ibportstate.c b/src/ibportstate.c
index cb47aa9..cd0f680 100644
--- a/src/ibportstate.c
+++ b/src/ibportstate.c
@@ -1,6 +1,8 @@
/*
* Copyright (c) 2004-2009 Voltaire Inc. All rights reserved.
* Copyright (c) 2010,2011 Mellanox Technologies LTD. All rights reserved.
+ * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
+ *
*
* This software is available to you under a choice of one of two
* licenses. You may choose to be licensed under the terms of the GNU
@@ -655,15 +657,31 @@ int main(int argc, char **argv)
/* Setup portid for peer port */
memcpy(&peerportid, &portid, sizeof(peerportid));
- peerportid.drpath.cnt = 1;
- peerportid.drpath.p[1] = (uint8_t) portnum;
-
- /* Set DrSLID to local lid */
- if (resolve_self(ibd_ca, ibd_ca_port, &selfportid,
- &selfport, 0) < 0)
- IBEXIT("could not resolve self");
- peerportid.drpath.drslid = (uint16_t) selfportid.lid;
- peerportid.drpath.drdlid = 0xffff;
+ if (portid.lid == 0) {
+ peerportid.drpath.cnt = portid.drpath.cnt + 1;
+ if (peerportid.drpath.cnt == IB_SUBNET_PATH_HOPS_MAX) {
+ exit(0);
+ }
+ peerportid.drpath.p[peerportid.drpath.cnt] = (uint8_t) portnum;
+ } else {
+ /* Set DrSLID to local lid */
+ if (resolve_portid_str(ibd_ca, ibd_ca_port, &portid, argv[0],
+ ibd_dest_type, ibd_sm_id, srcport) < 0)
+ IBEXIT("could not resolve self");
+
+ peerportid.drpath.cnt = 1;
+ peerportid.drpath.p[1] = (uint8_t) portnum;
+
+
+ /* Use partial LID routing if remote switch */
+ if ((portid.lid == selfportid.lid)) {
+ peerportid.drpath.drslid = 0xffff;
+ peerportid.drpath.drdlid = 0xffff;
+ } else {
+ peerportid.drpath.drslid = selfportid.lid;
+ peerportid.drpath.drdlid = 0xffff;
+ }
+ }
/* Get peer port NodeInfo to obtain peer port number */
is_peer_switch = get_node_info(&peerportid, data);
base-commit: 2937cf99350a2e423b705e8b8dd10499796a7b41
--
git-series 0.8.10
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH rdma-core] Improve global COPYING files
From: Leon Romanovsky @ 2016-09-23 8:06 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Doug Ledford
In-Reply-To: <20160923041340.GA11269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 9514 bytes --]
On Thu, Sep 22, 2016 at 10:13:40PM -0600, Jason Gunthorpe wrote:
> Upon deeper analysis it seems there are two variations of the 'OpenIB.org BSD
> license', I am calling them the MIT and FreeBSD variants. They differ only in
> the text of the disclaimer. The MIT version is used widely as the source
> license so that version should be the 'default' in the source tree, not the
> FreeBSD version I had selected initially.
>
> Retain the FreeBSD version as we will refer to it in future commits.
>
> Elaborate the COPYING file to discuss the license situation in
> more depth.
I doubt that we have appropriate knowledge to come into meaningful
conclusion after "discussion". It is legal issue which should be
handled by relevant legal departments.
>
> Signed-off-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> ---
> COPYING | 6 ------
> COPYING.BSD | 26 ----------------------
> COPYING.BSD_FB | 22 +++++++++++++++++++
> COPYING.BSD_MIT | 20 +++++++++++++++++
> COPYING.md | 67 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++
> 5 files changed, 109 insertions(+), 32 deletions(-)
> delete mode 100644 COPYING
> delete mode 100644 COPYING.BSD
> create mode 100644 COPYING.BSD_FB
> create mode 100644 COPYING.BSD_MIT
> create mode 100644 COPYING.md
>
> I have reviewed most of the files now for copyright considerations to
> make sure our licensing is in order.
>
> This is my proposal for the top level COPYING file, and it contains a
> summary of my findings on licensing.
>
> Due to various mistakes in the past things are overly complex, I would
> appreciate any patches to reduce the complexity. eg ensuring that all
> files have a license reference and the removal of the sub dir COPYING
> files.
>
> It would be appreciated if those who hold the copyrights can adjust
> their licenses to match the so-called 'Default Dual License', eg by
> patching the remaining COPYING files to use the correct disclaimer.
>
> Here is my first jab at simplifying:
>
> https://github.com/jgunthorpe/rdma-plumbing/commit/079d840b102906c79ff07b7fe9d5db6bba26517c
>
> diff --git a/COPYING b/COPYING
> deleted file mode 100644
> index ac58180e900c..000000000000
> --- a/COPYING
> +++ /dev/null
> @@ -1,6 +0,0 @@
> -Unless otherwise stated this software is available to you under a choice of
> -one of two licenses. You may choose to be licensed under the terms of the the
> -OpenIB.org BSD license (see COPYING.BSD) or the GNU General Public License
> -(GPL) Version 2 (see COPYING.GPL2), both included in this package.
> -
> -Refer to individual files for information on the copyright holders.
> diff --git a/COPYING.BSD b/COPYING.BSD
> deleted file mode 100644
> index 59b3a397a13b..000000000000
> --- a/COPYING.BSD
> +++ /dev/null
> @@ -1,26 +0,0 @@
> - OpenIB.org BSD license
> -
> -Redistribution and use in source and binary forms, with or without
> -modification, are permitted provided that the following conditions
> -are met:
> -
> - * Redistributions of source code must retain the above copyright
> - notice, this list of conditions and the following disclaimer.
> -
> - * Redistributions in binary form must reproduce the above
> - copyright notice, this list of conditions and the following
> - disclaimer in the documentation and/or other materials provided
> - with the distribution.
> -
> -THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
> -"AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
> -LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS
> -FOR A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE
> -COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT,
> -INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING,
> -BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES;
> -LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> -CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT
> -LIABILITY, OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN
> -ANY WAY OUT OF THE USE OF THIS SOFTWARE, EVEN IF ADVISED OF THE
> -POSSIBILITY OF SUCH DAMAGE.
> diff --git a/COPYING.BSD_FB b/COPYING.BSD_FB
> new file mode 100644
> index 000000000000..44237612faa3
> --- /dev/null
> +++ b/COPYING.BSD_FB
> @@ -0,0 +1,22 @@
> + OpenIB.org BSD license (FreeBSD Variant)
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are met:
> +
> + - Redistributions of source code must retain the above copyright notice,
> + this list of conditions and the following disclaimer.
> +
> + - Redistributions in binary form must reproduce the above copyright notice,
> + this list of conditions and the following disclaimer in the documentation
> + and/or other materials provided with the distribution.
> +
> +THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS"
> +AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE
> +IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE
> +DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT OWNER OR CONTRIBUTORS BE LIABLE
> +FOR ANY DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL
> +DAMAGES (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR
> +SERVICES; LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER
> +CAUSED AND ON ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY,
> +OR TORT (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
> +OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
> diff --git a/COPYING.BSD_MIT b/COPYING.BSD_MIT
> new file mode 100644
> index 000000000000..a1432b6134e6
> --- /dev/null
> +++ b/COPYING.BSD_MIT
> @@ -0,0 +1,20 @@
> + OpenIB.org BSD license (MIT variant)
> +
> +Redistribution and use in source and binary forms, with or without
> +modification, are permitted provided that the following conditions are met:
> +
> + - Redistributions of source code must retain the above copyright notice,
> + this list of conditions and the following disclaimer.
> +
> + - Redistributions in binary form must reproduce the above copyright notice,
> + this list of conditions and the following disclaimer in the documentation
> + and/or other materials provided with the distribution.
> +
> +THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
> +IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
> +FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE
> +AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
> +LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
> +OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
> +SOFTWARE.
> +
> diff --git a/COPYING.md b/COPYING.md
> new file mode 100644
> index 000000000000..edcb01af9954
> --- /dev/null
> +++ b/COPYING.md
> @@ -0,0 +1,67 @@
> +# Default Dual License
> +
> +Unless otherwise stated this software is available to you under a choice of
> +one of two licenses. You may choose to be licensed under the terms of the the
> +OpenIB.org BSD (MIT variant) license (see COPYING.BSD_MIT) or the GNU General
> +Public License (GPL) Version 2 (see COPYING.GPL2), both included in this
> +package.
> +
> +Files marked 'See COPYING file' are licensed under the above Dual License.
> +
> +# Other Options
> +
> +Individual source files may use a license different from the above Defaul Dual
> +License. If a license is declared in the file then it supersedes the Default
> +License.
> +
> +If a directory contains a COPYING file then the License from that file becomes
> +the Default License for files in that directory and below.
> +
> +# Copyright Holders
> +
> +Refer to individual files for information on the copyright holders.
> +
> +# License Catalog (Informative, Non Binding)
> +
> +## Providers
> +
> +The following providers use a different license than the Default Dual
> +License. Refer to files in each directory for details.
> +
> +cxbg4
> +: A combination of the
> + - Default Dual License
> + - cxgb4/src/queue.h: BSD 3 clause license.
> +
> +hfi1verbs
> +: Dual License: GPLv2 or Intel 3 clause BSD license
> +
> +ipathverbs
> +: Dual License: GPLv2 or PathScale BSD Patent license
> +
> +ocrdma
> +: Dual License: GPLv2 or OpenIB.org BSD (FreeBSD variant), See COPYING.BSD_FB
> +
> +rxe
> +: A combination of the
> + - Default Dual License
> + - GPLv2 or PathScale BSD Patent license
> +
> +## Libraries
> +
> +All library compilable source code (.c and .h files) are available under the
> +Default Dual License.
> +
> +Unmarked ancillary files may be available under a Dual License: GPLv2 or
> +OpenIB.org BSD (FreeBSD variant).
> +
> +## Tools (iwpmd, srp_deamon, ibacm)
> +
> +All compilable source code (.c and .h files) are available under the Default
> +Dual License.
> +
> +Unmarked ancillary files may be available under a Dual License: GPLv2 or
> +OpenIB.org BSD (FreeBSD variant).
> +
> +srp_daemon/srp_daemon/srp_daemon.sh: Any one of the GPLv2, a 2 clause BSD
> +license or the CPLv1.
> --
> 2.7.4
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH infiniband-diags] ibportstate: Fixed peer port probing when using DR routing
From: Hal Rosenstock @ 2016-09-23 13:06 UTC (permalink / raw)
To: Knut Omang, Ira Weiny
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Line Holen, Dag Moxnes
In-Reply-To: <430aa17fd12cdcfd735b4215938dc4279e33572d.1474612678.git-series.knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
On 9/23/2016 2:42 AM, Knut Omang wrote:
> From: Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
Title might be better as:
ibportstate: Fixed switch peer port probing when using DR routing
>
> When querying a remote port
on a switch
> using ibportportstate,
Typo: ibportstate
> queries to the peer port
> would result in timeouts. The reason for this is that the DR path (or partial
> DR path was not correctly constructed.
It looks like there are 2 cases fixed below and it's best to describe
them. My take on it is:
1. local LID (for switch port 0) is not yet configured
2. SMI requester port (I think this is what you term remote port above)
is on local rather than remote switch
Is that accurate ?
> Signed-off-by: Dag Moxnes <dag.moxnes-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Reviewed-by: Line Holen <line.holen-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> Signed-off-by: Knut Omang <knut.omang-QHcLZuEGTsvQT0dZR+AlfA@public.gmane.org>
> ---
> src/ibportstate.c | 36 +++++++++++++++++++++++++++---------
> 1 file changed, 27 insertions(+), 9 deletions(-)
>
> diff --git a/src/ibportstate.c b/src/ibportstate.c
> index cb47aa9..cd0f680 100644
> --- a/src/ibportstate.c
> +++ b/src/ibportstate.c
> @@ -1,6 +1,8 @@
> /*
> * Copyright (c) 2004-2009 Voltaire Inc. All rights reserved.
> * Copyright (c) 2010,2011 Mellanox Technologies LTD. All rights reserved.
> + * Copyright (c) 2011, 2015, Oracle and/or its affiliates. All rights reserved.
> + *
> *
> * This software is available to you under a choice of one of two
> * licenses. You may choose to be licensed under the terms of the GNU
> @@ -655,15 +657,31 @@ int main(int argc, char **argv)
>
> /* Setup portid for peer port */
> memcpy(&peerportid, &portid, sizeof(peerportid));
> - peerportid.drpath.cnt = 1;
> - peerportid.drpath.p[1] = (uint8_t) portnum;
> -
> - /* Set DrSLID to local lid */
> - if (resolve_self(ibd_ca, ibd_ca_port, &selfportid,
> - &selfport, 0) < 0)
> - IBEXIT("could not resolve self");
> - peerportid.drpath.drslid = (uint16_t) selfportid.lid;
> - peerportid.drpath.drdlid = 0xffff;
> + if (portid.lid == 0) {
> + peerportid.drpath.cnt = portid.drpath.cnt + 1;
> + if (peerportid.drpath.cnt == IB_SUBNET_PATH_HOPS_MAX) {
> + exit(0);
Nit: IBEXIT("Too many hops") rather than exit(0)
> + }
> + peerportid.drpath.p[peerportid.drpath.cnt] = (uint8_t) portnum;
> + } else {
> + /* Set DrSLID to local lid */
> + if (resolve_portid_str(ibd_ca, ibd_ca_port, &portid, argv[0],
> + ibd_dest_type, ibd_sm_id, srcport) < 0)
> + IBEXIT("could not resolve self");
> +
> + peerportid.drpath.cnt = 1;
> + peerportid.drpath.p[1] = (uint8_t) portnum;
> +
> +
Nit: Eliminate extra blank line
> + /* Use partial LID routing if remote switch */
> + if ((portid.lid == selfportid.lid)) {
> + peerportid.drpath.drslid = 0xffff;
> + peerportid.drpath.drdlid = 0xffff;
> + } else {
> + peerportid.drpath.drslid = selfportid.lid;
> + peerportid.drpath.drdlid = 0xffff;
> + }
The following can be factored out of the above if/else:
peerportid.drpath.drdlid = 0xffff;
> + }
>
> /* Get peer port NodeInfo to obtain peer port number */
> is_peer_switch = get_node_info(&peerportid, data);
>
> base-commit: 2937cf99350a2e423b705e8b8dd10499796a7b41
>
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH TRIVIAL infiniband-diags] ibportstate.c: When not switch, port can be router port
From: Hal Rosenstock @ 2016-09-23 13:17 UTC (permalink / raw)
To: Weiny, Ira; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Indicate PortInfo is on CA/RT port rather than just CA port when not
on Switch port. RT is what's used by ibnetdiscover for router nodes.
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/src/ibportstate.c b/src/ibportstate.c
index cb47aa9..cfb8be7 100644
--- a/src/ibportstate.c
+++ b/src/ibportstate.c
@@ -522,9 +522,9 @@ int main(int argc, char **argv)
IBEXIT("Can't set M_Key fields on switch port != 0");
if (port_op != QUERY || changed)
- printf("Initial %s PortInfo:\n", is_switch ? "Switch" : "CA");
+ printf("Initial %s PortInfo:\n", is_switch ? "Switch" : "CA/RT");
else
- printf("%s PortInfo:\n", is_switch ? "Switch" : "CA");
+ printf("%s PortInfo:\n", is_switch ? "Switch" : "CA/RT");
espeed_cap = get_port_info(&portid, data, portnum, is_switch);
show_port_info(&portid, data, portnum, espeed_cap, is_switch);
if (is_mlnx_ext_port_info_supported(devid)) {
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH v3 0/9] SELinux support for Infiniband RDMA
From: Daniel Jurgens @ 2016-09-23 13:26 UTC (permalink / raw)
To: Paul Moore, Jason Gunthorpe
Cc: Leon Romanovsky,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-security-module-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
chrisw-69jw2NvuJkxg9hUCZPvPmw@public.gmane.org,
dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org,
sean.hefty-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org,
Stephen Smalley,
hal.rosenstock-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org
In-Reply-To: <CAHC9VhRXDMiK5V0rOQTvtZB0Q8jTX7XecGmAfRhm8oqF9aBaiw@mail.gmail.com>
On 9/20/2016 6:43 PM, Paul Moore wrote:
> On Tue, Sep 6, 2016 at 4:02 PM, Jason Gunthorpe
> <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> wrote:
>> On Thu, Sep 01, 2016 at 02:06:46PM -0400, Paul Moore wrote:
>>
>>> Jason and/or Daniel, I think it would be helpful if you could explain
>>> both the InifiniBand and IP based approaches for those of us who know
>>> SELinux, but not necessarily the RDMA and InfiniBand portions of this
>>> discussion. Be verbose and explain it as if we were idiots (I get
>>> called that enough, it must be true).
>> Well, I'm not really familiar with SELinux, I know a little bit about
>> how labels are applied in the netstack, but not that much...
>>
>> The RDMA subsystem supports 4 different networking standards, and they
>> each have their own objects..
> All right, I'm done traveling for a bit and it seems like this
> discussion has settled into a stalemate so let's try to pick things
> back up and sort this out.
>
> Starting we a better RDMA education for me.
>
> So far the discussion has been around providing access controls at the
> transport layer, are there any RDMA entities that are transport
> agnostic that might be better suited for what we are trying to do? Or
> is it simply that the RDMA layer is tied so tightly to the underlying
> transport that we can't separate the two and have to consider them as
> one?
Welcome back Paul.
I don't think there is a transport agnostic way to provide the kind of control I use in this patch set, which is very Infiniband specific. RoCE uses VLANs and they are conceptually similar to subnet partitions, but the means of using them is completely different. To use a different VLAN the user must select a GID for that VLAN. One could provide a means to control RoCE access to VLANs by labeling GIDs and controlling them in a similar way to how I do PKeys. That approach doesn't help with Infiniband partitions though, because the same GID can be used on multiple partitions. It's also not very desirable from a policy writers perspective because it makes it so a bespoke policy is required per node.
Regardless of any other approaches one might like to use to provide access control for RDMA non-Infiniband transport I think controlling access to Infiniband PKeys is still a desirable feature and I don't see any other way to have that.
_______________________________________________
Selinux mailing list
Selinux-+05T5uksL2qpZYMLLGbcSA@public.gmane.org
To unsubscribe, send email to Selinux-leave-+05T5uksL2pAGbPMOrvdOA@public.gmane.org
To get help, send an email containing "help" to Selinux-request-+05T5uksL2pAGbPMOrvdOA@public.gmane.org
^ permalink raw reply
* Re: [PATCH rdma-core] Improve global COPYING files
From: Jason Gunthorpe @ 2016-09-23 15:24 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Doug Ledford
In-Reply-To: <20160923080655.GM4088-2ukJVAZIZ/Y@public.gmane.org>
On Fri, Sep 23, 2016 at 11:06:55AM +0300, Leon Romanovsky wrote:
> On Thu, Sep 22, 2016 at 10:13:40PM -0600, Jason Gunthorpe wrote:
> > Upon deeper analysis it seems there are two variations of the 'OpenIB.org BSD
> > license', I am calling them the MIT and FreeBSD variants. They differ only in
> > the text of the disclaimer. The MIT version is used widely as the source
> > license so that version should be the 'default' in the source tree, not the
> > FreeBSD version I had selected initially.
> >
> > Retain the FreeBSD version as we will refer to it in future commits.
> >
> > Elaborate the COPYING file to discuss the license situation in
> > more depth.
>
> I doubt that we have appropriate knowledge to come into meaningful
> conclusion after "discussion". It is legal issue which should be
> handled by relevant legal departments.
Hi Leon,
I think the commit message was not clear, let me try again:
[PATCH] Document copyright situation and select default license
This patch is not intended to change the copyright or license
situation of any of the original code.
Documentation is provided that identifies the various licenses we
have in the source tree.
The default license for new items after the 'Initial commit' merge is
corrected to match the majority license already in use. This is the
license we recommend all new code use. This corrects a mistake I made
in the 'Unified CMake build system' patch which selected the wrong
license file.
Also provide specific guidance on how the 18 different COPYING files
and per-file copyright headers are intended to be interpreted
within the merged tree.
=======
As you know I've sent emails to various parties on licensing issues,
as those issues are corrected we can update the tree and the copying
summary.
We've already had success correcting one mistake from Intel and
Chelsio, thank you very much to those companies.
It is important we clearly document the current situation so our
downstreams can properly distribute this code.
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* [PATCH v1] rdma_rxe: Ensure rdma_rxe init occurs at correct time
From: Stephen Bates @ 2016-09-23 15:32 UTC (permalink / raw)
To: linux-rdma-u79uwXL29TY76Z2rM5mHXA, monis-VPRAkNaXOzVWk0Htik3J/w,
dledford-H+wXaHxf7aLQT0dZR+AlfA, yonatanc-VPRAkNaXOzVWk0Htik3J/w
This patch is based off v4.8-rc6 with the recent rxe bugfix patchset
applied [1].
There is a problem when CONFIG_RDMA_RXE=y and CONFIG_IPV6=y. This
results in the rdma_rxe initialization occurring before the IPv6
services are ready. This patch delays the initialization of rdma_rxe
until after the IPv6 services are ready. This fix is based on one
proposed by Logan Gunthorpe on a much older code base [2].
[1] http://marc.info/?l=linux-rdma&m=147307739626544&w=2
[2] https://github.com/sbates130272/qemu-minimal/blob/rdma/patches/\
0001-Changes-needed-to-use-rxe-compiled-into-the-kernel.patch
Changes since v0:
Improved the commit message
Added a Reviewed-by tag from Yonatan
Signed-off-by: Stephen Bates <sbates-pv7U853sEMVWk0Htik3J/w@public.gmane.org>
Reviewed-by: Yonatan Cohen <yonatanc-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
drivers/infiniband/sw/rxe/rxe.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/sw/rxe/rxe.c b/drivers/infiniband/sw/rxe/rxe.c
index 08e09d9..97bc74a 100644
--- a/drivers/infiniband/sw/rxe/rxe.c
+++ b/drivers/infiniband/sw/rxe/rxe.c
@@ -392,5 +392,5 @@ static void __exit rxe_module_exit(void)
pr_info("rxe: unloaded\n");
}
-module_init(rxe_module_init);
+late_initcall(rxe_module_init);
module_exit(rxe_module_exit);
--
2.1.4
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH 00/23] rdma-core Trivial fixes and documentation updates
From: Doug Ledford @ 2016-09-23 15:54 UTC (permalink / raw)
To: Jason Gunthorpe, linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <1474495729-17604-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1852 bytes --]
On 9/21/2016 6:08 PM, Jason Gunthorpe wrote:
> This is the next batch of fixes, the 23 patches are all straight forward and
> should be uncontroversial. Most are documentation updates, plus a few
> obviously correct fixes from static checkers.
>
> Please forward Acks and I will apply this to the github soonish.
>
> The tree is here:
> https://github.com/linux-rdma/rdma-core
>
> View the patches on github:
> https://github.com/linux-rdma/rdma-core/pull/2
>
> Christoph Hellwig (6):
> Add reporting bugs and submitting patches sections to README.md
> verbs: Move documentation to Documentation/
> rdmacm: Move documentation to Documentation/
> ibcm: Move documentation to Documentation/
> rxe: Move documentation to Documentation/
> srp_daemon: Move documentation to Documentation/
>
> Jason Gunthorpe (16):
> Consolidate the .gitignore files
> Move the AUTHORS files into MAINTAINERS
> mlx5: Add cmake options to replace --with-mlx5_debug/mw_debug
> ipathverbs: Recognize bashisms in truescale-serdes.cmds
> nes: Fix clang 3.6 warning
> -Wtautological-constant-out-of-range-compare
> ocrdma: Fix incorrect type of ibwc_status
> ocrdma: Fix incorrect enum constant
> verbs: Fix incorrect type of len
> verbs: Use inttypes.h format string macros
> rdmacm: Use correct format specifier for size_t
> rdmacm: Fix leading \'s in rcopy man page
> rdmacm: Fix typos
> umad: Replace .nl with .sp in man pages
> iwpmd: Install ancillary files for iwpm
> iwpmd: Remove syslog.target from service file
> srp_daemon: Use SRP_DEFAULT_START/STOP for substitution
>
> Steve Wise (1):
> iwpmd: Add man pages
Series looks good. I pushed it to rdma-core master.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
* libmlx5 list.h
From: Christoph Hellwig @ 2016-09-23 15:59 UTC (permalink / raw)
To: yishaih-VPRAkNaXOzVWk0Htik3J/w, eli-VPRAkNaXOzVWk0Htik3J/w
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA
Hi all,
libmlx5 comes with a partial copy of the kernel list.h despite claiming
to be available under a BSD license. As far as I know the kernel
list.h implementation never has been available under anything but the
GPLv2.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH rdma-next V2 0/9] Export vendors specific ABIs
From: Doug Ledford @ 2016-09-23 16:42 UTC (permalink / raw)
To: Leon Romanovsky, Christoph Hellwig
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Jason Gunthorpe,
Laurence Oberman
In-Reply-To: <20160922160924.GI4088-2ukJVAZIZ/Y@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 846 bytes --]
On 9/22/2016 12:09 PM, Leon Romanovsky wrote:
> On Thu, Sep 22, 2016 at 07:47:16AM -0700, Christoph Hellwig wrote:
>> Although I would have removed patch 8
>
> I'm not sure about it, but anyway it is separate patch which can be
> easily dropped by Doug when he will apply it.
Mostly easily, yes.
>> and add the Kconfig changes to
>> each individual driver change instead.
>
> I want logically separate move part and export part of this patch
> series.
There's no reason to separate them. And it leaves dangling uapi header
files that are in the uapi directory but not listed in the Kconfig. I
squashed the Kconfig changes and also the MAINTAINERS changes down into
the main patches, so the series is now only 7 patches.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
* Re: [PATCH rdma-rc 4/7] IB/mlx4: Fix possible vl/sl field mismatch in LRH header in QP1 packets
From: Doug Ledford @ 2016-09-23 16:48 UTC (permalink / raw)
To: Leon Romanovsky; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Jack Morgenstein
In-Reply-To: <20160918065356.GA2923-2ukJVAZIZ/Y@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 2958 bytes --]
On 9/18/2016 2:53 AM, Leon Romanovsky wrote:
> On Fri, Sep 16, 2016 at 02:01:57PM -0400, Doug Ledford wrote:
>> On 9/12/2016 12:16 PM, Leon Romanovsky wrote:
>>> From: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
>>>
>>> In MLX qp packets, the LRH (built by the driver) has both a VL field
>>> and an SL field. When building a QP1 packet, the VL field should
>>> reflect the SLtoVL mapping and not arbitrarily contain zero (as is
>>> done now). This bug causes credit problems in IB switches at
>>> high rates of QP1 packets.
>>>
>>> The fix is to cache the SL to VL mapping in the driver, and look up
>>> the VL mapped to the SL provided in the send request when sending
>>> QP1 packets.
>>>
>>> For FW versions which support generating a port_management_config_change
>>> event with subtype sl-to-vl-table-change, the driver uses that event
>>> to update its sl-to-vl mapping cache. Otherwise, the driver snoops
>>> incoming SMP mads to update the cache.
>>>
>>> There remains the case where the FW is running in secure-host mode
>>> (so no QP0 packets are delivered to the driver), and the FW does not
>>> generate the sl2vl mapping change event. To support this case, the
>>> driver updates (via querying the FW) its sl2vl mapping cache when
>>> running in secure-host mode when it receives either a Port Up event
>>> or a client-reregister event (where the port is still up, but there
>>> may have been an opensm failover).
>>> OpenSM modifies the sl2vl mapping before Port Up and Client-reregister
>>> events occur, so if there is a mapping change the driver's cache will
>>> be properly updated.
>>>
>>> Fixes: 225c7b1feef1 ("IB/mlx4: Add a driver Mellanox ConnectX InfiniBand adapters")
>>> Signed-off-by: Jack Morgenstein <jackm-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org>
>>> Signed-off-by: Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>
>>> ---
>>> drivers/infiniband/hw/mlx4/mad.c | 64 ++++++++++++++++++-
>>> drivers/infiniband/hw/mlx4/main.c | 110 +++++++++++++++++++++++++++++++-
>>> drivers/infiniband/hw/mlx4/mlx4_ib.h | 7 ++
>>> drivers/infiniband/hw/mlx4/qp.c | 23 ++++++-
>>> drivers/net/ethernet/mellanox/mlx4/fw.c | 13 ++--
>>> include/linux/mlx4/device.h | 13 +++-
>>> 6 files changed, 220 insertions(+), 10 deletions(-)
>>
>> That's a lot more code churn than I would like to see in a late RC. I'm
>> going to drop this patch and move it to 4.9 instead. If this fixed an
>> oops or something like that, I would be more open to taking it now, but
>> the problem being resolved is credits on a switch. That isn't the sort
>> of showstopper issue that would justify this large of a patch this late
>> in the cycle.
>
> No problem, Thanks.
This is now in my 4.9-misc branch.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
* [PATCH TRIVIAL rdma-core] README.md: Fix umad library name
From: Hal Rosenstock @ 2016-09-23 16:56 UTC (permalink / raw)
To: Jason Gunthorpe, Doug Ledford, Leon Romanovsky,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Signed-off-by: Hal Rosenstock <hal-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
---
diff --git a/README.md b/README.md
index 65c7644..65514ff 100644
--- a/README.md
+++ b/README.md
@@ -6,7 +6,7 @@ following device nodes:
- /dev/infiniband/uverbsX (libibverbs)
- /dev/infiniband/rdma_cm (librdmacm)
- - /dev/infiniband/umadX (libumad)
+ - /dev/infiniband/umadX (libibumad)
- /dev/infiniband/ucmX (libibcm, deprecated)
The userspace component of the libibverbs RDMA kernel drivers are included
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply related
* Re: [PATCH rdma-next V2 0/9] Export vendors specific ABIs
From: Leon Romanovsky @ 2016-09-23 16:58 UTC (permalink / raw)
To: Doug Ledford
Cc: Christoph Hellwig, linux-rdma-u79uwXL29TY76Z2rM5mHXA,
Jason Gunthorpe, Laurence Oberman
In-Reply-To: <701c2cd1-a47a-807d-41dc-c8057dd073bd-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 937 bytes --]
On Fri, Sep 23, 2016 at 12:42:02PM -0400, Doug Ledford wrote:
> On 9/22/2016 12:09 PM, Leon Romanovsky wrote:
> > On Thu, Sep 22, 2016 at 07:47:16AM -0700, Christoph Hellwig wrote:
> >> Although I would have removed patch 8
> >
> > I'm not sure about it, but anyway it is separate patch which can be
> > easily dropped by Doug when he will apply it.
>
> Mostly easily, yes.
>
> >> and add the Kconfig changes to
> >> each individual driver change instead.
> >
> > I want logically separate move part and export part of this patch
> > series.
>
> There's no reason to separate them. And it leaves dangling uapi header
> files that are in the uapi directory but not listed in the Kconfig. I
> squashed the Kconfig changes and also the MAINTAINERS changes down into
> the main patches, so the series is now only 7 patches.
Thanks.
>
> --
> Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
> GPG Key ID: 0E572FDD
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* RE: [PATCH rdma-core] Improve global COPYING files
From: Hefty, Sean @ 2016-09-23 16:58 UTC (permalink / raw)
To: Jason Gunthorpe,
linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Cc: Doug Ledford, Leon Romanovsky
In-Reply-To: <20160923041340.GA11269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
> diff --git a/COPYING.BSD_FB b/COPYING.BSD_FB
> new file mode 100644
> index 000000000000..44237612faa3
> --- /dev/null
> +++ b/COPYING.BSD_FB
> @@ -0,0 +1,22 @@
> + OpenIB.org BSD license (FreeBSD Variant)
Openib.org doesn't exist. Can we just drop that term from the files?
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH rdma-core] Improve global COPYING files
From: Jason Gunthorpe @ 2016-09-23 17:03 UTC (permalink / raw)
To: Hefty, Sean
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford,
Leon Romanovsky
In-Reply-To: <1828884A29C6694DAF28B7E6B8A82373AB08E609-P5GAC/sN6hkd3b2yrw5b5LfspsVTdybXVpNB7YpNyf8@public.gmane.org>
On Fri, Sep 23, 2016 at 04:58:48PM +0000, Hefty, Sean wrote:
> > diff --git a/COPYING.BSD_FB b/COPYING.BSD_FB
> > new file mode 100644
> > index 000000000000..44237612faa3
> > +++ b/COPYING.BSD_FB
> > @@ -0,0 +1,22 @@
> > + OpenIB.org BSD license (FreeBSD Variant)
>
> Openib.org doesn't exist. Can we just drop that term from the files?
Maybe? I don't know, that is starting to go down the path that Leon
alluded to regarding getting legal advice.
That would be a different patch, IMHO.
Normally I'd say to avoid confusion it is good to stick with the
historical names, but in this case there are three things calling
themselves the openib.org bsd license, so I don't know :|
Jason
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: libmlx5 list.h
From: Leon Romanovsky @ 2016-09-23 17:04 UTC (permalink / raw)
To: Christoph Hellwig
Cc: yishaih-VPRAkNaXOzVWk0Htik3J/w, eli-VPRAkNaXOzVWk0Htik3J/w,
linux-rdma-u79uwXL29TY76Z2rM5mHXA
In-Reply-To: <20160923155901.GA17362-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Fri, Sep 23, 2016 at 08:59:01AM -0700, Christoph Hellwig wrote:
> Hi all,
>
> libmlx5 comes with a partial copy of the kernel list.h despite claiming
> to be available under a BSD license. As far as I know the kernel
> list.h implementation never has been available under anything but the
> GPLv2.
1. BSD list.h implementation [1] is very similar to the linux kernel version.
2. I'm working to create separate directory to put common code (min,
max, lists) into one place with proper license.
Thanks
[1]
https://github.com/lattera/freebsd/blob/master/sys/ofed/include/linux/list.h
> --
> To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
> the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH rdma-core] Improve global COPYING files
From: Leon Romanovsky @ 2016-09-23 17:10 UTC (permalink / raw)
To: Jason Gunthorpe; +Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Doug Ledford
In-Reply-To: <20160923152412.GB11269-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 2342 bytes --]
On Fri, Sep 23, 2016 at 09:24:12AM -0600, Jason Gunthorpe wrote:
> On Fri, Sep 23, 2016 at 11:06:55AM +0300, Leon Romanovsky wrote:
> > On Thu, Sep 22, 2016 at 10:13:40PM -0600, Jason Gunthorpe wrote:
> > > Upon deeper analysis it seems there are two variations of the 'OpenIB.org BSD
> > > license', I am calling them the MIT and FreeBSD variants. They differ only in
> > > the text of the disclaimer. The MIT version is used widely as the source
> > > license so that version should be the 'default' in the source tree, not the
> > > FreeBSD version I had selected initially.
> > >
> > > Retain the FreeBSD version as we will refer to it in future commits.
> > >
> > > Elaborate the COPYING file to discuss the license situation in
> > > more depth.
> >
> > I doubt that we have appropriate knowledge to come with meaningful
> > conclusion after "discussion". It is legal issue which should be
> > handled by relevant legal departments.
>
> Hi Leon,
>
> I think the commit message was not clear, let me try again:
>
> [PATCH] Document copyright situation and select default license
>
> This patch is not intended to change the copyright or license
> situation of any of the original code.
>
> Documentation is provided that identifies the various licenses we
> have in the source tree.
>
> The default license for new items after the 'Initial commit' merge is
> corrected to match the majority license already in use. This is the
> license we recommend all new code use. This corrects a mistake I made
> in the 'Unified CMake build system' patch which selected the wrong
> license file.
>
> Also provide specific guidance on how the 18 different COPYING files
> and per-file copyright headers are intended to be interpreted
> within the merged tree.
>
> =======
>
> As you know I've sent emails to various parties on licensing issues,
> as those issues are corrected we can update the tree and the copying
> summary.
>
> We've already had success correcting one mistake from Intel and
> Chelsio, thank you very much to those companies.
>
> It is important we clearly document the current situation so our
> downstreams can properly distribute this code.
I sure that this question will sound dumb for you, but can we unify all
code under OFA's licenses (dual-license)? I don't feel comfortable with
this multi-license situation.
>
> Jason
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* Re: [PATCH rdma-core] Improve global COPYING files
From: Leon Romanovsky @ 2016-09-23 17:12 UTC (permalink / raw)
To: Jason Gunthorpe
Cc: Hefty, Sean, linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Doug Ledford
In-Reply-To: <20160923170314.GA13920-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 632 bytes --]
On Fri, Sep 23, 2016 at 11:03:14AM -0600, Jason Gunthorpe wrote:
> On Fri, Sep 23, 2016 at 04:58:48PM +0000, Hefty, Sean wrote:
> > > diff --git a/COPYING.BSD_FB b/COPYING.BSD_FB
> > > new file mode 100644
> > > index 000000000000..44237612faa3
> > > +++ b/COPYING.BSD_FB
> > > @@ -0,0 +1,22 @@
> > > + OpenIB.org BSD license (FreeBSD Variant)
> >
> > Openib.org doesn't exist. Can we just drop that term from the files?
>
> Maybe? I don't know, that is starting to go down the path that Leon
> alluded to regarding getting legal advice.
Yeah, because Leon doesn't understand (and doesn't want to understand)
this legal crap.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply
* RE: [PATCH rdma-core] Improve global COPYING files
From: Hefty, Sean @ 2016-09-23 17:23 UTC (permalink / raw)
To: Leon Romanovsky, Jason Gunthorpe
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Doug Ledford
In-Reply-To: <20160923171003.GR4088-2ukJVAZIZ/Y@public.gmane.org>
> > As you know I've sent emails to various parties on licensing issues,
> > as those issues are corrected we can update the tree and the copying
> > summary.
> >
> > We've already had success correcting one mistake from Intel and
> > Chelsio, thank you very much to those companies.
> >
> > It is important we clearly document the current situation so our
> > downstreams can properly distribute this code.
>
> I sure that this question will sound dumb for you, but can we unify all
> code under OFA's licenses (dual-license)? I don't feel comfortable with
> this multi-license situation.
If this combined repo is intended to support the plumbing for the linux-rdma subsystem, then I think it must support code that is submitted under GPL only. Much of the tradition code can remain dual-license, but new provider code, for example, should be submit-able under GPL.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply
* Re: [PATCH rdma-next V3 6/6] RDMA/core: Unify style of IOCTL commands
From: Doug Ledford @ 2016-09-23 17:31 UTC (permalink / raw)
To: Leon Romanovsky
Cc: linux-rdma-u79uwXL29TY76Z2rM5mHXA, Matan Barak, Haggai Eran
In-Reply-To: <20160905053342.GW21847-2ukJVAZIZ/Y@public.gmane.org>
[-- Attachment #1.1: Type: text/plain, Size: 1432 bytes --]
On 9/5/2016 1:33 AM, Leon Romanovsky wrote:
> On Sun, Sep 04, 2016 at 02:30:35PM +0300, Leon Romanovsky wrote:
>> From: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>>
>> MAD and HFI1 have different naming convention, this patch
>> simplifies and unifies their defines and names.
>>
>> As part of cleanup, the HFI1 _NUM() macro and command indexes
>> were removed. It has a potential to break applications which use
>> these defines directly, while shouldn't.
>>
>> Signed-off-by: Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Haggai Eran <haggaie-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Signed-off-by: Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>
>> Reviewed-by: Jason Gunthorpe <jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org>
>> ---
>> include/uapi/rdma/rdma_user_ioctl.h | 98 ++++++++++++++-----------------------
>> 1 file changed, 38 insertions(+), 60 deletions(-)
>>
>
> <....>
>
>> /*
>> - * User IOCTLs can not go above 128 if they do then see common.h and change the
>> - * base for the snoop ioctl
>> + * General blocks assignments
>> + * It is closed on purpose do not expose it it user space
>
> Doug,
> Do you mind to change "it it" to be "it to" and save to everyone
> respin?
Fixed.
--
Doug Ledford <dledford-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org>
GPG Key ID: 0E572FDD
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 884 bytes --]
^ permalink raw reply
page: next (older) | prev (newer) | latest
- recent:[subjects (threaded)|topics (new)|topics (active)]
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox