From: sashiko-bot@kernel.org
To: "Jacob Moroni" <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next] RDMA/irdma: Check MR contiguity before PBLE alloc
Date: Sat, 10 Oct 2026 19:57:35 +0000 [thread overview]
Message-ID: <sashiko-outbox-166858@kernel.org> (raw)
In-Reply-To: <20261010194832.2415477-1-jmoroni@google.com>
> The original logic would attempt to allocate PBLEs, then would
> check whether the region was contiguous _after_, and if so,
> would free the PBLEs and use a direct mapping instead.
>
> These unnecessary temporary PBLE allocations can technically
> fail (PBLEs are a finite resource), which can cause an MR
> registration failure even if the region is contiguous and
> should have succeeded.
>
> Fix this by checking whether the region is contiguous before
> allocating any PBLEs, and use the ib_umem_is_contiguous
> helper while we're at it.
>
> Ring MRs still have their own logic. That will be addressed next.
>
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261010194832.2415477-1-jmoroni@google.com?part=1
next prev parent reply other threads:[~2026-10-10 19:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-10 19:48 [PATCH rdma-next] RDMA/irdma: Check MR contiguity before PBLE alloc Jacob Moroni
2026-10-10 19:57 ` sashiko-bot [this message]
2026-10-12 14:00 ` Leon Romanovsky
2026-10-12 18:50 ` Jason Gunthorpe
2026-10-13 11:22 ` Leon Romanovsky
2026-10-13 16:08 ` Jacob Moroni
2026-10-13 16:29 ` Jason Gunthorpe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166858@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jmoroni@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox