From: sashiko-bot@kernel.org
To: "David Hu" <dhu@x6u.co>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next 3/5] RDMA/irdma: Support UMEM attribute for QP creation
Date: Sun, 11 Oct 2026 01:22:07 +0000 [thread overview]
Message-ID: <sashiko-outbox-166958@kernel.org> (raw)
In-Reply-To: <20261011011022.1445352-4-dhu@x6u.co>
> From: David Hu <xuehaohu@google.com>
>
> Support the standard 1-step queue buffer creation
> model for QP by using `UVERBS_ATTR_CREATE_QP_BUF_UMEM`
> and `ib_umem_get_attr()`.
>
> Add `irdma_setup_q_pbl_from_umem()` to allocate the
> backing MR and program hardware pble directly from
> the pinned umem. Proper umem and pble cleanup is
> added to `irdma_free_qp_rsrc()` upon QP destruction.
>
> We retain backward compatibility for legacy 2-step
> registration if the UMEM attribute is not provided.
>
> `irdma_alloc_iwmr()` assumed there is always a valid
> [ ... ]
> `irdma_free_iwmr` is statically scoped in `verbs.c`.
> Combining was considered, and we think it belongs
> to a future project.
>
> Signed-off-by: David Hu <xuehaohu@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261011011022.1445352-1-dhu@x6u.co?part=3
next prev parent reply other threads:[~2026-10-11 1:22 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 1:10 [PATCH rdma-next 0/5] RDMA/irdma: Add support for ioctl David Hu
2026-10-11 1:10 ` [PATCH rdma-next 1/5] RDMA/irdma: Plumb uverbs_attr_bundle for QP, SRQ David Hu
2026-10-11 1:18 ` sashiko-bot
2026-10-11 1:10 ` [PATCH rdma-next 2/5] RDMA/irdma: Register irdma UVERBS ioctl namespace David Hu
2026-10-11 1:20 ` sashiko-bot
2026-10-11 1:10 ` [PATCH rdma-next 3/5] RDMA/irdma: Support UMEM attribute for QP creation David Hu
2026-10-11 1:22 ` sashiko-bot [this message]
2026-10-11 1:10 ` [PATCH rdma-next 4/5] RDMA/irdma: Support UMEM attribute for CQ creation David Hu
2026-10-11 1:27 ` sashiko-bot
2026-10-12 14:17 ` Leon Romanovsky
2026-10-12 21:15 ` David Hu
2026-10-11 1:10 ` [PATCH rdma-next 5/5] RDMA/irdma: Support UMEM attribute for SRQ creation David Hu
2026-10-11 1:22 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-166958@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dhu@x6u.co \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox