Re: [PATCH] IB/mlx4: Avoid requeueing executing CM timeout work

[sashiko-bot@kernel.org]

> id->scheduled_delete is set by schedule_delayed() itself.  It is used
> in two cases after the RTU timeout support was added:
> 
> * A new id_map_entry is created, and a 60-second RTU timeout is
>   scheduled.
> * DREQ or REJ is received for an existing entry, and the normal
>   30-second teardown timeout is scheduled or adjusted.
> 
> The following race is possible when the RTU timeout expires while a
> DREQ or REJ is handled:
> 
>  CPU 0: timeout work                         CPU 1: DREQ/REJ handler
>  --------------------                        -----------------------
>  RTU timer expires
>  timeout callback starts
> [ ... ]
> cancel_delayed_work_sync(), because the timeout callback may be waiting
> for id_map_lock, which is held by the caller.
> 
> Fixes: fa09adf4231f ("IB/mlx4: Fix stale CM id_map entries when RTU is never received")
> Signed-off-by: Praveen Kumar Kannoju <praveen.kannoju@oracle.com>

Sashiko has reviewed this patch and found no issues. It looks great!

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014121344.100048-1-praveen.kannoju@oracle.com?part=1