Re: [PATCH rdma-next 10/13] RDMA/core: queue pair attributes for unconnected transports

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] RDMA: missing IB_QPT_RU state machine validation in qp_state_table
--

commit e32578d06dac38500b6cb1196755de6b03c64308
Author: Eric Davis <eric.davis@broadcom.com>
Subject: RDMA/core: queue pair attributes for unconnected transports

This commit adds creation attributes for queue pairs on unconnected transports.
It introduces job keys to authorize actions, initiator identities, and
semantics checks for ordering guarantees.

> diff --git a/drivers/infiniband/core/uverbs_std_types_qp.c b/drivers/infiniband/core/uverbs_std_types_qp.c
> index c6225156fe30e..47ca994f9ac96 100644
> --- a/drivers/infiniband/core/uverbs_std_types_qp.c
> +++ b/drivers/infiniband/core/uverbs_std_types_qp.c
[ ... ]
> @@ -197,6 +331,7 @@ static int UVERBS_HANDLER(UVERBS_METHOD_QP_CREATE)(
>  	case IB_UVERBS_QPT_UC:
>  	case IB_UVERBS_QPT_UD:
>  	case IB_UVERBS_QPT_XRC_INI:
> +	case IB_UVERBS_QPT_RU:

[Severity: Medium]
Will this newly added transport fail state machine validation during creation?

When UVERBS_METHOD_QP_CREATE() creates an IB_QPT_RU QP, the core immediately
forces a transition from IB_QPS_RESET to IB_QPS_RTS via
ib_modify_qp_with_udata():

drivers/infiniband/core/uverbs_std_types_qp.c:
UVERBS_HANDLER(UVERBS_METHOD_QP_CREATE)() {
...
	if (attr.qp_type == IB_QPT_RU) {
		qp_attr.qp_state = IB_QPS_RTS;
		ret = ib_modify_qp_with_udata(qp, &qp_attr,
					      qp_attr_mask | IB_QP_STATE,
					      uverbs_get_cleared_udata(attrs));
...
}

However, IB_QPT_RU appears to be missing from the qp_state_table in
drivers/infiniband/core/verbs.c.

When a driver invokes ib_modify_qp_is_ok(), the missing table entries mean
the req_param and opt_param default to 0, and the transition is not marked
as valid. Doesn't this cause ib_modify_qp_is_ok() to unconditionally return
false and reject the QP modification for any driver attempting to support
this new transport?

>  	case IB_UVERBS_QPT_DRIVER:
>  		if (uverbs_attr_is_valid(attrs,
>  					 UVERBS_ATTR_CREATE_QP_XRCD_HANDLE) ||

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261014-uet-ib-core-v1-0-a0e626117113@broadcom.com?part=10