From: sashiko-bot@kernel.org
To: "David Hu" <dhu@x6u.co>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-next v2 5/6] RDMA/irdma: Support UMEM attribute for CQ creation
Date: Thu, 15 Oct 2026 01:33:05 +0000 [thread overview]
Message-ID: <sashiko-outbox-172098@kernel.org> (raw)
In-Reply-To: <20261015011940.4122452-6-dhu@x6u.co>
> From: David Hu <xuehaohu@google.com>
>
> Support the standard 1-step queue buffer creation model for CQ by
> `UVERBS_ATTR_CREATE_CQ_BUF_UMEM`, `IRDMA_IB_ATTR_CREATE_CQ_SHADOW_BUF_UMEM`
> via `ib_umem_get_attr()`.
>
> Set up hardware pble directly from the pinned CQ and shadow umems via
> `irdma_setup_q_pbl_from_umem()`.
>
> Proper umem and pble cleanup are added into existing `irdma_cq_free_rsrc()`
> upon CQ destruction.
>
> We maintain backward compatibility for legacy 2-step registration if UMEM
> attributes are not provided.
>
> `irdma_resize_cq()` will have a possibility to deal with a pble/mr that
> is created via one-step logic, after this change. Therefore, a proper
> cleanup is added.
>
> Signed-off-by: David Hu <xuehaohu@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015011940.4122452-1-dhu@x6u.co?part=5
next prev parent reply other threads:[~2026-10-15 1:33 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 1:19 [PATCH rdma-next v2 0/6] RDMA/irdma: Add support for ioctl David Hu
2026-10-15 1:19 ` [PATCH rdma-next v2 1/6] RDMA/irdma: Plumb uverbs_attr_bundle for QP, SRQ David Hu
2026-10-15 1:31 ` sashiko-bot
2026-10-15 1:19 ` [PATCH rdma-next v2 2/6] RDMA/irdma: Register irdma UVERBS ioctl namespace David Hu
2026-10-15 1:33 ` sashiko-bot
2026-10-15 1:19 ` [PATCH rdma-next v2 3/6] RDMA/irdma: Support UMEM attribute for QP creation David Hu
2026-10-15 1:19 ` [PATCH rdma-next v2 4/6] RDMA/irdma: Split CQ setup to umode and kmode David Hu
2026-10-15 1:30 ` sashiko-bot
2026-10-15 1:19 ` [PATCH rdma-next v2 5/6] RDMA/irdma: Support UMEM attribute for CQ creation David Hu
2026-10-15 1:33 ` sashiko-bot [this message]
2026-10-15 1:19 ` [PATCH rdma-next v2 6/6] RDMA/irdma: Support UMEM attribute for SRQ creation David Hu
2026-10-15 1:32 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172098@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=dhu@x6u.co \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox