From: sashiko-bot@kernel.org
To: "Deep Shah" <deepshah146@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH rdma-rc 1/2] RDMA/uverbs: Fix uobject leak in DMABUF release
Date: Thu, 15 Oct 2026 08:57:04 +0000 [thread overview]
Message-ID: <sashiko-outbox-172527@kernel.org> (raw)
In-Reply-To: <20261015083637.200958-2-deepshah146@gmail.com>
> uverbs_dmabuf_release() treats a NULL uobj->context as an aborted
> allocation, but normal ufile cleanup also clears it. Closing the uverbs
> FD before the dma-buf FD therefore skips uverbs_uobject_release() and
> leaks the uobject and ufile references.
>
> Clear dmabuf->priv before dma_buf_put() on allocation failure and use
> that NULL pointer to identify an abort. Otherwise, always call
> uverbs_uobject_release(). This also avoids reading a freed uobject if
> release is deferred until after the allocation has been aborted.
>
> Fixes: 0ac6f4056c4a ("RDMA/uverbs: Add DMABUF object type and operations")
> Cc: stable@vger.kernel.org
> Assisted-by: LLM
> Signed-off-by: Deep Shah <deepshah146@gmail.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015083637.200958-1-deepshah146@gmail.com?part=1
next prev parent reply other threads:[~2026-10-15 8:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 8:36 [PATCH rdma-rc 0/2] RDMA/uverbs: Fix DMABUF lifetime bugs Deep Shah
2026-10-15 8:36 ` [PATCH rdma-rc 1/2] RDMA/uverbs: Fix uobject leak in DMABUF release Deep Shah
2026-10-15 8:57 ` sashiko-bot [this message]
2026-10-15 8:36 ` [PATCH rdma-rc 2/2] RDMA/uverbs: Fix DMABUF use-after-free during ufile cleanup Deep Shah
2026-10-15 8:44 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172527@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=deepshah146@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox