From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net 3/3] net/mlx5e: Expose CQE moderation mode on representors
Date: Thu, 15 Oct 2026 12:48:32 +0000 [thread overview]
Message-ID: <sashiko-outbox-172867@kernel.org> (raw)
In-Reply-To: <20261014124704.1017782-4-tariqt@nvidia.com>
> From: Yael Chemla <ychemla@nvidia.com>
>
> commit bc541621f8ba ("net/mlx5e: Support ethtool cq mode") added
> ETHTOOL_COALESCE_USE_CQE to the NIC ethtool ops but omitted it from
> mlx5e_rep_ethtool_ops.supported_coalesce_params. The ethtool netlink
> layer rejects any attempt to set cqe-mode-rx/tx on a representor
> with EINVAL.
>
> Add ETHTOOL_COALESCE_USE_CQE to mlx5e_rep_ethtool_ops.
> mlx5e_ethtool_set_coalesce() already handles it correctly.
>
> Fixes: bc541621f8ba ("net/mlx5e: Support ethtool cq mode")
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Dragos Tatulea <dtatulea@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261014124704.1017782-1-tariqt@nvidia.com?part=3
next prev parent reply other threads:[~2026-10-15 12:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-14 12:47 [PATCH net 0/3] net/mlx5e: Fix CQE moderation mode reporting and control Tariq Toukan
2026-10-14 12:47 ` [PATCH net 1/3] net/mlx5e: Sync CQE moderation pflags with coalesce params Tariq Toukan
2026-10-15 12:48 ` sashiko-bot
2026-10-14 12:47 ` [PATCH net 2/3] net/mlx5e: Sync CQE moderation params with pflags in set_pflag_cqe_based_moder Tariq Toukan
2026-10-15 12:48 ` sashiko-bot
2026-10-14 12:47 ` [PATCH net 3/3] net/mlx5e: Expose CQE moderation mode on representors Tariq Toukan
2026-10-15 12:48 ` sashiko-bot [this message]
2026-10-14 12:55 ` [PATCH net 0/3] net/mlx5e: Fix CQE moderation mode reporting and control netdev-bot+sinfo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-172867@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox