From: sashiko-bot@kernel.org
To: "Jacob Moroni" <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/irdma: Fix FRWR IRDMAQPSQ_PBLADDR field population
Date: Thu, 15 Oct 2026 16:28:28 +0000 [thread overview]
Message-ID: <sashiko-outbox-173186@kernel.org> (raw)
In-Reply-To: <20261015161756.3078300-1-jmoroni@google.com>
> Previously, the IRDMAQPSQ_PBLADDR FRWR WQE field was being populated
> using a mask that was right-shifted, whereas it should have been the
> address being right-shifted.
>
> This ended up working fine in many cases because the lowermost 12 bits
> are always zero (the addresses are page aligned) and the uppermost 12
> bits are usually zero too, but it could break for DMA addresses that
> are wider than 52 bits.
>
> Fix this by right-shifting the address instead of the mask, similar
> to how it was done in the original i40iw driver.
>
> Tested with NFS over RDMA with some added debug logs to ensure it
> was hitting both the direct (single page) path as well as multi
> page (< 512).
>
> Fixes: 3f49d6842569 ("RDMA/irdma: Implement HW Admin Queue OPs")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261015161756.3078300-1-jmoroni@google.com?part=1
prev parent reply other threads:[~2026-10-15 16:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-15 16:17 [PATCH] RDMA/irdma: Fix FRWR IRDMAQPSQ_PBLADDR field population Jacob Moroni
2026-10-15 16:28 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173186@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jmoroni@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox