From: sashiko-bot@kernel.org
To: "Zhiwei Zhang" <202275009@qq.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/rxe: Clear pkt->qp before the early drop exits in rxe_rcv()
Date: Fri, 16 Oct 2026 02:19:51 +0000 [thread overview]
Message-ID: <sashiko-outbox-173617@kernel.org> (raw)
In-Reply-To: <tencent_1BF6EE2B5853D22DD4A2F3EBADE737905209@qq.com>
> rxe_rcv() puts pkt->qp at its drop label, but leaves pkt->qp
> uninitialized on the two paths that take an early goto:
>
> if (unlikely(skb->len < RXE_BTH_BYTES))
> goto drop;
>
> if (rxe_chk_dgid(rxe, skb) < 0)
> goto drop;
>
> pkt->opcode = bth_opcode(pkt);
> pkt->psn = bth_psn(pkt);
> pkt->qp = NULL; <- too late for the gotos above
> ...
> drop:
> if (pkt->qp)
> [ ... ]
> built in the environment used to prepare this, and the reproducer is
> left out of this message on purpose - both are available on request.
>
> Fixes: 8700e3e7c485 ("Soft RoCE driver")
> Signed-off-by: Zhiwei Zhang <202275009@qq.com>
Sashiko has reviewed this patch and found no issues. It looks great!
--
Sashiko AI review · https://sashiko.dev/#/patchset/tencent_1BF6EE2B5853D22DD4A2F3EBADE737905209@qq.com?part=1
prev parent reply other threads:[~2026-10-16 2:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 2:08 [PATCH] RDMA/rxe: Clear pkt->qp before the early drop exits in rxe_rcv() Zhiwei Zhang
2026-10-16 2:19 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-173617@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=202275009@qq.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox