Re: [PATCH net-next v1 1/4] net/mlx5: Don't free the ASO CQ if destroying it fails

[sashiko-bot@kernel.org]

> mlx5_aso_destroy_cq() ignores the result of mlx5_core_destroy_cq() and
> frees the CQ buffer and doorbell record anyway, and its callers then
> free the struct mlx5_aso that embeds the CQ. If DESTROY_CQ fails, the
> CQ may still exist in firmware and retain access to its buffer and
> doorbell record. mlx5_core_destroy_cq() also returns early in that case,
> without waiting for EQ handlers that may already hold a reference to
> the CQ.
> 
> Return the error from mlx5_aso_destroy_cq() and keep both the buffer
> and the struct mlx5_aso when it fails, as the regular mlx5_ib CQ destroy
> path does. A device in internal error is not affected, since the mlx5
> core reports success for DESTROY_CQ in that state.
> 
> Fixes: cdd04f4d4d71 ("net/mlx5: Add support to create SQ and CQ for ASO")
> Assisted-by: LLM
> Signed-off-by: Yuho Choi <oss.patchbox@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261016045849.813696-6-oss.patchbox@gmail.com?part=1