From: sashiko-bot@kernel.org
To: "Tariq Toukan" <tariqt@nvidia.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next 1/5] net/mlx5e: remove channel count limit for XOR8 RSS hash
Date: Fri, 30 Oct 2026 04:53:50 +0000 [thread overview]
Message-ID: <sashiko-outbox-17858@kernel.org> (raw)
In-Reply-To: <20260511172719.330490-2-tariqt@nvidia.com>
> From: Yael Chemla <ychemla@nvidia.com>
>
> mlx5e_ethtool_set_channels() and mlx5e_rxfh_hfunc_check() rejected
> channel counts that would produce an indirection table larger than 256
> entries when the XOR8 hash function was active. This check was
> introduced in commit 49e6c9387051 ("net/mlx5e: RSS, Block XOR hash
> with over 128 channels").
>
> XOR8 yields an 8-bit hash, so in practice only up to 256 entries in the
> indirection table can be reached due to limited entropy. However, this
> does not provide a strong justification for prohibiting larger
> indirection tables. Remove the limitation.
>
> Signed-off-by: Yael Chemla <ychemla@nvidia.com>
> Reviewed-by: Nimrod Oren <noren@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260511172719.330490-1-tariqt@nvidia.com?part=1
next prev parent reply other threads:[~2026-10-30 4:53 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-11 17:27 [PATCH net-next 0/5] net/mlx5e: improve RSS indirection table sizing and resizing Tariq Toukan
2026-05-11 17:27 ` [PATCH net-next 1/5] net/mlx5e: remove channel count limit for XOR8 RSS hash Tariq Toukan
2026-10-30 4:53 ` sashiko-bot [this message]
2026-05-11 17:27 ` [PATCH net-next 2/5] net/mlx5e: advertise max RSS indirection table size to ethtool Tariq Toukan
2026-05-11 17:27 ` [PATCH net-next 3/5] net/mlx5e: resize non-default RSS indirection tables on channel change Tariq Toukan
2026-10-30 4:53 ` sashiko-bot
2026-05-11 17:27 ` [PATCH net-next 4/5] net/mlx5e: resize configured default RSS context table " Tariq Toukan
2026-10-30 4:53 ` sashiko-bot
2026-05-11 17:27 ` [PATCH net-next 5/5] net/mlx5e: increase RSS indirection table spread factor Tariq Toukan
2026-05-14 2:20 ` [PATCH net-next 0/5] net/mlx5e: improve RSS indirection table sizing and resizing patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-17858@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=tariqt@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox