Re: [PATCH rdma-next 2/2] RDMA/irdma: Fix paged PBLE and virtual AEQ for PAGE_SIZE > 4K

[sashiko-bot@kernel.org]

> HMC page descriptors and the virtual AEQ PBL always assume 4K
> HW pages, but irdma_map_vm_page_list() returns one DMA address
> per PAGE_SIZE page and irdma_pble_get_paged_mem() sizes the chunk
> as PAGE_SIZE * pg_cnt.
> 
> This breaks when PAGE_SIZE is greater than 4K. For example, with
> a 64K PAGE_SIZE, the second HW page points to vaddr+64K whereas
> the driver assumes it to be at vaddr+4096, etc.
> 
> It also ends up using an incorrect chunk size which causes each
> paged chunk to claim 16x more PBL entries than what actually exist.
> 
> Fix these issues by taking into account the potential difference
> between the HW page size (4K) and the system PAGE_SIZE during
> allocation and mapping (so on a 64K kernel, each page ends up
> populating 16 PDs, etc.).
> 
> Fixes: 44d9e52977a1 ("RDMA/irdma: Implement device initialization definitions")
> Fixes: 915cc7ac0f8e ("RDMA/irdma: Add miscellaneous utility definitions")
> Tested-by: Leah Li <leahlijuan@google.com>
> Signed-off-by: Jacob Moroni <jmoroni@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261022210650.1182000-1-jmoroni@google.com?part=2