From: sashiko-bot@kernel.org
To: "Todd Freed" <toddfreed@meta.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net v3 2/4] psp: support ipv6 extension headers in psp_dev_rcv() decap
Date: Fri, 23 Oct 2026 23:55:46 +0000 [thread overview]
Message-ID: <sashiko-outbox-183440@kernel.org> (raw)
In-Reply-To: <20261023234640.1459291-3-toddfreed@meta.com>
> psp_dev_rcv() expects the udp header to immediately follow the fixed
> ipv6 header, so packets with ipv6 extension headers are dropped by the
> is_udp check. additionally, on decap it writes the inner nexthdr into
> the fixed header instead of into the last extension header.
>
> fix by skipping the extension headers to find the udp header, and on
> decap, setting the inner nexthdr on the last one.
>
> fragment and authentication headers (ah) are not supported in psp
> transport mode, so such packets are dropped.
>
> Fixes: 0eddb8023cee ("psp: provide decapsulation and receive helper for drivers")
> Signed-off-by: Todd Freed <toddfreed@meta.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261023234640.1459291-1-toddfreed@meta.com?part=2
next prev parent reply other threads:[~2026-10-23 23:55 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-23 23:46 [PATCH net v3 0/4] psp: fix transport mode with ipv6 extension headers Todd Freed
2026-10-23 23:46 ` [PATCH net v3 1/4] net/mlx5e: psp: tso: replace only the length in checksum seed Todd Freed
2026-10-23 23:55 ` sashiko-bot
2026-10-24 23:48 ` netdev-bot+sashiko
2026-10-27 15:16 ` Daniel Zahka
2026-10-23 23:46 ` [PATCH net v3 2/4] psp: support ipv6 extension headers in psp_dev_rcv() decap Todd Freed
2026-10-23 23:55 ` sashiko-bot [this message]
2026-10-24 23:48 ` netdev-bot+sashiko
2026-10-26 22:05 ` Todd Bert Freed
2026-10-27 0:58 ` Jakub Kicinski
2026-10-27 10:30 ` Björn Töpel
2026-10-27 17:57 ` Todd Bert Freed
2026-10-27 15:27 ` Daniel Zahka
2026-10-27 16:50 ` Todd Bert Freed
2026-10-23 23:46 ` [PATCH net v3 3/4] psp: support ipv6 extension headers in psp_dev_encapsulate() Todd Freed
2026-10-23 23:55 ` sashiko-bot
2026-10-23 23:46 ` [PATCH net v3 4/4] selftests: drv-net: psp: test ipv6 tcp socket with extension headers Todd Freed
2026-10-23 23:55 ` sashiko-bot
2026-10-24 23:48 ` netdev-bot+sashiko
2026-10-26 22:10 ` Todd Bert Freed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-183440@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=toddfreed@meta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox