Re: [PATCH net] net/mlx5e: Fix false WARN_ON_ONCE in flow steering cleanup during RX init failure

[sashiko-bot@kernel.org]

> From: Alexei Lazar <alazar@nvidia.com>
> 
> In mlx5e_init_nic_rx(), a failure subsequent to
> mlx5e_create_flow_steering() initiates an error cleanup flow, where
> mlx5e_destroy_flow_steering() calls mlx5e_del_vlan_rules() that contains
> WARN_ON_ONCE(fs->state_destroy).
> This warning fires because state_destroy is set before flow steering is
> fully initialized.
> 
> To fix this, initialize NIC flow steering with state_destroy cleared,
> and set state_destroy only after profile->init_rx() succeeds.
> This keeps the flag cleared while mlx5e_create_flow_steering() is
> building its tables, so its internal error paths can destroy partially
> created flow steering without triggering the warning.
> 
> [ ... ]
> Fixes: 8c7353b6f716 ("net/mlx5e: Fix VLAN cleanup flow")
> Signed-off-by: Alexei Lazar <alazar@nvidia.com>
> Signed-off-by: Gal Pressman <gal@nvidia.com>
> Reviewed-by: Shahar Shitrit <shshitrit@nvidia.com>
> Signed-off-by: Tariq Toukan <tariqt@nvidia.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261026072253.4118892-1-tariqt@nvidia.com?part=1