Re: [PATCH 2/3] RDMA/rtrs-srv: Balance the session device reference in sysfs setup

[sashiko-bot@kernel.org]

> The session device is initialized in get_or_create_srv(), and the
> reference that device_initialize() takes is meant to be dropped last, by
> free_srv().  Each path takes one more reference, which
> rtrs_srv_destroy_once_sysfs_root_folders() drops when the path goes
> away.  On the failure paths of the path sysfs setup this does not add
> up:
> 
> - rtrs_srv_create_once_sysfs_root_folders() calls put_device() when
>   device_add() or the creation of the "paths" kobject fails, then
>   unlocks srv->paths_mutex;
> - rtrs_srv_create_path_files() calls
>   rtrs_srv_destroy_once_sysfs_root_folders() when a later step fails,
>   but the per-path reference is only taken by process_info_req() after
>   rtrs_srv_create_path_files() succeeds.
> 
> [ ... ]
> Fixes: baa5b28b7a47 ("RDMA/rtrs-srv: Replace device_register with device_initialize and device_add")
> Fixes: e2853c49477d ("RDMA/rtrs-srv-sysfs: fix missing put_device")
> Cc: stable@vger.kernel.org
> Assisted-by: Claude:claude-opus-5-5 kbound
> Signed-off-by: Yuqiang Sun <izaiahsun@gmail.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261029042719.75868-1-izaiahsun@gmail.com?part=2