From: sashiko-bot@kernel.org
To: "Jacob Moroni" <jmoroni@google.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH RESEND rdma-next 1/2] RDMA/irdma: Do not allow rereg_mr to revive defunct MRs
Date: Thu, 29 Oct 2026 14:31:29 +0000 [thread overview]
Message-ID: <sashiko-outbox-189522@kernel.org> (raw)
In-Reply-To: <20261029141849.1575012-1-jmoroni@google.com>
> An MR can become "defunct" if a previous rereg_mr happened
> to fail in between deregistering the old MR in HW and
> reregistering it (e.g., due to ib_umem_get_va() failing
> in the IB_MR_REREG_TRANS case).
>
> In this case, the MR is left in a state where the umem may
> have already been released.
>
> If rereg_mr then runs again, but without IB_MR_REREG_TRANS,
> it will end up reregistering the MR with stale translation
> info.
>
> Fix this by rejecting any attempt to reregister an MR that
> has previously failed during rereg_mr after the point where
> the MR has been deregistered in HW.
>
> Fixes: 5ac388db27c4 ("RDMA/irdma: Add support to re-register a memory region")
> Signed-off-by: Jacob Moroni <jmoroni@google.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261029141849.1575012-1-jmoroni@google.com?part=1
prev parent reply other threads:[~2026-10-29 14:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 14:18 [PATCH RESEND rdma-next 1/2] RDMA/irdma: Do not allow rereg_mr to revive defunct MRs Jacob Moroni
2026-10-29 14:18 ` [PATCH RESEND rdma-next 2/2] RDMA/irdma: Do not change mr->pd in driver during rereg_mr Jacob Moroni
2026-10-29 14:37 ` sashiko-bot
2026-10-29 14:31 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-189522@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=jmoroni@google.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox