From: sashiko-bot@kernel.org
To: "Bobby Eshleman" <bobbyeshleman@gmail.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH net-next v3 2/8] net: netkit: declare NETMEM_TX_NO_DMA mode
Date: Fri, 30 Oct 2026 04:53:55 +0000 [thread overview]
Message-ID: <sashiko-outbox-190383@kernel.org> (raw)
In-Reply-To: <20260507-tcp-dm-netkit-v3-2-52821445867c@meta.com>
> From: Bobby Eshleman <bobbyeshleman@meta.com>
>
> Some virtual devices like netkit (or ifb) never DMA and never touch frag
> contents, they just forward the skb to another device. They are unable
> to forward unreadable skbs, however, because they fail to pass TX
> validation checks on dev->netmem_tx. The existing two-state
> NETMEM_TX_NONE / NETMEM_TX_DMA doesn't give the TX validator enough
> information to differentiate devices that will attempt DMA on the
> unreadable skb from those that will simply route it untouched.
>
> Add a third mode to the enum so drivers can indicate 1) if they have
> netmem TX support, and 2) if they do, whether they are DMA-capable:
>
> NETMEM_TX_NO_DMA - pass-through, device never DMAs
>
> Widen dev->netmem_tx from a 1-bit field to 2 bits to fit the new value,
> and declare netkit as NETMEM_TX_NO_DMA. Devmem TX support over these
> devices comes in a follow-up patch.
>
> Signed-off-by: Bobby Eshleman <bobbyeshleman@meta.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20260507-tcp-dm-netkit-v3-0-52821445867c@meta.com?part=2
next prev parent reply other threads:[~2026-10-30 4:53 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 2:27 [PATCH net-next v3 0/8] net: devmem: support devmem with netkit devices Bobby Eshleman
2026-05-08 2:27 ` [PATCH net-next v3 1/8] net: convert netmem_tx flag to enum Bobby Eshleman
2026-05-08 14:56 ` Stanislav Fomichev
2026-05-08 16:11 ` Bobby Eshleman
2026-10-30 4:53 ` sashiko-bot
2026-05-08 2:27 ` [PATCH net-next v3 2/8] net: netkit: declare NETMEM_TX_NO_DMA mode Bobby Eshleman
2026-05-08 14:57 ` Stanislav Fomichev
2026-10-30 4:53 ` sashiko-bot [this message]
2026-05-08 2:27 ` [PATCH net-next v3 3/8] net: devmem: support TX over NETMEM_TX_NO_DMA devices Bobby Eshleman
2026-05-08 15:01 ` Stanislav Fomichev
2026-05-08 16:19 ` Bobby Eshleman
2026-05-08 20:44 ` Jakub Kicinski
2026-05-08 20:47 ` Jakub Kicinski
2026-05-08 21:28 ` Bobby Eshleman
2026-05-08 22:27 ` Jakub Kicinski
2026-05-08 23:03 ` Bobby Eshleman
2026-10-30 4:53 ` sashiko-bot
2026-05-08 2:27 ` [PATCH net-next v3 4/8] selftests: drv-net: ncdevmem: add -n flag to skip NIC configuration Bobby Eshleman
2026-05-08 15:01 ` Stanislav Fomichev
2026-10-30 4:53 ` sashiko-bot
2026-05-08 2:27 ` [PATCH net-next v3 5/8] selftests: drv-net: make attr _nk_guest_ifname public Bobby Eshleman
2026-05-08 15:01 ` Stanislav Fomichev
2026-10-30 4:53 ` sashiko-bot
2026-05-08 2:27 ` [PATCH net-next v3 6/8] selftests: drv-net: refactor devmem command builders into lib module Bobby Eshleman
2026-05-08 15:03 ` Stanislav Fomichev
2026-05-08 16:19 ` Bobby Eshleman
2026-05-08 2:27 ` [PATCH net-next v3 7/8] selftests: drv-net: add primary_rx_redirect support to NetDrvContEnv Bobby Eshleman
2026-05-08 15:03 ` Stanislav Fomichev
2026-10-30 4:53 ` sashiko-bot
2026-05-08 2:27 ` [PATCH net-next v3 8/8] selftests: drv-net: add netkit devmem tests Bobby Eshleman
2026-05-08 15:03 ` Stanislav Fomichev
2026-10-30 4:53 ` sashiko-bot
2026-05-10 20:33 ` [PATCH net-next v3 0/8] net: devmem: support devmem with netkit devices Zhu Yanjun
2026-05-11 17:01 ` Bobby Eshleman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-190383@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=bobbyeshleman@gmail.com \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox