Re: [for-next v4 1/5] net: ionic: register PHC for rdma timestamping

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] ionic_get_ts_info incorrectly drops software timestamping capabilities for devices supporting only RDMA timestamping.
--

commit e70a276bad5dcce2118c120bed8e5cd4bc2c22fd
Author: Abhijit Gangurde <abhijit.gangurde@amd.com>

net: ionic: register PHC for rdma timestamping

Currently, the driver only registers the PTP Hardware Clock (PHC) if
Ethernet hardware timestamping is supported. Update the registration
logic to register the PHC if the device supports either Ethernet
hardware timestamping or RDMA completion timestamping.

> diff --git a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> index 78a802eb159f0..154ea1bef85d9 100644
> --- a/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> +++ b/drivers/net/ethernet/pensando/ionic/ionic_ethtool.c
> @@ -1018,10 +1018,14 @@ static int ionic_get_ts_info(struct net_device *netdev,
>  
>  	info->phc_index = ptp_clock_index(lif->phc->ptp);
>  
> -	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE |
> -				SOF_TIMESTAMPING_TX_HARDWARE |
> -				SOF_TIMESTAMPING_RX_HARDWARE |
> -				SOF_TIMESTAMPING_RAW_HARDWARE;
> +	info->so_timestamping = SOF_TIMESTAMPING_TX_SOFTWARE;
> +
> +	if (!(lif->hw_features & IONIC_ETH_HW_TIMESTAMP))
> +		return 0;

[Severity: Medium]
Does this early return omit software timestamping capabilities for devices
that only support RDMA timestamping?

Before this patch, devices supporting only RDMA timestamping (where
IONIC_ETH_HW_RDMA_TIMESTAMP is present but IONIC_ETH_HW_TIMESTAMP is not)
did not allocate lif->phc. Because lif->phc was NULL, ionic_get_ts_info()
would fall back to ethtool_op_get_ts_info(), which correctly advertises
SOF_TIMESTAMPING_TX_SOFTWARE, SOF_TIMESTAMPING_RX_SOFTWARE, and
SOF_TIMESTAMPING_SOFTWARE.

With this patch, lif->phc is allocated for RDMA-only devices, causing the
ethtool_op_get_ts_info() fallback to be skipped. The custom logic here
only sets SOF_TIMESTAMPING_TX_SOFTWARE and then returns 0, dropping the
SOF_TIMESTAMPING_RX_SOFTWARE and SOF_TIMESTAMPING_SOFTWARE capabilities
for these interfaces.

> +
> +	info->so_timestamping |= SOF_TIMESTAMPING_TX_HARDWARE |
> +				 SOF_TIMESTAMPING_RX_HARDWARE |
> +				 SOF_TIMESTAMPING_RAW_HARDWARE;

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20260610154216.712374-1-abhijit.gangurde@amd.com?part=1