Re: [PATCH rdma-next v4 3/6] RDMA/irdma: Support UMEM attribute for QP creation

[sashiko-bot@kernel.org]

> From: David Hu <xuehaohu@google.com>
> 
> Support the standard 1-step queue buffer creation model for QP by using
> `UVERBS_ATTR_CREATE_QP_BUF_UMEM` and `ib_umem_get_attr()`.
> 
> Add `irdma_setup_q_pbl_from_umem()` to allocate the backing MR and program
> hardware pble directly from the pinned umem. Proper umem and pble cleanup
> is added to `irdma_free_qp_rsrc()` upon QP destruction.
> 
> We retain backward compatibility for legacy 2-step registration if the
> UMEM attribute is not provided.
> 
> `irdma_alloc_iwmr()` assumed there is always a valid PD, which is valid
> for regular MR, and QP. That is not the case for CQ. This modernization
> fixes `irdma_alloc_iwmr()` to take in an `ibdev` to avoid a potential
> [ ... ]
> inlined in `utils.c` here because `irdma_free_iwmr` is statically scoped
> in `verbs.c`. Combining was considered, and we think it belongs to a
> future project.
> 
> Signed-off-by: David Hu <xuehaohu@google.com>

Sashiko has reviewed this patch and found no issues.

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261030181512.2056056-1-dhu@x6u.co?part=3