Re: [PATCH rdma v8 4/7] RDMA/zrdma: Add hardware resource initialization and verbs skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] RDMA/zrdma: duplicate ib_mtu_int_to_enum() logic in zxdh_mtu_int_to_enum()
--

commit 6c940106ffd314fb52ef54d2c5282f1990d4be08
Author: Yanze Zhang <zhang.yanze@zte.com.cn>

RDMA/zrdma: Add hardware resource initialization and verbs skeleton

This commit adds hardware resource initialization logic and a minimal verbs
layer skeleton for the zrdma driver. It allocates resource bitmaps and tables
in a single allocation and registers the RDMA device with basic device
operations.

> diff --git a/drivers/infiniband/hw/zrdma/zrdma_verbs.h b/drivers/infiniband/hw/zrdma/zrdma_verbs.h
> new file mode 100644
> index 0000000000000..a4b628651bf02
> --- /dev/null
> +++ b/drivers/infiniband/hw/zrdma/zrdma_verbs.h
> @@ -0,0 +1,134 @@

[ ... ]

> +static inline enum ib_mtu zxdh_mtu_int_to_enum(int mtu)
> +{
> +	mtu = mtu - ZXDH_MTU_HEADER_RSV;
> +	if (mtu >= 4096)
> +		return IB_MTU_4096;
> +	else if (mtu >= 2048)
> +		return IB_MTU_2048;
> +	else if (mtu >= 1024)
> +		return IB_MTU_1024;
> +	else if (mtu >= 512)
> +		return IB_MTU_512;
> +	else
> +		return IB_MTU_256;
> +}

[Severity: Low]
This isn't a bug, but in zxdh_mtu_int_to_enum() in
drivers/infiniband/hw/zrdma/zrdma_verbs.h, after subtracting
ZXDH_MTU_HEADER_RSV from mtu, the threshold comparison ladder duplicates
ib_mtu_int_to_enum() from include/rdma/ib_verbs.h, which this header already
includes. Could zxdh_mtu_int_to_enum() simply return
ib_mtu_int_to_enum(mtu - ZXDH_MTU_HEADER_RSV) instead?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261102082026.2645777-1-zhang.yanze@zte.com.cn?part=4