From: sashiko-bot@kernel.org
To: "Li Xiasong" <lixiasong1@huawei.com>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH v2 2/3] rpcrdma: Pin notifications during removal callbacks
Date: Tue, 03 Nov 2026 03:21:15 +0000 [thread overview]
Message-ID: <sashiko-outbox-194507@kernel.org> (raw)
In-Reply-To: <20261103032758.1302493-3-lixiasong1@huawei.com>
> rpcrdma_remove_one() can race with unregister and invoke a notification
> callback after its owner is freed. XArray RCU does not pin stored objects.
>
> Pin notification owners under rpcrdma_device_mutex and serialize
> unregister with the same lock. Also pin client RPC transports. Skip
> owners in final release with kref_get_unless_zero().
>
> Invoke rn_done and release references outside the mutex. Track references
> separately so partial acquisition can be unwound without accessing freed
> owners or waiting for XPRT_LOCKED under the device mutex.
>
> Fixes: 7e86845a0346 ("rpcrdma: Implement generic device removal")
> Signed-off-by: Li Xiasong <lixiasong1@huawei.com>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103032758.1302493-1-lixiasong1@huawei.com?part=2
next prev parent reply other threads:[~2026-11-03 3:21 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 3:27 [PATCH v2 0/3] rpcrdma: Fix device removal races and endpoint cleanup Li Xiasong
2026-11-03 3:27 ` [PATCH v2 1/3] rpcrdma: Serialize notification registration with device removal Li Xiasong
2026-11-03 3:16 ` sashiko-bot
2026-11-03 22:06 ` Chuck Lever
2026-11-03 3:27 ` [PATCH v2 2/3] rpcrdma: Pin notifications during removal callbacks Li Xiasong
2026-11-03 3:21 ` sashiko-bot [this message]
2026-11-03 22:06 ` Chuck Lever
2026-11-03 3:27 ` [PATCH v2 3/3] xprtrdma: Wake connect worker on device removal Li Xiasong
2026-11-03 3:30 ` sashiko-bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194507@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=lixiasong1@huawei.com \
--cc=sashiko-reviews@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox