From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/cm: Release the GID attribute even if its port has no CM support
Date: Tue, 03 Nov 2026 08:16:06 +0000 [thread overview]
Message-ID: <sashiko-outbox-194813@kernel.org> (raw)
In-Reply-To: <20261103081103.1134475-1-vulab@iscas.ac.cn>
> When no source GID attribute is supplied, get_cm_port_from_path() looks
> one up with rdma_find_gid(). A successful lookup takes a reference even
> if the matching port has no CM port object. cm_add_one() skips ports
> without IB CM support, so cm_dev->port[] can contain NULL entries.
>
> The current cleanup tests port instead of the lookup result, leaking the
> GID attribute reference when a matching non-CM port is found. Test whether
> the attribute is valid before releasing it. Keep the put outside the
> CM device lock and skip it for a failed lookup or an empty device list.
>
> Fixes: 398391071f25 ("IB/cm: Replace members of sa_path_rec with 'struct sgid_attr *'")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103081103.1134475-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 8:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:11 [PATCH] RDMA/cm: Release the GID attribute even if its port has no CM support Wentao Liang
2026-11-03 8:16 ` sashiko-bot [this message]
2026-11-03 9:28 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194813@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox