From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/ocrdma: Release user memory when MR registration fails
Date: Tue, 03 Nov 2026 08:19:38 +0000 [thread overview]
Message-ID: <sashiko-outbox-194817@kernel.org> (raw)
In-Reply-To: <20261103081212.1137625-1-vulab@iscas.ac.cn>
> ocrdma_reg_user_mr() pins and maps user memory before preparing its page
> buffer list and registering the MR. If any subsequent step fails, the
> error paths free the MR and any allocated PBL tables, but never release
> the user memory. The pages remain pinned and DMA mapped, and the locked
> memory accounting is not restored.
>
> Release the umem on these failures. Use a separate label for failure of
> ib_umem_get_va() itself so its error pointer is never passed to the
> release function.
>
> Fixes: fe2caefcdf58 ("RDMA/ocrdma: Add driver for Emulex OneConnect IBoE RDMA adapter")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103081212.1137625-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 8:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:12 [PATCH] RDMA/ocrdma: Release user memory when MR registration fails Wentao Liang
2026-11-03 8:19 ` sashiko-bot [this message]
2026-11-03 9:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194817@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox