From: sashiko-bot@kernel.org
To: "Wentao Liang" <vulab@iscas.ac.cn>
Cc: linux-rdma@vger.kernel.org
Subject: Re: [PATCH] RDMA/qedr: Unwind user queue setup if doorbell recovery setup fails
Date: Tue, 03 Nov 2026 08:25:47 +0000 [thread overview]
Message-ID: <sashiko-outbox-194823@kernel.org> (raw)
In-Reply-To: <20261103081732.1144512-1-vulab@iscas.ac.cn>
> qedr_init_user_queue() pins user memory and allocates its PBL before
> initializing the doorbell recovery record. If the last step fails, it
> returns directly without releasing either resource. The CQ and QP
> creation callers treat this as a failed queue initialization and do not
> release that queue, leaving its user pages pinned and PBL storage leaked.
>
> Free the PBL on doorbell recovery setup failure, then use the existing
> umem cleanup. Match the PBL allocation mode: RoCE uses the populated PBL
> allocator, while the other path allocates only the table descriptor.
> Clear the freed pointer as well.
>
> Fixes: 97f612509294 ("RDMA/qedr: Add doorbell overflow recovery support")
> Cc: stable@vger.kernel.org
> Assisted-by: DeepSeek-V4.1-Flash and OpenAI Codex
> Signed-off-by: Wentao Liang <vulab@iscas.ac.cn>
Sashiko has reviewed this patch and found no issues.
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261103081732.1144512-1-vulab@iscas.ac.cn?part=1
next prev parent reply other threads:[~2026-11-03 8:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-03 8:17 [PATCH] RDMA/qedr: Unwind user queue setup if doorbell recovery setup fails Wentao Liang
2026-11-03 8:25 ` sashiko-bot [this message]
2026-11-03 9:21 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-194823@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=vulab@iscas.ac.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox