Re: [PATCH rdma v9 1/7] RDMA/zrdma: Add build infrastructure and module skeleton

[sashiko-bot@kernel.org]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Low] RDMA/zrdma: open-coded zrdma_module_init() instead of module_auxiliary_driver()
--

commit 752d6c4a965c859c6d742178ece9515bf23454aa
Author: Yanze Zhang <zhang.yanze@zte.com.cn>

RDMA/zrdma: Add build infrastructure and module skeleton

This commit adds the MAINTAINERS entry, Kconfig, Makefile, and a minimal
auxiliary driver module skeleton for the ZTE DingHai RDMA driver.

> diff --git a/drivers/infiniband/hw/zrdma/zrdma_main.c b/drivers/infiniband/hw/zrdma/zrdma_main.c
> new file mode 100644
> index 0000000000000..80856c7ff6b2a
> --- /dev/null
> +++ b/drivers/infiniband/hw/zrdma/zrdma_main.c

[ ... ]

> +static struct auxiliary_driver zxdh_auxiliary_drv = {
> +	.name = "rdma_aux",
> +	.id_table = zxdh_auxiliary_id_table,
> +	.probe = zxdh_probe,
> +	.remove = zxdh_remove,
> +};
> +
> +static int __init zrdma_module_init(void)
> +{
> +	return auxiliary_driver_register(&zxdh_auxiliary_drv);
> +}
> +
> +static void __exit zrdma_module_exit(void)
> +{
> +	auxiliary_driver_unregister(&zxdh_auxiliary_drv);
> +}
> +
> +module_init(zrdma_module_init);
> +module_exit(zrdma_module_exit);

[Severity: Low]
As reported by Sashiko on v8 [1], this isn't a bug, but since
zrdma_module_init() and zrdma_module_exit() only call
auxiliary_driver_register() and auxiliary_driver_unregister() on
zxdh_auxiliary_drv (including at the end of the patch series), could these
wrappers be replaced with module_auxiliary_driver(zxdh_auxiliary_drv) from
include/linux/auxiliary_bus.h?

[1] https://lore.kernel.org/r/20261102082026.2645777-2-zhang.yanze@zte.com.cn

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261103125654.2707069-1-zhang.yanze@zte.com.cn?part=1