From: sashiko-bot@kernel.org
To: "Stephen Bates" <sbates@raithlin.com>, linux-rdma@vger.kernel.org
Subject: Re: [PATCH] perftest: add a ROCm build to CI
Date: Wed, 04 Nov 2026 15:55:44 +0000 [thread overview]
Message-ID: <sashiko-outbox-197557@kernel.org> (raw)
In-Reply-To: <20261104155023.250706-1-sbates@raithlin.com>
Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [Medium] perftest: matrix.rocm_arch is never passed to configure or make in CI workflow
--
commit dee5fbc3aa52f87f3e4be6e0329a0a27dacd8a09
Author: Stephen Bates <sbates@raithlin.com>
perftest: add a ROCm build to CI
This commit adds a GitHub Actions workflow to build perftest with ROCm and
ROCm dmabuf support enabled on Ubuntu 24.04 inside AMD's slim ROCm container
image across a matrix of gfx950 and gfx1250 targets.
Link: https://github.com/linux-rdma/perftest/pull/418
> diff --git a/.github/workflows/ubuntu24_04_rocm7_2.yaml b/.github/workflows/ubuntu24_04_rocm7_2.yaml
> new file mode 100644
> index 0000000000000..0a4c706ea5ca5
> --- /dev/null
> +++ b/.github/workflows/ubuntu24_04_rocm7_2.yaml
> @@ -0,0 +1,66 @@
[ ... ]
> + strategy:
> + fail-fast: false
> + matrix:
> + rocm_arch: [gfx950, gfx1250]
> +
> + name: ROCm (${{ matrix.rocm_arch }})
> +
> + steps:
[ ... ]
> + - name: Set up ROCm environment
> + run: |
> + echo "ROCM_PATH=/opt/rocm" >> $GITHUB_ENV
> + echo "/opt/rocm/bin" >> $GITHUB_PATH
> +
> + - name: Run autogen.sh
> + run: ./autogen.sh
> +
> + - name: Configure the build
> + run: |
> + ./configure --enable-rocm --enable-rocm-dmabuf \
> + --with-rocm="$ROCM_PATH"
> +
> + - name: Build perftest
> + run: make
[Severity: Medium]
In .github/workflows/ubuntu24_04_rocm7_2.yaml, jobs.build.strategy.matrix
defines rocm_arch with gfx950 and gfx1250, and the commit message notes that
this tests compilation across both Instinct generations.
However, ${{ matrix.rocm_arch }} is only referenced in the job display name
and is never exported to the environment or passed to ./configure or make in
jobs.build.steps.
Since GitHub Actions does not automatically export matrix variables into run
steps, won't both legs of the matrix run identical builds without targeting
either gfx950 or gfx1250?
--
Sashiko AI review · https://sashiko.dev/#/patchset/20261104155023.250706-1-sbates@raithlin.com?part=1
prev parent reply other threads:[~2026-11-04 15:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 15:50 [PATCH] perftest: add a ROCm build to CI Stephen Bates
2026-11-04 15:55 ` sashiko-bot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sashiko-outbox-197557@kernel.org \
--to=sashiko-bot@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=sashiko-reviews@lists.linux.dev \
--cc=sbates@raithlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox